OpenAI's Codex Security CLI and TypeScript SDK for finding, validating, and fixing security vulnerabilities. npm: https://www.npmjs.com/package/@openai/codex-security
TypeScript ai-securityapplication-securityclicode-scanningcodexcodex-securitycybersecuritydevsecopsnodejsnpmopenaisdksecuritytypescriptvulnerability-scanning
fix: seal drafts with empty artifact lists (#941)
ianw-oai936d850ae274
diff --git a/plugins/codex-security/scripts/finalize_scan_contract.py b/plugins/codex-security/scripts/finalize_scan_contract.pyindex 58cac8f1f..6f62ade1e 100644--- a/plugins/codex-security/scripts/finalize_scan_contract.py+++ b/plugins/codex-security/scripts/finalize_scan_contract.py@@ -2679,6 +2679,8 @@ def _prepare_scan_finalization(else _read_scan_local_json(scan_dir, "scan-manifest.json", "scan-manifest.json"))scan = _require_dict(manifest, "scan", "manifest")+ if scan.get("sealedAt") is None and scan.get("artifacts") == []:+ del scan["artifacts"]was_sealed = scan.get("sealedAt") is not None or scan.get("artifacts") is not Noneif not was_sealed:_populate_unsealed_manifest_envelope(manifest, scan, completion_binding)diff --git a/plugins/codex-security/tests/test_finalize_scan_contract.py b/plugins/codex-security/tests/test_finalize_scan_contract.pyindex 9cedd21ad..9be87be40 100644--- a/plugins/codex-security/tests/test_finalize_scan_contract.py+++ b/plugins/codex-security/tests/test_finalize_scan_contract.py@@ -2949,19 +2949,27 @@ The extraction root is not enforced.FINALIZER.finalize_scan(self.scan_dir)def test_finalizes_no_findings_scan(self) -> None:+ self.manifest["scan"]["artifacts"] = []self.findings["findings"] = []+ self.coverage["mode"] = "diff"+ self.coverage["inventoryStrategy"] = "diff"self.coverage["surfaces"][0]["disposition"] = "no_issue_found"self.write_scan()- (self.scan_dir / "report.md").write_text(- "# Security Review: example/repo\n\n## Findings\n\nNo findings.\n",- encoding="utf-8",- )+ (self.scan_dir / "report.md").unlink()FINALIZER.finalize_scan(self.scan_dir)findings = self.read_json("findings.json")self.assertEqual(findings["findings"], [])+ self.assertTrue((self.scan_dir / "report.md").is_file())sarif = self.read_json("exports/results.sarif")self.assertEqual(sarif["runs"][0]["results"], [])+ def test_rejects_empty_artifacts_with_existing_seal(self) -> None:+ self.manifest["scan"]["sealedAt"] = self.manifest["scan"]["completedAt"]+ self.manifest["scan"]["artifacts"] = []+ self.write_scan()+ with self.assertRaisesRegex(FINALIZER.ContractError, "requires artifact records"):+ FINALIZER.finalize_scan(self.scan_dir)+def test_sarif_encodes_location_as_relative_uri(self) -> None:self.finding["locations"][0]["path"] = "src/archive handlers/extract.py"sarif_finding = copy.deepcopy(self.finding)