Skip to content

OpenAI's Codex Security CLI and TypeScript SDK for finding, validating, and fixing security vulnerabilities. npm: https://www.npmjs.com/package/@openai/codex-security

refactor: compare Deep Scan progress fields directly (#1458)

mldangelo-oai983bb2a2f5b2
diff --git a/sdk/typescript/src/deep-progress.ts b/sdk/typescript/src/deep-progress.ts
index 9800dfcb6..0c6821c96 100644
--- a/sdk/typescript/src/deep-progress.ts
+++ b/sdk/typescript/src/deep-progress.ts
@@ -53,7 +53,10 @@ export class DeepScanProgressTracker {
if (
abortController.signal.aborted ||
progress === null ||
- sameProgress(progress, this.#lastProgress)
+ (progress.completed === this.#lastProgress?.completed &&
+ progress.active === this.#lastProgress?.active &&
+ progress.maximum === this.#lastProgress?.maximum &&
+ progress.consolidating === this.#lastProgress?.consolidating)
) {
return;
}
@@ -107,16 +110,3 @@ export function deepScanProgressFromWorkbench(
"Codex Security workbench returned invalid Deep Scan progress.",
);
}
-
-function sameProgress(
- left: DeepScanProgress,
- right: DeepScanProgress | null,
-): boolean {
- return (
- right !== null &&
- left.completed === right.completed &&
- left.active === right.active &&
- left.maximum === right.maximum &&
- left.consolidating === right.consolidating
- );
-}