Skip to content

OpenAI's Codex Security CLI and TypeScript SDK for finding, validating, and fixing security vulnerabilities. npm: https://www.npmjs.com/package/@openai/codex-security

test(cli): stabilize non-Git patch fixtures (#902)

mldangelo-oai9e52775ba26b
diff --git a/sdk/typescript/tests-ts/cli-patch-results.test.ts b/sdk/typescript/tests-ts/cli-patch-results.test.ts
index febd49243..8f3620a3e 100644
--- a/sdk/typescript/tests-ts/cli-patch-results.test.ts
+++ b/sdk/typescript/tests-ts/cli-patch-results.test.ts
@@ -13,7 +13,7 @@ afterEach(async () => {
await rm(directory, { recursive: true, force: true });
});
-async function repositoryFixture() {
+async function repositoryFixture({ initializeGit = true } = {}) {
const directory = await mkdtemp(join(tmpdir(), "patch-results-"));
directories.push(directory);
const runRepositoryCommand: NonNullable<
@@ -29,12 +29,14 @@ async function repositoryFixture() {
};
const git = (...args: string[]) =>
runRepositoryCommand("git", args, directory);
- git("init", "--initial-branch=main");
- git("config", "user.name", "Synthetic User");
- git("config", "user.email", "[email protected]");
await writeFile(join(directory, "app.ts"), "original\n");
- git("add", ".");
- git("commit", "-m", "Synthetic fixture");
+ if (initializeGit) {
+ git("init", "--initial-branch=main");
+ git("config", "user.name", "Synthetic User");
+ git("config", "user.email", "[email protected]");
+ git("add", ".");
+ git("commit", "-m", "Synthetic fixture");
+ }
return {
directory,
git,
@@ -180,11 +182,7 @@ lines.on("line", (line) => {
test.each([false, true])(
"checks patch changes outside a Git repository: %s",
async (apply) => {
- const fixture = await repositoryFixture();
- await rm(join(fixture.directory, ".git"), {
- recursive: true,
- force: true,
- });
+ const fixture = await repositoryFixture({ initializeGit: false });
const outcome = await fixture.patch(["Synthetic issue"], {
onCodex: async () => {
if (apply)
@@ -192,11 +190,15 @@ lines.on("line", (line) => {
return 0;
},
});
- expect(outcome.status).toBe(apply ? 0 : 2);
+ expect(outcome.status, outcome.stderr).toBe(apply ? 0 : 2);
expect(outcome.result).toMatchObject({
applied: apply,
filesChanged: apply ? 1 : 0,
});
+ if (!apply)
+ expect(outcome.result.error).toMatchObject({
+ code: "NO_PATCH_APPLIED",
+ });
},
);