Skip to content

OpenAI's Codex Security CLI and TypeScript SDK for finding, validating, and fixing security vulnerabilities. npm: https://www.npmjs.com/package/@openai/codex-security

refactor(mcp): remove unused artifact declarations (#1483)

mldangelo-oaia052bdeccd51
diff --git a/plugins/codex-security/mcp-app/src/artifact-deep-reducer-pages.ts b/plugins/codex-security/mcp-app/src/artifact-deep-reducer-pages.ts
index 97643723a..66230d59b 100644
--- a/plugins/codex-security/mcp-app/src/artifact-deep-reducer-pages.ts
+++ b/plugins/codex-security/mcp-app/src/artifact-deep-reducer-pages.ts
@@ -22,14 +22,12 @@ export interface DeepReducerPage {
type Finding = DeepReductionInput["findings"][number];
-interface ReducerDocuments {
- inputs: string;
- findings: Map<string, Finding | string>;
-}
-
// Each artifact server binds one immutable reducer assignment. Cache that
// snapshot so small pages do not repeatedly read and serialize all inputs.
-const documents = new WeakMap<ArtifactContext, Promise<ReducerDocuments>>();
+const documents = new WeakMap<
+ ArtifactContext,
+ Promise<ReturnType<typeof createDocuments>>
+>();
/** The single payload representation used by both the tool and byte accounting. */
export function deepReducerPageResponse(page: DeepReducerPage): {
@@ -67,7 +65,7 @@ export async function getCodexSecurityDeepReducerInputsPage(
return pageDocument(json, input);
}
-function createDocuments(sources: DeepReductionSources): ReducerDocuments {
+function createDocuments(sources: DeepReductionSources) {
const findings = new Map<string, Finding | string>();
const discoveries = sources.discoveries.map((discovery) => ({
workerId: discovery.workerId,
diff --git a/plugins/codex-security/mcp-app/src/artifact-deep-reducer.ts b/plugins/codex-security/mcp-app/src/artifact-deep-reducer.ts
index f0efd8b29..5c30ae859 100644
--- a/plugins/codex-security/mcp-app/src/artifact-deep-reducer.ts
+++ b/plugins/codex-security/mcp-app/src/artifact-deep-reducer.ts
@@ -3,10 +3,7 @@ import type { ZodType } from "zod/v4";
import commonSchema from "../../schemas/definitions/artifact-common.schema.json";
import reducerSchema from "../../schemas/tools/deep-reducer.schema.json";
import scanDraftSchema from "../../schemas/tools/scan-draft.schema.json";
-import type {
- ArtifactContext,
- DeepReducerContext,
-} from "./artifact-context.js";
+import type { ArtifactContext } from "./artifact-context.js";
import type { DeepReducerPageInput } from "./artifact-deep-reducer-pages.js";
import {
parsePersistedScanDraft,
@@ -22,7 +19,6 @@ import {
readJsonObject,
requireRegularFile,
writeJsonAtomic,
- type DeepScanArtifacts,
} from "./deep-scan/artifacts.js";
import {
parseDeepReduction,
@@ -50,13 +46,6 @@ export const deepReductionInputSchema = loadArtifactZodSchema(
"reductionInput",
) as ZodType<DeepReductionInput>;
-interface BoundReducer {
- artifacts: DeepScanArtifacts;
- state: DeepReducerContext;
- resultPath: string;
- scanId?: string;
-}
-
/** Read the findings and scan context assigned to this reducer. */
export async function getCodexSecurityDeepReducerInputs(
context: ArtifactContext,
@@ -152,7 +141,7 @@ export async function recordCodexSecurityDeepReduction(
});
}
-function bindDeepReducer(context: ArtifactContext): BoundReducer {
+function bindDeepReducer(context: ArtifactContext) {
const state = context.deepReducer;
if (context.layout !== "reducer" || !state) {
throw new Error(
@@ -191,7 +180,7 @@ function bindDeepReducer(context: ArtifactContext): BoundReducer {
}
async function readPreviousReduction(
- bound: BoundReducer,
+ bound: ReturnType<typeof bindDeepReducer>,
): Promise<DeepReductionInput | null> {
const { previousReducerResultPath } = bound.state;
if (!previousReducerResultPath) return null;
diff --git a/plugins/codex-security/mcp-app/src/artifact-discovery.ts b/plugins/codex-security/mcp-app/src/artifact-discovery.ts
index e8c285276..f6546a32b 100644
--- a/plugins/codex-security/mcp-app/src/artifact-discovery.ts
+++ b/plugins/codex-security/mcp-app/src/artifact-discovery.ts
@@ -95,16 +95,6 @@ export const workbenchListCodexSecurityCandidatesInputSchema =
"workbenchListCandidatesInput",
) as z.ZodType<ListCodexSecurityCandidatesInput & { scanId: string }>;
-export interface RecordCodexSecurityDiscoveryCandidatesResult {
- operation: "replace";
- candidatesRecorded: number;
-}
-
-export interface ListCodexSecurityCandidatesResult {
- rows: CompactDiscoveryCandidate[];
- nextCursor?: string;
-}
-
/**
* Invoke the shared discovery normalizer. Only its canonical output persists;
* raw candidate input is kept in a private temporary directory and always removed.
@@ -112,7 +102,7 @@ export interface ListCodexSecurityCandidatesResult {
export async function recordCodexSecurityDiscoveryCandidates(
input: DiscoveryCandidatesInput,
context: ArtifactContext,
-): Promise<RecordCodexSecurityDiscoveryCandidatesResult> {
+) {
const { candidates } = discoveryCandidatesInputSchema.parse(input);
const pluginRoot = context.pluginRoot?.trim();
if (!pluginRoot) {
@@ -200,7 +190,7 @@ export async function recordCodexSecurityDiscoveryCandidates(
candidateSchemaV1,
);
return {
- operation: "replace",
+ operation: "replace" as const,
candidatesRecorded: normalized.length,
};
} finally {
@@ -214,7 +204,7 @@ export async function recordCodexSecurityDiscoveryCandidates(
export async function listCodexSecurityCandidates(
input: ListCodexSecurityCandidatesInput,
context: ArtifactContext,
-): Promise<ListCodexSecurityCandidatesResult> {
+) {
const page = listCodexSecurityCandidatesInputSchema.parse(input);
const rows = await readArtifactJsonl(
context,
diff --git a/plugins/codex-security/mcp-app/src/artifact-inventory.ts b/plugins/codex-security/mcp-app/src/artifact-inventory.ts
index dac816920..991bef38d 100644
--- a/plugins/codex-security/mcp-app/src/artifact-inventory.ts
+++ b/plugins/codex-security/mcp-app/src/artifact-inventory.ts
@@ -29,15 +29,6 @@ export interface ReviewItem {
path: string;
}
-export interface ReviewItemsResult {
- items: ReviewItem[];
- nextCursor?: string;
-}
-
-export interface PreparedReviewItems {
- reviewItemsTotal: number;
-}
-
export const prepareReviewItemsInputSchema = loadArtifactZodSchema(
documents,
reviewItemsSchema.$id,
@@ -59,7 +50,7 @@ const reviewItemSchema = loadArtifactZodSchema(
/** Build the selected repository or diff inventory from host-bound scan context. */
export async function prepareCodexSecurityReviewItems(
context: ArtifactContext,
-): Promise<PreparedReviewItems> {
+) {
if (context.layout !== "scan") {
throw new Error(
`${label}: only a parent scan can prepare its shared inventory.`,
@@ -144,7 +135,7 @@ export async function prepareCodexSecurityReviewItems(
export async function listCodexSecurityReviewItems(
context: ArtifactContext,
page: ArtifactPage = {},
-): Promise<ReviewItemsResult> {
+) {
const result = paginateArtifactRows(
await readReviewItems(context),
page,
diff --git a/plugins/codex-security/mcp-app/tests/test_artifact_foundation.ts b/plugins/codex-security/mcp-app/tests/test_artifact_foundation.ts
index 8720c5673..107747940 100644
--- a/plugins/codex-security/mcp-app/tests/test_artifact_foundation.ts
+++ b/plugins/codex-security/mcp-app/tests/test_artifact_foundation.ts
@@ -55,7 +55,6 @@ const components = ["artifacts", "02_discovery", "candidate_ledger.jsonl"];
try {
await testSchemaSourceOfTruth();
- await testWorkerThreatModelSchema();
await testScanContext();
await testWorkerStandardLayout();
await testSafeJsonAndJsonl();
@@ -69,25 +68,6 @@ try {
console.log("Codex Security compact artifact foundation tests passed");
-async function testWorkerThreatModelSchema() {
- const schema = await readJson(
- import.meta.dirname,
- "../../schemas/tools/worker-threat-model.schema.json",
- );
- assert.equal(schema.$schema, "https://json-schema.org/draft/2020-12/schema");
- assert.equal(
- schema.$id,
- "codex-security://schemas/tools/worker-threat-model.schema.json",
- );
- const input = schema.$defs.recordWorkerThreatModelInput;
- assert.deepEqual(Object.keys(input.properties), ["content"]);
- assert.deepEqual(input.required, ["content"]);
- assert.equal(input.additionalProperties, false);
- assert.equal(input.properties.content.type, "string");
- assert.equal(input.properties.content.minLength, 1);
- assert.equal(input.properties.content.pattern, "\\S");
-}
-
async function testSchemaSourceOfTruth() {
const common = await readJson(
import.meta.dirname,
diff --git a/plugins/codex-security/plugin-files.json b/plugins/codex-security/plugin-files.json
index 856202bb4..b051eb870 100644
--- a/plugins/codex-security/plugin-files.json
+++ b/plugins/codex-security/plugin-files.json
@@ -57,7 +57,6 @@
"schemas/tools/discovery-candidates.schema.json",
"schemas/tools/review-items.schema.json",
"schemas/tools/scan-draft.schema.json",
- "schemas/tools/worker-threat-model.schema.json",
"scripts/config_preflight.py",
"scripts/codex_profile.mjs",
"scripts/deep_scan_config.py",
diff --git a/plugins/codex-security/schemas/tools/discovery-candidates.schema.json b/plugins/codex-security/schemas/tools/discovery-candidates.schema.json
index 6da9f8c6a..e69f51cb0 100644
--- a/plugins/codex-security/schemas/tools/discovery-candidates.schema.json
+++ b/plugins/codex-security/schemas/tools/discovery-candidates.schema.json
@@ -49,32 +49,6 @@
},
"required": ["scanId"],
"additionalProperties": false
- },
- "recordDiscoveryCandidatesResult": {
- "type": "object",
- "properties": {
- "operation": { "const": "replace" },
- "candidatesRecorded": { "type": "integer", "minimum": 0 }
- },
- "required": ["operation", "candidatesRecorded"],
- "additionalProperties": false
- },
- "listCandidatesResult": {
- "type": "object",
- "properties": {
- "rows": {
- "type": "array",
- "items": {
- "$ref": "codex-security://schemas/definitions/discovery-candidate.schema.json#/$defs/discoveryCandidate"
- }
- },
- "nextCursor": {
- "type": "string",
- "pattern": "^(?:0|[1-9][0-9]*)$"
- }
- },
- "required": ["rows"],
- "additionalProperties": false
}
}
}
diff --git a/plugins/codex-security/schemas/tools/review-items.schema.json b/plugins/codex-security/schemas/tools/review-items.schema.json
index 3b11ca002..f94e37db6 100644
--- a/plugins/codex-security/schemas/tools/review-items.schema.json
+++ b/plugins/codex-security/schemas/tools/review-items.schema.json
@@ -15,17 +15,6 @@
"required": ["scanId"],
"additionalProperties": false
},
- "prepareOutput": {
- "type": "object",
- "properties": {
- "reviewItemsTotal": {
- "type": "integer",
- "minimum": 0
- }
- },
- "required": ["reviewItemsTotal"],
- "additionalProperties": false
- },
"reviewItemsInput": {
"type": "object",
"properties": {
@@ -48,9 +37,6 @@
"required": ["scanId"],
"additionalProperties": false
},
- "reviewItemsWorkerInput": {
- "$ref": "codex-security://schemas/definitions/artifact-common.schema.json#/$defs/page"
- },
"reviewItem": {
"type": "object",
"properties": {
@@ -60,21 +46,6 @@
},
"required": ["path"],
"additionalProperties": false
- },
- "reviewItemsOutput": {
- "type": "object",
- "properties": {
- "items": {
- "type": "array",
- "items": { "$ref": "#/$defs/reviewItem" }
- },
- "nextCursor": {
- "type": "string",
- "pattern": "^(?:0|[1-9][0-9]*)$"
- }
- },
- "required": ["items"],
- "additionalProperties": false
}
}
}
diff --git a/plugins/codex-security/schemas/tools/worker-threat-model.schema.json b/plugins/codex-security/schemas/tools/worker-threat-model.schema.json
deleted file mode 100644
index 8f883bc3d..000000000
--- a/plugins/codex-security/schemas/tools/worker-threat-model.schema.json
+++ /dev/null
@@ -1,18 +0,0 @@
-{
- "$schema": "https://json-schema.org/draft/2020-12/schema",
- "$id": "codex-security://schemas/tools/worker-threat-model.schema.json",
- "$defs": {
- "recordWorkerThreatModelInput": {
- "type": "object",
- "properties": {
- "content": {
- "type": "string",
- "minLength": 1,
- "pattern": "\\S"
- }
- },
- "required": ["content"],
- "additionalProperties": false
- }
- }
-}