OpenAI's Codex Security CLI and TypeScript SDK for finding, validating, and fixing security vulnerabilities. npm: https://www.npmjs.com/package/@openai/codex-security
TypeScript ai-securityapplication-securityclicode-scanningcodexcodex-securitycybersecuritydevsecopsnodejsnpmopenaisdksecuritytypescriptvulnerability-scanning
fix(server): cancel failed embedding response bodies (#1232)
Sylvester Kaczmareka767478ca179
diff --git a/sdk/typescript/src/server/embeddings.ts b/sdk/typescript/src/server/embeddings.tsindex 474bd9ed5..31b539f54 100644--- a/sdk/typescript/src/server/embeddings.ts+++ b/sdk/typescript/src/server/embeddings.ts@@ -104,6 +104,7 @@ export class OpenAiFindingEmbedder implements FindingEmbedder {);}if (!response.ok) {+ void response.body?.cancel().catch(() => undefined);throw new FindingsError("embedding_failed",`Embedding provider returned HTTP ${response.status}.`,diff --git a/sdk/typescript/tests-ts/finding-embeddings.test.ts b/sdk/typescript/tests-ts/finding-embeddings.test.tsindex cc5b13fd6..4fd911a99 100644--- a/sdk/typescript/tests-ts/finding-embeddings.test.ts+++ b/sdk/typescript/tests-ts/finding-embeddings.test.ts@@ -157,16 +157,43 @@ test("does not call the provider for empty input or missing credentials", asyncexpect(observeCalls).toHaveBeenCalledTimes(0);});-test("reports provider failures without echoing response bodies or credentials", async () => {- const embedder = new OpenAiFindingEmbedder(- "synthetic-key",- async () => new Response("synthetic private body", { status: 429 }),- );- await expect(embedder.embed([example])).rejects.toMatchObject({- code: "embedding_failed",- message: "Embedding provider returned HTTP 429.",- });-});+test.each(["synthetic private body", null])(+ "preserves the HTTP error with response body %p",+ async (body) => {+ const embedder = new OpenAiFindingEmbedder(+ "synthetic-key",+ async () => new Response(body, { status: 429 }),+ );+ await expect(embedder.embed([example])).rejects.toMatchObject({+ code: "embedding_failed",+ message: "Embedding provider returned HTTP 429.",+ });+ },+);++test.each(["complete", "reject", "pending"])(+ "cancels a rejected embedding response without replacing its HTTP error (%s)",+ async (cleanup) => {+ let cancelled = false;+ const body = new ReadableStream({+ cancel() {+ cancelled = true;+ if (cleanup === "reject")+ return Promise.reject(new Error("cleanup failed"));+ if (cleanup === "pending") return new Promise<void>(() => {});+ },+ });+ const embedder = new OpenAiFindingEmbedder(+ "synthetic-key",+ async () => new Response(body, { status: 503 }),+ );+ await expect(embedder.embed([example])).rejects.toMatchObject({+ code: "embedding_failed",+ message: "Embedding provider returned HTTP 503.",+ });+ expect(cancelled).toBe(true);+ },+);test("rejects malformed vectors instead of misaligning stored findings", async () => {for (const data of [