Skip to content

OpenAI's Codex Security CLI and TypeScript SDK for finding, validating, and fixing security vulnerabilities. npm: https://www.npmjs.com/package/@openai/codex-security

fix: prevent generated finding IDs from breaking later draft updates (#1636)

ianw-oaib0773f71f8f7
diff --git a/plugins/codex-security/mcp-app/src/artifact-scan-draft.ts b/plugins/codex-security/mcp-app/src/artifact-scan-draft.ts
index 9a53c45ac..60225f6fc 100644
--- a/plugins/codex-security/mcp-app/src/artifact-scan-draft.ts
+++ b/plugins/codex-security/mcp-app/src/artifact-scan-draft.ts
@@ -2494,6 +2494,6 @@ function semanticIdentifier(value: string, fallback: string): string {
.replace(/[\u0300-\u036f]/gu, "")
.toLowerCase()
.replace(/[^a-z0-9._/-]+/gu, "-")
- .replace(/^-+|-+$/gu, "");
+ .replace(/^[^a-z0-9]+|-+$/gu, "");
return identifier || fallback;
}
diff --git a/plugins/codex-security/mcp-app/tests/test_artifact_scan_draft_recovery.ts b/plugins/codex-security/mcp-app/tests/test_artifact_scan_draft_recovery.ts
index 33a8b7097..b3cbe51ab 100644
--- a/plugins/codex-security/mcp-app/tests/test_artifact_scan_draft_recovery.ts
+++ b/plugins/codex-security/mcp-app/tests/test_artifact_scan_draft_recovery.ts
@@ -40,6 +40,41 @@ const findingFor = (candidateId: string) => ({
provenance: { source: "local_plugin", candidateId },
});
+for (const source of ["title", "candidateId", "reportId", "ledgerRowId"]) {
+ for (const [value, expected] of [
+ ["_Unsafe archive_", "unsafe-archive_"],
+ [".hidden file", "hidden-file"],
+ ["/absolute path", "absolute-path"],
+ ["./_-", "finding-1"],
+ ["安全检查", "finding-1"],
+ ["Résumé review", "resume-review"],
+ ["9valid._/anchor", "9valid._/anchor"],
+ ]) {
+ test(`standard: generated ${source} identity survives a draft update for ${value}`, async (t) => {
+ const f = await fixture(t, "standard");
+ const finding = {
+ ...findingFor("candidate-example"),
+ ...(source === "title"
+ ? { title: value }
+ : { extensions: { [source]: value } }),
+ };
+ const draft = { ...f.draft(), findings: [finding] };
+ await f.write(draft);
+ const saved = (await readJson(f.root, "findings.json")).findings[0];
+ await f.write(draft);
+ const updated = (await readJson(f.root, "findings.json")).findings;
+ assert.equal(updated.length, 1);
+ assert.deepEqual(updated[0].identity, saved.identity);
+ assert.equal(
+ saved.identity[
+ source === "title" || source === "candidateId" ? "anchor" : "instance"
+ ],
+ expected,
+ );
+ });
+ }
+}
+
test("persisted draft recovery preserves evidence while removing unsupported optional details", async (t) => {
const f = await fixture(t, "worker");
const evidence = {