OpenAI's Codex Security CLI and TypeScript SDK for finding, validating, and fixing security vulnerabilities. npm: https://www.npmjs.com/package/@openai/codex-security
TypeScript ai-securityapplication-securityclicode-scanningcodexcodex-securitycybersecuritydevsecopsnodejsnpmopenaisdksecuritytypescriptvulnerability-scanning
fix(scans): retain pre-seal warnings across publication failures (#1907)
Jayanth Yarlagaddac1db06a96737
diff --git a/plugins/codex-security/scripts/workbench_db.py b/plugins/codex-security/scripts/workbench_db.pyindex 71aaaa35b..8ad9edb5e 100644--- a/plugins/codex-security/scripts/workbench_db.py+++ b/plugins/codex-security/scripts/workbench_db.py@@ -1613,9 +1613,9 @@ def complete_scan_locked()warnings.extend(warning for warning in prepared.warnings if warning not in warnings)add_warning()- if prepared.warnings:- # Save the explanation before publication removes the broken reference,- # so a retry after failed publication retains it.+ if warnings != json.loads(scan["completion_warnings_json"]):+ # Persist all observed warnings before output writes can fail, so+ # stopped-result publication and retries retain those diagnostics.with connection:connection.execute("UPDATE scans SET completion_warnings_json = ? WHERE id = ? AND status = 'running'",diff --git a/plugins/codex-security/tests/test_deep_scan_successful_publication.py b/plugins/codex-security/tests/test_deep_scan_successful_publication.pyindex 133c56780..560596b96 100644--- a/plugins/codex-security/tests/test_deep_scan_successful_publication.py+++ b/plugins/codex-security/tests/test_deep_scan_successful_publication.py@@ -427,6 +427,67 @@ def test_completion_preserves_non_utf8_filename_warning(assert manifest_path.read_bytes() == sealed_bytes[email protected]_platform[email protected]("mode", ["standard", "deep"])[email protected]("missing_writeup", [False, True])+def test_preseal_target_warning_survives_failed_publication(+ workbench_api, workbench_db, publication_scan, monkeypatch, tmp_path, mode, missing_writeup+):+ scan = publication_scan(mode=mode)+ if missing_writeup:+ scan.findings[0]["writeup"] = {"reportPath": "findings/missing/missing.md"}+ (scan.scan_dir / "findings.json").write_text(json.dumps({"findings": scan.findings}))+ source_path = tmp_path / "target" / "subdir" / "extract.py"+ source_before = source_path.read_bytes()+ source_path.write_text("# Changed before sealing\n")+ row = workbench_db.execute("SELECT * FROM scans WHERE id = ?", (scan.scan_id,)).fetchone()+ target_warning = workbench_api["scan_target_warning"](row)+ assert target_warning is not None+ finalizer_globals = workbench_api["_write_prepared_scan_finalization"].__globals__+ write_bytes = finalizer_globals["write_scan_local_bytes"]+ failed = False++ def fail_first_report(scan_dir, relative_path, payload, **kwargs):+ nonlocal failed+ if relative_path == "report.md" and not failed:+ failed = True+ raise finalizer_globals["ContractError"]("Synthetic first report write failure")+ return write_bytes(scan_dir, relative_path, payload, **kwargs)++ with monkeypatch.context() as patch:+ patch.setitem(finalizer_globals, "write_scan_local_bytes", fail_first_report)+ with pytest.raises(SystemExit, match="Synthetic first report write failure"):+ complete(workbench_api, workbench_db, scan)++ row = workbench_db.execute("SELECT * FROM scans WHERE id = ?", (scan.scan_id,)).fetchone()+ assert row["status"] == ("failed" if mode == "standard" else "running")+ if mode == "deep":+ # The failed output write must not erase an earlier observation if the+ # next attempt finds that the target has returned to its original state.+ source_path.write_bytes(source_before)+ completed = complete(workbench_api, workbench_db, scan)+ assert completed["progress"]["status"] == "complete"+ row = workbench_db.execute("SELECT * FROM scans WHERE id = ?", (scan.scan_id,)).fetchone()+ manifest = json.loads((scan.scan_dir / "scan-manifest.json").read_text())+ assert manifest["scan"]["status"] == ("failed" if mode == "standard" else "completed")+ run = json.loads((scan.scan_dir / "exports/results.sarif").read_text())["runs"][0]+ notifications = [+ notification+ for invocation in run.get("invocations", [])+ for notification in invocation["toolExecutionNotifications"]+ ]+ assert {+ "database": target_warning in json.loads(row["completion_warnings_json"]),+ "manifest": target_warning in manifest["scan"].get("warnings", []),+ "sarif": {"level": "warning", "message": {"text": target_warning}} in notifications,+ } == {"database": True, "manifest": True, "sarif": True}+ assert run["invocations"][0]["executionSuccessful"] is (mode == "deep")+ portable = tmp_path / "portable"+ shutil.copytree(scan.scan_dir, portable)+ exported = json.loads(finalizer_globals["build_findings_export"](portable, "sarif"))+ assert exported["runs"][0] == run++@pytest.mark.cross_platform@pytest.mark.parametrize("scope", [".", "subdir"])def test_deep_completion_preserves_findings_with_missing_optional_writeups(