Skip to content

OpenAI's Codex Security CLI and TypeScript SDK for finding, validating, and fixing security vulnerabilities. npm: https://www.npmjs.com/package/@openai/codex-security

refactor(config): simplify Cyber access feature selection (#1044)

erantiananthac599a8bcdcf9
diff --git a/plugins/codex-security/mcp-app/tests/deep_scan_worker_settings_cases.ts b/plugins/codex-security/mcp-app/tests/deep_scan_worker_settings_cases.ts
index 91f836f37..724e0b0a0 100644
--- a/plugins/codex-security/mcp-app/tests/deep_scan_worker_settings_cases.ts
+++ b/plugins/codex-security/mcp-app/tests/deep_scan_worker_settings_cases.ts
@@ -87,7 +87,7 @@ export async function testWorkerCyberAccessSettings({
{
name: "explicit-false",
configuration:
- 'daybreak = false\nservice_tier = "flex"\n[codex_security]\ncyber_access_program = "daybreak_blue"\n[features]\ncli_daybreak = false\napi_key_cyber_access_programs = false\napi_key_model_discovery = false\n',
+ 'profile = "selected"\ndaybreak = false\nservice_tier = "flex"\n[codex_security]\ncyber_access_program = "daybreak_blue"\n[features]\ncli_daybreak = false\napi_key_cyber_access_programs = true\napi_key_model_discovery = false\n[profiles.selected.features]\napi_key_cyber_access_programs = false\n',
daybreak: false,
serviceTier: "flex",
program: "daybreak_blue",
diff --git a/sdk/typescript/src/config.ts b/sdk/typescript/src/config.ts
index 7870c25d8..a3c900f8c 100644
--- a/sdk/typescript/src/config.ts
+++ b/sdk/typescript/src/config.ts
@@ -246,14 +246,12 @@ export function scanCyberAccessConfig(
program: CyberAccessProgram | undefined,
): JsonObject {
if (program === undefined) return config;
- const resolved = resolveCodexProfile(config);
- const features = isObject(resolved["features"]) ? resolved["features"] : {};
+ const features = isObject(config["features"]) ? config["features"] : {};
return {
...config,
features: {
- ...(isObject(config["features"]) ? config["features"] : {}),
- // Explicit selections opt in to upstream API-key support. Keep a user's
- // explicit disable so Codex can report it instead of silently dropping it.
+ ...features,
+ // Set a root default. Normal profile resolution preserves explicit overrides.
api_key_cyber_access_programs:
features["api_key_cyber_access_programs"] ?? true,
},
diff --git a/sdk/typescript/tests-ts/api-cyber-access.test.ts b/sdk/typescript/tests-ts/api-cyber-access.test.ts
index b07b54975..193ee9cab 100644
--- a/sdk/typescript/tests-ts/api-cyber-access.test.ts
+++ b/sdk/typescript/tests-ts/api-cyber-access.test.ts
@@ -3,7 +3,11 @@ import { join } from "node:path";
import type { CodexOptions, ThreadEvent, TurnOptions } from "@openai/codex-sdk";
import { afterEach, expect, test, mock } from "bun:test";
import { parse as parseToml } from "smol-toml";
-import { resolveCodexProfile, type JsonObject } from "../src/config.js";
+import {
+ resolveCodexProfile,
+ scanCyberAccessConfig,
+ type JsonObject,
+} from "../src/config.js";
import { TestClient, mockWorkbench } from "./support/api-client.js";
import { codexFactory, preparedRuntime } from "./support/api-events.js";
import { createApiTestFixtures } from "./support/temporary-directories.js";
@@ -16,6 +20,29 @@ async function* deniedEvents(): AsyncGenerator<ThreadEvent> {
yield { type: "turn.failed", error: { message: denied } };
}
+test.each([
+ [true, false, false],
+ [false, true, true],
+ [false, null, false],
+] as const)(
+ "preserves root gate %s with profile override %s",
+ (root, selected, expected) => {
+ const gate = "api_key_cyber_access_programs";
+ const config = scanCyberAccessConfig(
+ {
+ profile: "selected",
+ features: { [gate]: root },
+ profiles: { selected: { features: { [gate]: selected } } },
+ },
+ "daybreak_blue",
+ );
+ expect(config["features"]).toEqual({ [gate]: root });
+ expect(resolveCodexProfile(config)["features"]).toEqual({
+ [gate]: expected,
+ });
+ },
+);
+
test.each([
[undefined, {}],
["standard", {}],