Skip to content

OpenAI's Codex Security CLI and TypeScript SDK for finding, validating, and fixing security vulnerabilities. npm: https://www.npmjs.com/package/@openai/codex-security

refactor(workbench): share the repository scope for external finding reads (#2221)

Michael D'Angeloc84bbb3bbf5e
diff --git a/plugins/codex-security/mcp-app/src/workbench/external-findings.ts b/plugins/codex-security/mcp-app/src/workbench/external-findings.ts
index 78dd029bb..5781296fc 100644
--- a/plugins/codex-security/mcp-app/src/workbench/external-findings.ts
+++ b/plugins/codex-security/mcp-app/src/workbench/external-findings.ts
@@ -170,18 +170,15 @@ export function listExternalFindings(
): { findings: StoredExternalFinding[] } {
requireRepository(selection?.repository);
if (selection.id !== undefined) requireText(selection.id, "id");
+ const selectByRepository =
+ "SELECT * FROM external_source_reports WHERE repository = ?";
const rows =
selection.id === undefined
? database
- .prepare(
- `SELECT * FROM external_source_reports
- WHERE repository = ? ORDER BY created_at, id`,
- )
+ .prepare(`${selectByRepository} ORDER BY created_at, id`)
.all(selection.repository)
: database
- .prepare(
- "SELECT * FROM external_source_reports WHERE repository = ? AND id = ?",
- )
+ .prepare(`${selectByRepository} AND id = ?`)
.all(selection.repository, selection.id);
return { findings: rows.map(fromRow) };
}