Skip to content

OpenAI's Codex Security CLI and TypeScript SDK for finding, validating, and fixing security vulnerabilities. npm: https://www.npmjs.com/package/@openai/codex-security

fix(plugin): include Solidity sources in scan inventories (#1021)

Arunim Shuklace7f75c1efd5
diff --git a/plugins/codex-security/scripts/rank_preview.py b/plugins/codex-security/scripts/rank_preview.py
index cf335fd58..f563bfc71 100644
--- a/plugins/codex-security/scripts/rank_preview.py
+++ b/plugins/codex-security/scripts/rank_preview.py
@@ -56,6 +56,7 @@ TEXT_CODE_EXTENSIONS = {
".rs",
".scala",
".sh",
+ ".sol",
".sql",
".swift",
".tf",
diff --git a/plugins/codex-security/tests/test_generate_in_scope_files.py b/plugins/codex-security/tests/test_generate_in_scope_files.py
index 4e05cdf95..b59249fe8 100644
--- a/plugins/codex-security/tests/test_generate_in_scope_files.py
+++ b/plugins/codex-security/tests/test_generate_in_scope_files.py
@@ -460,6 +460,29 @@ def test_diff_inventory_includes_changed_objective_c(tmp_path: Path, mode: str)
assert output.read_text(encoding="utf-8").splitlines() == sorted(sources)
[email protected]("mode", ["revisions", "local-patch"])
+def test_diff_inventory_includes_changed_solidity(tmp_path: Path, mode: str) -> None:
+ repository = make_repository(tmp_path)
+ source = b"pragma solidity ^0.8.24;\ncontract Vault {}\n"
+ write_file(repository, "contracts/Vault.sol", source)
+ git(repository, "add", ".")
+ git(repository, "commit", "-qm", "base")
+ base = git(repository, "rev-parse", "HEAD")
+ write_file(repository, "contracts/Vault.sol", source + b"// Changed.\n")
+ arguments = ["--diff-base", base, "--diff-mode", mode]
+ if mode == "revisions":
+ git(repository, "add", ".")
+ git(repository, "commit", "-qm", "change")
+ arguments.extend(["--diff-head", git(repository, "rev-parse", "HEAD")])
+ git(repository, "checkout", "-q", base)
+ output = tmp_path / "in_scope_files.txt"
+
+ result = run_inventory(repository, ".", output, arguments=arguments)
+
+ assert result.returncode == 0, result.stderr
+ assert output.read_text(encoding="utf-8") == "contracts/Vault.sol\n"
+
+
def test_diff_inventory_keeps_every_javascript_module_extension(tmp_path: Path) -> None:
repository = make_repository(tmp_path)
git(repository, "add", ".")
diff --git a/plugins/codex-security/tests/test_generate_rank_input.py b/plugins/codex-security/tests/test_generate_rank_input.py
index 23acdb855..e405de49b 100644
--- a/plugins/codex-security/tests/test_generate_rank_input.py
+++ b/plugins/codex-security/tests/test_generate_rank_input.py
@@ -295,6 +295,42 @@ def test_rank_input_includes_objective_c(tmp_path: Path, mode: str) -> None:
]
[email protected]("mode", ["repo", "revisions", "local-patch"])
+def test_rank_input_includes_solidity(tmp_path: Path, mode: str) -> None:
+ repo = tmp_path / "repo"
+ contracts = repo / "contracts"
+ contracts.mkdir(parents=True)
+ initialize_repo(repo)
+ source = contracts / "Vault.sol"
+ source.write_text("uint256 public limit = 1;\n", encoding="utf-8")
+ git(repo, "add", ".")
+ git(repo, "commit", "-qm", "base")
+ base = git(repo, "rev-parse", "HEAD")
+ changed = "uint256 public limit = 2;"
+ source.write_text(changed + "\n", encoding="utf-8")
+ output = tmp_path / "rank_input.jsonl"
+
+ if mode == "repo":
+ arguments = ["make-repo-rank-input", "--repo", str(repo), "--scope", "contracts"]
+ else:
+ arguments = ["make-diff-rank-input", "--repo", str(repo), "--base", base, "--mode", mode]
+ if mode == "revisions":
+ git(repo, "add", ".")
+ git(repo, "commit", "-qm", "change")
+ arguments.extend(["--head", git(repo, "rev-parse", "HEAD")])
+ git(repo, "checkout", "-q", base)
+
+ run_cli(*arguments, "--out", str(output))
+
+ assert read_jsonl(output) == [
+ {
+ "path": "contracts/Vault.sol",
+ "area": "contracts" if mode == "repo" else "diff",
+ "preview": changed,
+ }
+ ]
+
+
def test_make_repo_rank_input_rejects_scope_outside_repo(tmp_path: Path) -> None:
repo = tmp_path / "repo"
repo.mkdir()
diff --git a/plugins/codex-security/tests/test_rank_preview.py b/plugins/codex-security/tests/test_rank_preview.py
index 5ed6c16f1..368e1a33a 100644
--- a/plugins/codex-security/tests/test_rank_preview.py
+++ b/plugins/codex-security/tests/test_rank_preview.py
@@ -583,7 +583,7 @@ def test_fallback_preview_omits_marker_when_no_lines_are_skipped(tmp_path: Path)
assert "..." not in preview
[email protected]("filename", ["styles.css", "main.tf", "ViewController.m"])
[email protected]("filename", ["styles.css", "main.tf", "ViewController.m", "Vault.sol"])
def test_preview_byte_budget_preserves_sampled_tail_and_valid_unicode(
tmp_path: Path, filename: str
) -> None: