Skip to content

OpenAI's Codex Security CLI and TypeScript SDK for finding, validating, and fixing security vulnerabilities. npm: https://www.npmjs.com/package/@openai/codex-security

fix(sdk): inventory policies in list-only POSIX directories (#2572)

Michael D'Angelocf2aafaa92d1
diff --git a/sdk/typescript/src/security-policy.ts b/sdk/typescript/src/security-policy.ts
index 6efd3445a..824221571 100644
--- a/sdk/typescript/src/security-policy.ts
+++ b/sdk/typescript/src/security-policy.ts
@@ -482,7 +482,25 @@ async function securityPolicyPaths(
const directory = directories.pop()!;
if (isGitData(directory)) continue;
const entries = await readdir(directory, { withFileTypes: true });
- if (await isGitMetadataDirectory(directory, signal)) {
+ let gitMetadata: boolean;
+ try {
+ gitMetadata = await isGitMetadataDirectory(directory, signal);
+ } catch (error) {
+ // POSIX can permit listing a directory but deny lookups of its children.
+ // A leaf containing only unrelated regular files needs no further lookups.
+ if (
+ process.platform !== "win32" &&
+ (error as NodeJS.ErrnoException).code === "EACCES" &&
+ entries.every(
+ (entry) =>
+ entry.isFile() &&
+ !/^(?:\.git|HEAD|SECURITY\.md)$/iu.test(entry.name),
+ )
+ )
+ continue;
+ throw error;
+ }
+ if (gitMetadata) {
gitDirectories.add(directory);
const common = await readFile(join(directory, "commondir"), "utf8").catch(
nullIfMissingFile,
diff --git a/sdk/typescript/tests-ts/security-policy.test.ts b/sdk/typescript/tests-ts/security-policy.test.ts
index bc50095e1..2af6bd6fa 100644
--- a/sdk/typescript/tests-ts/security-policy.test.ts
+++ b/sdk/typescript/tests-ts/security-policy.test.ts
@@ -1,6 +1,7 @@
import { nodeCommand, gitText } from "./support/shell.js";
import { execFileSync } from "node:child_process";
import {
+ chmod,
cp,
mkdir,
readFile,
@@ -398,6 +399,35 @@ describe("security policy generation", () => {
expect(inventory.gitMetadataPaths).toEqual([]);
});
+ test.skipIf(process.platform === "win32" || process.getuid?.() === 0)(
+ "inventories policies when an unrelated leaf directory only permits listing",
+ async () => {
+ const f = await fixture();
+ policyGit(f.repository, "init", "--quiet");
+ const leaf = join(f.repository, "data");
+ await mkdir(leaf);
+ await writeFile(join(leaf, "sample.txt"), "fixture\n");
+ await writeFile(join(f.repository, "SECURITY.md"), POLICY);
+ const target = await resolveSecurityPolicyTarget(f.repository);
+ try {
+ await chmod(leaf, 0o400);
+ expect(
+ (await inspectSecurityPolicySources(target)).policyPaths,
+ ).toEqual(["SECURITY.md"]);
+ await chmod(leaf, 0o700);
+ await writeFile(join(leaf, "SECURITY.md"), POLICY);
+ await chmod(leaf, 0o400);
+ await expect(
+ inspectSecurityPolicySources(target),
+ ).rejects.toMatchObject({
+ code: "EACCES",
+ });
+ } finally {
+ await chmod(leaf, 0o700);
+ }
+ },
+ );
+
test("leaves Git-ignored dependencies out of the policy inventory", async () => {
const f = await fixture();
policyGit(f.repository, "init", "--quiet");