Skip to content

OpenAI's Codex Security CLI and TypeScript SDK for finding, validating, and fixing security vulnerabilities. npm: https://www.npmjs.com/package/@openai/codex-security

fix(plugin): normalize missing artifact errors on Windows (#2368)

Michael D'Angelod110c790d531
diff --git a/plugins/codex-security/scripts/finalize_scan_contract.py b/plugins/codex-security/scripts/finalize_scan_contract.py
index 37633caa4..aac671ad2 100644
--- a/plugins/codex-security/scripts/finalize_scan_contract.py
+++ b/plugins/codex-security/scripts/finalize_scan_contract.py
@@ -628,7 +628,9 @@ def _open_scan_local_file_with_path(
except OSError as exc:
# The Windows backend retains native ERROR_FILE/PATH_NOT_FOUND codes.
if exc.errno in {2, 3}:
- raise MissingScanLocalFileError(str(exc)) from exc
+ raise MissingScanLocalFileError(
+ f"{context}: expected a file inside the scan directory"
+ ) from exc
raise ContractError(str(exc)) from exc
root_fd: int | None = None
parent_fd: int | None = None
diff --git a/plugins/codex-security/tests/test_windows_scan_local_files.py b/plugins/codex-security/tests/test_windows_scan_local_files.py
index 5a10b3c1d..020601e22 100644
--- a/plugins/codex-security/tests/test_windows_scan_local_files.py
+++ b/plugins/codex-security/tests/test_windows_scan_local_files.py
@@ -51,6 +51,18 @@ def test_accepts_normal_scan_local_path() -> None:
)
[email protected]("relative_path", ["missing.bin", "missing/artifact.bin"])
+def test_missing_scan_local_file_reports_a_portable_error(
+ tmp_path: Path, relative_path: str
+) -> None:
+ finalizer = load_script("finalize_scan_contract")
+
+ with pytest.raises(finalizer.MissingScanLocalFileError) as error:
+ finalizer.open_scan_local_file_descriptor(tmp_path, relative_path, "Saved artifact")
+
+ assert str(error.value) == "Saved artifact: expected a file inside the scan directory"
+
+
@pytest.mark.skipif(os.name != "nt", reason="requires native Win32 security APIs")
def test_directory_acl_copy_does_not_create_from_a_missing_source(tmp_path: Path) -> None:
destination = tmp_path / "replacement"