Skip to content

OpenAI's Codex Security CLI and TypeScript SDK for finding, validating, and fixing security vulnerabilities. npm: https://www.npmjs.com/package/@openai/codex-security

fix(deep-scan): reject unpublishable worker report metadata (#2319)

Michael D'Angelod78a9203e38f
diff --git a/plugins/codex-security/mcp-app/src/artifact-scan-draft.ts b/plugins/codex-security/mcp-app/src/artifact-scan-draft.ts
index 0145b72be..7c4b8717d 100644
--- a/plugins/codex-security/mcp-app/src/artifact-scan-draft.ts
+++ b/plugins/codex-security/mcp-app/src/artifact-scan-draft.ts
@@ -2,6 +2,7 @@ import type { JsonObject } from "./types.js";
import {
coverageReceiptComponents,
validateRetainedCoverage,
+ validateWorkerReport,
} from "./coverage-publication.js";
import { isRecord as isObject } from "./record.js";
import { createHash, randomUUID } from "node:crypto";
@@ -696,6 +697,7 @@ async function preserveScanDraft(
warnings?: string[];
}> {
requireFiniteNumbers(input);
+ if (context.layout === "worker") validateWorkerReport(input);
const warnings: string[] = [];
const currentCheckpointName = scanDraftCheckpointName(input);
const requiresClosureValidation =
diff --git a/plugins/codex-security/mcp-app/src/coverage-publication.ts b/plugins/codex-security/mcp-app/src/coverage-publication.ts
index 0a6b22136..388ea4b77 100644
--- a/plugins/codex-security/mcp-app/src/coverage-publication.ts
+++ b/plugins/codex-security/mcp-app/src/coverage-publication.ts
@@ -62,6 +62,11 @@ export function coverageReceiptComponents(value: string): string[] {
}
}
+export function validateWorkerReport(report: JsonObject): void {
+ for (const field of ["findings", "scope", "threatModel"] as const)
+ requirePublicationJson(report[field], field);
+}
+
export function validateRetainedCoverage(coverage: JsonObject): void {
for (const field of [
"surfaces",
diff --git a/plugins/codex-security/mcp-app/src/deep-scan/artifact-validation.ts b/plugins/codex-security/mcp-app/src/deep-scan/artifact-validation.ts
index 97f6d8889..43bc5e437 100644
--- a/plugins/codex-security/mcp-app/src/deep-scan/artifact-validation.ts
+++ b/plugins/codex-security/mcp-app/src/deep-scan/artifact-validation.ts
@@ -3,7 +3,10 @@ import { dirname, join, posix, relative, sep } from "node:path";
import { asRecord } from "../record.js";
import type { JsonObject } from "../types.js";
import { artifactSourcePath, type ArtifactContext } from "../artifact-io.js";
-import { validateRetainedCoverage } from "../coverage-publication.js";
+import {
+ validateRetainedCoverage,
+ validateWorkerReport,
+} from "../coverage-publication.js";
import {
parsePersistedScanDraft,
scanDraftInputSchema,
@@ -62,6 +65,7 @@ export async function validateDiscoveryArtifacts(
ArtifactContext,
"scope" | "includePaths" | "filePaths"
> = {},
+ admission: "new" | "previously-accepted" = "new",
): Promise<ScanDraftInput> {
await requireRegularFile(resultPath, artifacts.workersRoot);
const root = dirname(resultPath);
@@ -86,6 +90,8 @@ export async function validateDiscoveryArtifacts(
throw new Error(
"Standard scan worker wrote only a checkpoint; its audit is not complete.",
);
+ // Preserve the existing publication of previously accepted historical payloads.
+ if (admission === "new") validateWorkerReport(result);
validateRetainedCoverage(result.reviewState);
// Check the worker's own task IDs before qualifying active and closed tasks.
const closures = result.reviewState.resolvedDeferred ?? [];
diff --git a/plugins/codex-security/mcp-app/src/deep-scan/coordinator.ts b/plugins/codex-security/mcp-app/src/deep-scan/coordinator.ts
index 29001f96d..32a92af2e 100644
--- a/plugins/codex-security/mcp-app/src/deep-scan/coordinator.ts
+++ b/plugins/codex-security/mcp-app/src/deep-scan/coordinator.ts
@@ -1021,6 +1021,7 @@ export class DeepScanCoordinator {
worker.resultManifestPath,
this.state.scanId,
this.state,
+ "previously-accepted",
);
recovered.push({
id: worker.id,
diff --git a/plugins/codex-security/mcp-app/tests/test_scan_draft_finite_writes.ts b/plugins/codex-security/mcp-app/tests/test_scan_draft_finite_writes.ts
index 8d119c522..0e1b8df3b 100644
--- a/plugins/codex-security/mcp-app/tests/test_scan_draft_finite_writes.ts
+++ b/plugins/codex-security/mcp-app/tests/test_scan_draft_finite_writes.ts
@@ -194,12 +194,20 @@ test("Deep retains historical threat-model reader behavior", async (t) => {
test("worker recovers finite nested values after an interrupted result write", async (t) => {
const f = await fixture(t, "worker");
- let nested: unknown = 1.25e300;
+ let nested: unknown = 1.25e-300;
for (let depth = 0; depth < 300; depth++) nested = [nested];
const kept = {
...finding("finite", "api/source.py"),
extensions: {
- values: [null, true, false, 0, -1.25e300, "Infinity", "λ 🧪"],
+ values: [
+ null,
+ true,
+ false,
+ 0,
+ Number.MIN_SAFE_INTEGER,
+ "Infinity",
+ "λ 🧪",
+ ],
nested,
},
};
diff --git a/plugins/codex-security/mcp-app/tests/test_worker_report_publication.ts b/plugins/codex-security/mcp-app/tests/test_worker_report_publication.ts
new file mode 100644
index 000000000..e36ec5bc1
--- /dev/null
+++ b/plugins/codex-security/mcp-app/tests/test_worker_report_publication.ts
@@ -0,0 +1,48 @@
+import assert from "node:assert/strict";
+import { mkdir, readdir, writeFile } from "node:fs/promises";
+import { join } from "node:path";
+import { test } from "node:test";
+import { importSource } from "./import-module.ts";
+import { fixture } from "./scan-draft-recovery-fixture.ts";
+import { finding } from "./scan-draft-fixture.ts";
+
+const { validateDiscoveryArtifacts } = await importSource(
+ "src/deep-scan/artifact-validation.ts",
+);
+
+for (const [field, extra, error] of [
+ [
+ "findings",
+ {
+ findings: [
+ { ...finding("api", "api/source.py"), title: "invalid \ud800 text" },
+ ],
+ },
+ /well-formed Unicode/,
+ ],
+ [
+ "scope",
+ { scope: { metrics: { count: Number.MAX_SAFE_INTEGER + 1 } } },
+ /unsafe integer/,
+ ],
+ [
+ "threatModel",
+ { threatModel: { summary: "Model", metadata: { "\udc00": true } } },
+ /well-formed Unicode/,
+ ],
+] as const) {
+ test(`worker tool and direct result both reject unpublishable ${field} metadata`, async (t) => {
+ const f = await fixture(t, "worker");
+ const draft = { ...f.draft({}, true), ...extra };
+ await assert.rejects(f.write(draft), error);
+ assert.deepEqual(await readdir(f.root), []);
+ const output = join(f.root, "first", "output");
+ await mkdir(output, { recursive: true });
+ const path = join(output, "result.json");
+ await writeFile(path, JSON.stringify(draft));
+ await assert.rejects(
+ validateDiscoveryArtifacts({ workersRoot: f.root }, path, draft.scanId),
+ error,
+ );
+ });
+}