Skip to content

OpenAI's Codex Security CLI and TypeScript SDK for finding, validating, and fixing security vulnerabilities. npm: https://www.npmjs.com/package/@openai/codex-security

fix(contract): reject control characters in remote targets during finalization (#1523)

Rabari Mihire11136296c81
diff --git a/plugins/codex-security/scripts/finalize_scan_contract.py b/plugins/codex-security/scripts/finalize_scan_contract.py
index dae0798e5..37a853765 100644
--- a/plugins/codex-security/scripts/finalize_scan_contract.py
+++ b/plugins/codex-security/scripts/finalize_scan_contract.py
@@ -61,6 +61,7 @@ SLUG_RE = re.compile(r"^[a-z0-9][a-z0-9._/-]*$")
RFC3339_RE = re.compile(
r"^\d{4}-\d{2}-\d{2}[Tt]\d{2}:\d{2}:\d{2}(?:\.\d+)?(?:[Zz]|[+-]\d{2}:\d{2})$"
)
+REMOTE_CONTROL_RE = re.compile(r"[\x00-\x1f\x7f-\x9f\u2028\u2029]")
GITHUB_HASH_BLOCK_SIZE = 100
GITHUB_HASH_MOD = 37
GITHUB_HASH_MASK = (1 << 64) - 1
@@ -889,6 +890,8 @@ def _write_scan_local_json(scan_dir: Path, relative_path: str, payload: Any) ->
def _validate_remote(remote: str, context: str) -> None:
+ if REMOTE_CONTROL_RE.search(remote):
+ raise ContractError(f"{context}: expected a sanitized canonical absolute URL")
parsed = urlsplit(remote)
if "\\" in remote or not parsed.scheme or not parsed.netloc:
raise ContractError(f"{context}: expected a sanitized canonical absolute URL")
diff --git a/plugins/codex-security/tests/test_finalize_scan_contract.py b/plugins/codex-security/tests/test_finalize_scan_contract.py
index 44289ec70..03a2e5416 100644
--- a/plugins/codex-security/tests/test_finalize_scan_contract.py
+++ b/plugins/codex-security/tests/test_finalize_scan_contract.py
@@ -2335,6 +2335,16 @@ The extraction root is not enforced.
with self.assertRaisesRegex(FINALIZER.ContractError, "must not contain credentials"):
FINALIZER.finalize_scan(self.scan_dir)
+ def test_rejects_remote_control_characters(self) -> None:
+ for character in ("\0", "\t", "\n", "\r", "\x7f", "\x85", "\u2028", "\u2029"):
+ with self.subTest(character=repr(character)):
+ self.manifest["scan"]["target"]["remote"] = f"https://example.com{character}/repo"
+ self.write_scan()
+ with self.assertRaisesRegex(
+ FINALIZER.ContractError, "expected a sanitized canonical absolute URL"
+ ):
+ FINALIZER.finalize_scan(self.scan_dir)
+
def test_rejects_repository_root_finding_location(self) -> None:
self.findings["findings"][0]["locations"][0]["path"] = "."
self.write_scan()