Skip to content

OpenAI's Codex Security CLI and TypeScript SDK for finding, validating, and fixing security vulnerabilities. npm: https://www.npmjs.com/package/@openai/codex-security

test(scan): exercise large git output on Windows (#614)

mldangelo-oaie35c5fe3e766
diff --git a/sdk/typescript/src/targets.ts b/sdk/typescript/src/targets.ts
index 975e43e5f..032cf9317 100644
--- a/sdk/typescript/src/targets.ts
+++ b/sdk/typescript/src/targets.ts
@@ -434,6 +434,7 @@ async function gitOutput(
encoding: "utf8",
signal,
env: command.environment,
+ maxBuffer: Infinity,
},
);
return stdout.replace(process.platform === "win32" ? /\r?\n$/u : /\n$/u, "");
diff --git a/sdk/typescript/tests-ts/targets-large-output.test.ts b/sdk/typescript/tests-ts/targets-large-output.test.ts
new file mode 100644
index 000000000..859ead0d5
--- /dev/null
+++ b/sdk/typescript/tests-ts/targets-large-output.test.ts
@@ -0,0 +1,68 @@
+import { execFileSync } from "node:child_process";
+import { mkdtemp, mkdir, realpath, rm, writeFile } from "node:fs/promises";
+import { tmpdir } from "node:os";
+import { join } from "node:path";
+import { afterEach, expect, test } from "bun:test";
+import {
+ DiffTarget,
+ normalizeTarget,
+ validateCommittedDiffCheckout,
+} from "../src/targets.js";
+
+const temporaryDirectories: string[] = [];
+
+afterEach(async () => {
+ await Promise.all(
+ temporaryDirectories
+ .splice(0)
+ .map((path) => rm(path, { recursive: true, force: true })),
+ );
+});
+
+function git(repo: string, ...args: string[]): string {
+ return execFileSync("git", args, {
+ cwd: repo,
+ encoding: "utf8",
+ maxBuffer: Infinity,
+ }).trim();
+}
+
+test("validates committed diffs with tracked-file output larger than 1 MB", async () => {
+ const root = await realpath(
+ await mkdtemp(join(tmpdir(), "codex-security-large-targets-")),
+ );
+ temporaryDirectories.push(root);
+ const repo = join(root, "repo");
+ await mkdir(repo);
+
+ git(repo, "init", "-b", "main");
+ git(repo, "config", "user.email", "[email protected]");
+ git(repo, "config", "user.name", "Test");
+
+ const trackedDirectory = join(repo, "tracked");
+ await mkdir(trackedDirectory);
+ // Exceed the byte limit without creating paths that are too long on Windows.
+ const utf8Stem = "界".repeat(60);
+ await Promise.all(
+ Array.from({ length: 6_000 }, (_, index) =>
+ writeFile(
+ join(
+ trackedDirectory,
+ `${index.toString().padStart(4, "0")}-${utf8Stem}.ts`,
+ ),
+ "",
+ ),
+ ),
+ );
+
+ git(repo, "add", ".");
+ git(repo, "commit", "--quiet", "-m", "large tracked tree");
+
+ const tracked = git(repo, "ls-files", "-t", "-z");
+ expect(Buffer.byteLength(tracked, "utf8")).toBeGreaterThan(1024 * 1024);
+
+ const target = await normalizeTarget(repo, DiffTarget.refs({ base: "HEAD" }));
+ await expect(
+ validateCommittedDiffCheckout(repo, target),
+ ).resolves.toBeUndefined();
+});