Skip to content

OpenAI's Codex Security CLI and TypeScript SDK for finding, validating, and fixing security vulnerabilities. npm: https://www.npmjs.com/package/@openai/codex-security

fix(scan): include CommonJS and TypeScript module extensions in scan inventories (#859)

kevinfa5fe21cd39e
diff --git a/plugins/codex-security/scripts/rank_preview.py b/plugins/codex-security/scripts/rank_preview.py
index f4cb4cf1f..a5f48e798 100644
--- a/plugins/codex-security/scripts/rank_preview.py
+++ b/plugins/codex-security/scripts/rank_preview.py
@@ -17,10 +17,12 @@ TEXT_CODE_EXTENSIONS = {
".c",
".cc",
".cfg",
+ ".cjs",
".clj",
".cpp",
".cs",
".css",
+ ".cts",
".cue",
".cxx",
".dart",
@@ -41,6 +43,7 @@ TEXT_CODE_EXTENSIONS = {
".lua",
".mjs",
".mm",
+ ".mts",
".php",
".proto",
".ps1",
@@ -62,7 +65,7 @@ TEXT_CODE_EXTENSIONS = {
".yml",
}
-JAVASCRIPT_EXTENSIONS = {".js", ".jsx", ".mjs", ".ts", ".tsx", ".vue"}
+JAVASCRIPT_EXTENSIONS = {".cjs", ".cts", ".js", ".jsx", ".mjs", ".mts", ".ts", ".tsx", ".vue"}
JAVA_LIKE_EXTENSIONS = {".c", ".cc", ".cpp", ".cs", ".cxx", ".h", ".hpp", ".java", ".mm"}
BRACE_LANGUAGE_EXTENSIONS = {
*JAVASCRIPT_EXTENSIONS,
diff --git a/plugins/codex-security/tests/test_generate_in_scope_files.py b/plugins/codex-security/tests/test_generate_in_scope_files.py
index b35055963..c42fc82a4 100644
--- a/plugins/codex-security/tests/test_generate_in_scope_files.py
+++ b/plugins/codex-security/tests/test_generate_in_scope_files.py
@@ -380,6 +380,44 @@ def test_diff_inventory_keeps_changed_and_deleted_source_files(tmp_path: Path) -
]
+def test_diff_inventory_keeps_every_javascript_module_extension(tmp_path: Path) -> None:
+ repository = make_repository(tmp_path)
+ git(repository, "add", ".")
+ git(repository, "commit", "-qm", "base")
+ base = git(repository, "rev-parse", "HEAD")
+
+ for name in (
+ "app/loader.cjs",
+ "app/loader.mjs",
+ "app/loader.js",
+ "app/types.cts",
+ "app/types.mts",
+ "app/types.ts",
+ ):
+ write_file(repository, name, b"export const handler = 1;\n")
+ git(repository, "add", ".")
+ git(repository, "commit", "-qm", "change")
+ head = git(repository, "rev-parse", "HEAD")
+ output = tmp_path / "in_scope_files.txt"
+
+ result = run_inventory(
+ repository,
+ ".",
+ output,
+ arguments=["--diff-base", base, "--diff-head", head],
+ )
+
+ assert result.returncode == 0, result.stderr
+ assert output.read_text(encoding="utf-8").splitlines() == [
+ "app/loader.cjs",
+ "app/loader.js",
+ "app/loader.mjs",
+ "app/types.cts",
+ "app/types.mts",
+ "app/types.ts",
+ ]
+
+
def test_diff_inventory_combines_staged_and_unstaged_changes(tmp_path: Path) -> None:
repository = make_repository(tmp_path)
git(repository, "add", ".")