Skip to content

OpenAI's Codex Security CLI and TypeScript SDK for finding, validating, and fixing security vulnerabilities. npm: https://www.npmjs.com/package/@openai/codex-security

test(sdk): avoid racing sticky directory cleanup (#2519)

Michael D'Angelofae52a9dbc1f
diff --git a/sdk/typescript/tests-ts/runtime.test.ts b/sdk/typescript/tests-ts/runtime.test.ts
index 02d5b409f..b3d8bedda 100644
--- a/sdk/typescript/tests-ts/runtime.test.ts
+++ b/sdk/typescript/tests-ts/runtime.test.ts
@@ -3333,7 +3333,8 @@ describe("runtime directories and plugin Python boundary", () => {
const root = await temporaryDirectory();
// Some filesystems (notably user dirs on macOS APFS) ignore sticky on
// chmod; fall back to the process temp root when it is already sticky.
- let stickyParent = join(root, "shared");
+ const shared = join(root, "shared");
+ let stickyParent = shared;
await mkdir(stickyParent, { mode: 0o1777 });
await chmod(stickyParent, 0o1777);
if (((await lstat(stickyParent)).mode & 0o1000) === 0) {
@@ -3346,7 +3347,7 @@ describe("runtime directories and plugin Python boundary", () => {
stickyParent,
`codex-security-sticky-${process.pid}-${Date.now()}`,
);
- temporaryDirectories.track(stateDirectory);
+ if (stickyParent !== shared) temporaryDirectories.track(stateDirectory);
await mkdir(stateDirectory, { recursive: true, mode: 0o700 });
const home = await prepareCodexSecurityCredentialHome({
CODEX_SECURITY_STATE_DIR: stateDirectory,
@@ -6368,7 +6369,7 @@ describe("runtime directories and plugin Python boundary", () => {
stickyParent,
`codex-security-sticky-${process.pid}-${Date.now()}`,
);
- temporaryDirectories.track(output);
+ if (stickyParent !== shared) temporaryDirectories.track(output);
await expect(
requireSecureOutputAncestry(output),