Skip to content

armgit / codex

Public Imported from GitHub
0

Lightweight coding agent that runs in your terminal

Rust
148 KB
Raw Blame
use crate::config::ConfigBuilder;
use crate::config::ConfigOverrides;
use crate::config::ConstraintError;
use crate::config::PermissionProfileCatalogEntry;
use crate::config::permission_profile_catalog;
use codex_config::CONFIG_TOML_FILE;
use codex_config::CloudConfigBundleLoadError;
use codex_config::CloudConfigBundleLoader;
use codex_config::ConfigError;
use codex_config::ConfigLayerEntry;
use codex_config::ConfigLayerSource;
use codex_config::ConfigLoadError;
use codex_config::ConfigLoadOptions;
use codex_config::ConfigPathContext;
use codex_config::ConfigRequirements;
use codex_config::ConfigRequirementsToml;
use codex_config::ConfigRequirementsWithSources;
use codex_config::FilesystemDenyReadPattern;
use codex_config::LoaderOverrides;
use codex_config::RequirementSource;
use codex_config::RequirementsLayerEntry;
use codex_config::SessionThreadConfig;
use codex_config::StaticThreadConfigLoader;
use codex_config::ThreadConfigSource;
use codex_config::compose_requirements;
use codex_config::config_error_from_ignored_toml_fields;
use codex_config::config_error_from_toml;
use codex_config::config_error_from_typed_toml;
use codex_config::config_toml::ConfigToml;
use codex_config::config_toml::ProjectConfig;
use codex_config::loader::load_config_layers_state;
use codex_config::loader::load_requirements_toml;
use codex_config::permissions_toml::PermissionProfileToml;
use codex_config::test_support::CloudConfigBundleFixture;
use codex_exec_server::LOCAL_FS;
use codex_features::Feature;
use codex_protocol::config_types::EnvironmentVariablePattern;
use codex_protocol::config_types::TrustLevel;
use codex_protocol::config_types::WebSearchMode;
use codex_protocol::models::ActivePermissionProfile;
use codex_protocol::models::BUILT_IN_PERMISSION_PROFILE_DANGER_FULL_ACCESS;
use codex_protocol::models::BUILT_IN_PERMISSION_PROFILE_WORKSPACE;
use codex_protocol::models::ManagedFileSystemPermissions;
use codex_protocol::models::PermissionProfile;
use codex_protocol::permissions::NetworkSandboxPolicy;
use codex_protocol::protocol::AskForApproval;
use codex_utils_absolute_path::AbsolutePathBuf;
use codex_utils_path_uri::PathConvention;
use codex_utils_path_uri::PathUri;
use codex_utils_path_uri::Platform;
use pretty_assertions::assert_eq;
use std::collections::BTreeMap;
use std::collections::HashMap;
use std::path::Path;
use tempfile::tempdir;
use toml::Value as TomlValue;

fn config_error_from_io(err: &std::io::Error) -> &ConfigError {
    err.get_ref()
        .and_then(|err| err.downcast_ref::<ConfigLoadError>())
        .map(ConfigLoadError::config_error)
        .expect("expected ConfigLoadError")
}

fn cloud_config_bundle_requirement_source() -> RequirementSource {
    RequirementSource::EnterpriseManaged {
        id: "req_1".to_string(),
        name: "Base requirements".to_string(),
    }
}

async fn load_single_requirements_toml(
    requirements_file: &AbsolutePathBuf,
) -> anyhow::Result<ConfigRequirementsWithSources> {
    let layer = load_requirements_toml(LOCAL_FS.as_ref(), requirements_file)
        .await?
        .expect("requirements.toml should load");
    Ok(compose_requirements(vec![layer])?.expect("requirements should be present"))
}

async fn make_config_for_test(
    codex_home: &Path,
    project_path: &Path,
    trust_level: TrustLevel,
    project_root_markers: Option<Vec<String>>,
) -> std::io::Result<()> {
    tokio::fs::write(
        codex_home.join(CONFIG_TOML_FILE),
        toml::to_string(&ConfigToml {
            projects: Some(HashMap::from([(
                project_path.to_string_lossy().to_string(),
                ProjectConfig {
                    trust_level: Some(trust_level),
                },
            )])),
            project_root_markers,
            ..Default::default()
        })
        .expect("serialize config"),
    )
    .await
}

async fn write_linked_worktree_pointer(
    repo_root: &Path,
    worktree_root: &Path,
) -> std::io::Result<()> {
    let worktree_git_dir = repo_root.join(".git/worktrees/feature-x");
    tokio::fs::create_dir_all(&worktree_git_dir).await?;
    tokio::fs::write(
        worktree_root.join(".git"),
        format!("gitdir: {}\n", worktree_git_dir.display()),
    )
    .await?;
    tokio::fs::write(
        worktree_git_dir.join("gitdir"),
        format!("{}\n", worktree_root.join(".git").display()),
    )
    .await?;
    tokio::fs::write(worktree_git_dir.join("commondir"), "../..\n").await
}

async fn write_project_hook_config(
    dot_codex_folder: &Path,
    foo: Option<&str>,
    command: &str,
) -> std::io::Result<()> {
    tokio::fs::create_dir_all(dot_codex_folder).await?;
    let foo = foo
        .map(|value| format!("foo = \"{value}\"\n\n"))
        .unwrap_or_default();
    tokio::fs::write(
        dot_codex_folder.join(CONFIG_TOML_FILE),
        format!(
            r#"{foo}[hooks]

[[hooks.PreToolUse]]
matcher = "Bash"

[[hooks.PreToolUse.hooks]]
type = "command"
command = "{command}"
"#
        ),
    )
    .await
}

#[tokio::test]
async fn cli_overrides_resolve_relative_paths_against_cwd() -> std::io::Result<()> {
    let codex_home = tempdir().expect("tempdir");
    let cwd_dir = tempdir().expect("tempdir");
    let cwd_path = cwd_dir.path().to_path_buf();

    let config = ConfigBuilder::default()
        .codex_home(codex_home.path().to_path_buf())
        .cli_overrides(vec![(
            "log_dir".to_string(),
            TomlValue::String("run-logs".to_string()),
        )])
        .harness_overrides(ConfigOverrides {
            cwd: Some(cwd_path.clone()),
            ..Default::default()
        })
        .build()
        .await?;

    let expected = AbsolutePathBuf::resolve_path_against_base("run-logs", cwd_path);
    assert_eq!(config.log_dir, expected.to_path_buf());
    Ok(())
}

#[tokio::test]
async fn returns_config_error_for_invalid_user_config_toml() {
    let tmp = tempdir().expect("tempdir");
    let contents = r#"model = "gpt-4"
invalid = ["#;
    let config_path = tmp.path().join(CONFIG_TOML_FILE);
    std::fs::write(&config_path, contents).expect("write config");

    let cwd = AbsolutePathBuf::try_from(tmp.path()).expect("cwd");
    let err = load_config_layers_state(
        LOCAL_FS.as_ref(),
        tmp.path(),
        Some(cwd),
        &[] as &[(String, TomlValue)],
        LoaderOverrides::default(),
        &codex_config::NoopThreadConfigLoader,
    )
    .await
    .expect_err("expected error");

    let config_error = config_error_from_io(&err);
    let expected_toml_error = toml::from_str::<TomlValue>(contents).expect_err("parse error");
    let expected_config_error = config_error_from_toml(&config_path, contents, expected_toml_error);
    assert_eq!(config_error, &expected_config_error);
}

#[tokio::test]
async fn ignore_user_config_keeps_empty_user_layer() -> std::io::Result<()> {
    let tmp = tempdir().expect("tempdir");
    std::fs::write(
        tmp.path().join(CONFIG_TOML_FILE),
        r#"model = "from-user-config"
invalid = ["#,
    )
    .expect("write config");

    let cwd = AbsolutePathBuf::try_from(tmp.path()).expect("cwd");
    let layers = load_config_layers_state(
        LOCAL_FS.as_ref(),
        tmp.path(),
        Some(cwd),
        &[] as &[(String, TomlValue)],
        LoaderOverrides {
            ignore_user_config: true,
            ..Default::default()
        },
        &codex_config::NoopThreadConfigLoader,
    )
    .await?;

    let user_layer = layers
        .get_active_user_layer()
        .expect("expected a user layer even when CODEX_HOME/config.toml is ignored");
    assert_eq!(
        user_layer.config,
        TomlValue::Table(toml::map::Map::new()),
        "expected ignored user config to preserve only layer metadata"
    );
    assert_eq!(layers.effective_config().get("model"), None);
    Ok(())
}

#[tokio::test]
async fn ignore_project_config_skips_project_discovery() -> std::io::Result<()> {
    let tmp = tempdir().expect("tempdir");
    let codex_home = tmp.path().join("home");
    let workspace = tmp.path().join("workspace");
    tokio::fs::create_dir_all(codex_home.as_path()).await?;
    tokio::fs::create_dir_all(workspace.join(".git")).await?;
    make_config_for_test(
        &codex_home,
        &workspace,
        TrustLevel::Trusted,
        /*project_root_markers*/ None,
    )
    .await?;
    let project_config_dir = workspace.join(".codex");
    tokio::fs::create_dir_all(&project_config_dir).await?;
    tokio::fs::write(
        project_config_dir.join(CONFIG_TOML_FILE),
        r#"model = "from-project"
invalid = ["#,
    )
    .await?;

    let cwd = AbsolutePathBuf::from_absolute_path(&workspace)?;
    let layers = load_config_layers_state(
        LOCAL_FS.as_ref(),
        &codex_home,
        Some(cwd),
        &[(
            "model".to_string(),
            TomlValue::String("from-session".to_string()),
        )],
        ConfigLoadOptions {
            loader_overrides: LoaderOverrides {
                ignore_project_config: true,
                ..LoaderOverrides::without_managed_config_for_tests()
            },
            cloud_config_bundle: CloudConfigBundleFixture::loader_with_enterprise_config(
                r#"review_model = "from-cloud""#,
            ),
            ..Default::default()
        },
        &codex_config::NoopThreadConfigLoader,
    )
    .await?;

    assert!(
        layers
            .layers_low_to_high()
            .all(|layer| !matches!(layer.name, ConfigLayerSource::Project { .. }))
    );
    assert_eq!(
        layers.effective_config().get("model"),
        Some(&TomlValue::String("from-session".to_string()))
    );
    assert_eq!(
        layers.effective_config().get("review_model"),
        Some(&TomlValue::String("from-cloud".to_string()))
    );
    Ok(())
}

#[tokio::test]
async fn ignore_rules_marks_config_stack_for_exec_policy_rule_skip() -> std::io::Result<()> {
    let tmp = tempdir().expect("tempdir");
    let cwd = AbsolutePathBuf::try_from(tmp.path()).expect("cwd");

    let layers = load_config_layers_state(
        LOCAL_FS.as_ref(),
        tmp.path(),
        Some(cwd),
        &[] as &[(String, TomlValue)],
        LoaderOverrides {
            ignore_user_and_project_exec_policy_rules: true,
            ..Default::default()
        },
        &codex_config::NoopThreadConfigLoader,
    )
    .await?;

    assert!(layers.ignore_user_and_project_exec_policy_rules());
    Ok(())
}

#[tokio::test]
async fn returns_config_error_for_invalid_managed_config_toml() {
    let tmp = tempdir().expect("tempdir");
    let managed_path = tmp.path().join("managed_config.toml");
    let contents = r#"model = "gpt-4"
invalid = ["#;
    std::fs::write(&managed_path, contents).expect("write managed config");

    let overrides = LoaderOverrides::with_managed_config_path_for_tests(managed_path.clone());

    let cwd = AbsolutePathBuf::try_from(tmp.path()).expect("cwd");
    let err = load_config_layers_state(
        LOCAL_FS.as_ref(),
        tmp.path(),
        Some(cwd),
        &[] as &[(String, TomlValue)],
        overrides,
        &codex_config::NoopThreadConfigLoader,
    )
    .await
    .expect_err("expected error");

    let config_error = config_error_from_io(&err);
    let expected_toml_error = toml::from_str::<TomlValue>(contents).expect_err("parse error");
    let expected_config_error =
        config_error_from_toml(&managed_path, contents, expected_toml_error);
    assert_eq!(config_error, &expected_config_error);
}

#[tokio::test]
async fn returns_config_error_for_schema_error_in_user_config() {
    let tmp = tempdir().expect("tempdir");
    let contents = "model_context_window = \"not_a_number\"";
    let config_path = tmp.path().join(CONFIG_TOML_FILE);
    std::fs::write(&config_path, contents).expect("write config");

    let err = ConfigBuilder::default()
        .codex_home(tmp.path().to_path_buf())
        .fallback_cwd(Some(tmp.path().to_path_buf()))
        .build()
        .await
        .expect_err("expected error");

    let config_error = config_error_from_io(&err);
    let _guard = codex_utils_absolute_path::AbsolutePathBufGuard::new(tmp.path());
    let expected_config_error =
        codex_config::config_error_from_typed_toml::<ConfigToml>(&config_path, contents)
            .expect("schema error");
    assert_eq!(config_error, &expected_config_error);
}

#[tokio::test]
async fn top_level_allow_managed_hooks_only_in_user_config_does_not_enable_requirements_policy()
-> std::io::Result<()> {
    let tmp = tempdir().expect("tempdir");
    std::fs::write(
        tmp.path().join(CONFIG_TOML_FILE),
        "allow_managed_hooks_only = true",
    )
    .expect("write config");

    let cwd = AbsolutePathBuf::try_from(tmp.path()).expect("cwd");
    let layers = load_config_layers_state(
        LOCAL_FS.as_ref(),
        tmp.path(),
        Some(cwd),
        &[] as &[(String, TomlValue)],
        LoaderOverrides::default(),
        &codex_config::NoopThreadConfigLoader,
    )
    .await?;

    assert_eq!(layers.requirements_toml().allow_managed_hooks_only, None);
    assert!(layers.requirements().allow_managed_hooks_only.is_none());

    Ok(())
}

#[tokio::test]
async fn hooks_allow_managed_hooks_only_in_user_config_does_not_enable_requirements_policy()
-> std::io::Result<()> {
    let tmp = tempdir().expect("tempdir");
    let contents = r#"
[hooks]
allow_managed_hooks_only = true

[[hooks.PreToolUse]]
matcher = "^Bash$"

[[hooks.PreToolUse.hooks]]
type = "command"
command = "python3 /tmp/user-hook.py"
"#;
    std::fs::write(tmp.path().join(CONFIG_TOML_FILE), contents).expect("write config");

    let cwd = AbsolutePathBuf::try_from(tmp.path()).expect("cwd");
    let layers = load_config_layers_state(
        LOCAL_FS.as_ref(),
        tmp.path(),
        Some(cwd),
        &[] as &[(String, TomlValue)],
        LoaderOverrides::default(),
        &codex_config::NoopThreadConfigLoader,
    )
    .await?;

    assert!(
        layers
            .get_active_user_layer()
            .and_then(|layer| layer.config.get("hooks"))
            .is_some(),
        "hooks should still deserialize from config.toml"
    );
    assert_eq!(layers.requirements_toml().allow_managed_hooks_only, None);
    assert!(layers.requirements().allow_managed_hooks_only.is_none());

    Ok(())
}

#[tokio::test]
async fn strict_config_rejects_unknown_user_config_key() {
    let tmp = tempdir().expect("tempdir");
    let contents = r#"model = "gpt-5"
unknown_key = true"#;
    let config_path = tmp.path().join(CONFIG_TOML_FILE);
    std::fs::write(&config_path, contents).expect("write config");

    let err = ConfigBuilder::default()
        .codex_home(tmp.path().to_path_buf())
        .fallback_cwd(Some(tmp.path().to_path_buf()))
        .loader_overrides(LoaderOverrides::without_managed_config_for_tests())
        .strict_config(/*strict_config*/ true)
        .build()
        .await
        .expect_err("expected error");

    let config_error = config_error_from_io(&err);
    let expected_config_error =
        config_error_from_ignored_toml_fields::<ConfigToml>(&config_path, contents)
            .expect("unknown field error");
    assert_eq!(config_error, &expected_config_error);
}

#[tokio::test]
async fn non_strict_config_rejects_mixed_shell_environment_policy_before_higher_layer_merge() {
    let tmp = tempdir().expect("tempdir");
    let contents = r#"
[shell_environment_policy]
exclude = ["LEGACY_*"]

[shell_environment_policy.filters]
"CANONICAL_*" = "include"
"#;
    let config_path = tmp.path().join(CONFIG_TOML_FILE);
    std::fs::write(&config_path, contents).expect("write config");

    let err = ConfigBuilder::default()
        .codex_home(tmp.path().to_path_buf())
        .fallback_cwd(Some(tmp.path().to_path_buf()))
        .loader_overrides(LoaderOverrides::without_managed_config_for_tests())
        .cli_overrides(vec![(
            "shell_environment_policy.filters.HIGHER_*".to_string(),
            TomlValue::String("exclude".to_string()),
        )])
        .strict_config(/*strict_config*/ false)
        .build()
        .await
        .expect_err("one config layer must not mix legacy lists and filters");

    assert_eq!(
        config_error_from_io(&err),
        &config_error_from_typed_toml::<ConfigToml>(&config_path, contents)
            .expect("mixed shell policy should produce a typed config error")
    );
}

#[tokio::test]
async fn shell_environment_policy_unknown_fields_follow_strict_config() {
    let tmp = tempdir().expect("tempdir");
    let contents = r#"
[shell_environment_policy]
future_field = true
"#;
    let config_path = tmp.path().join(CONFIG_TOML_FILE);
    std::fs::write(&config_path, contents).expect("write config");

    ConfigBuilder::default()
        .codex_home(tmp.path().to_path_buf())
        .fallback_cwd(Some(tmp.path().to_path_buf()))
        .loader_overrides(LoaderOverrides::without_managed_config_for_tests())
        .strict_config(/*strict_config*/ false)
        .build()
        .await
        .expect("non-strict config should ignore unknown fields");

    let err = ConfigBuilder::default()
        .codex_home(tmp.path().to_path_buf())
        .fallback_cwd(Some(tmp.path().to_path_buf()))
        .loader_overrides(LoaderOverrides::without_managed_config_for_tests())
        .strict_config(/*strict_config*/ true)
        .build()
        .await
        .expect_err("strict config should reject unknown fields");

    assert_eq!(
        config_error_from_io(&err).message,
        "unknown configuration field `shell_environment_policy.future_field`"
    );
}

#[tokio::test]
async fn non_strict_config_merges_shell_filter_case_variants_across_layers() {
    let tmp = tempdir().expect("tempdir");
    let contents = r#"
[shell_environment_policy.filters]
"SECRET_TOKEN" = "exclude"
"#;
    std::fs::write(tmp.path().join(CONFIG_TOML_FILE), contents).expect("write config");

    let config = ConfigBuilder::default()
        .codex_home(tmp.path().to_path_buf())
        .fallback_cwd(Some(tmp.path().to_path_buf()))
        .loader_overrides(LoaderOverrides::without_managed_config_for_tests())
        .cli_overrides(vec![(
            "shell_environment_policy.filters.secret_token".to_string(),
            TomlValue::String("include".to_string()),
        )])
        .strict_config(/*strict_config*/ false)
        .build()
        .await
        .expect("higher-priority case-variant filter should override the lower layer");

    assert!(
        config
            .permissions
            .shell_environment_policy
            .exclude
            .is_empty()
    );
    assert_eq!(
        config.permissions.shell_environment_policy.include_only,
        vec![EnvironmentVariablePattern::new_case_insensitive(
            "secret_token"
        )]
    );
}

#[tokio::test]
async fn non_strict_config_rejects_malformed_shell_policy_before_representation_conversion() {
    let cases = [
        (
            r#"
[shell_environment_policy]
exclude = ["SECRET_*", 17]
"#,
            vec![(
                "shell_environment_policy.filters.PATH".to_string(),
                TomlValue::String("include".to_string()),
            )],
        ),
        (
            r#"
[shell_environment_policy.filters]
"SECRET_*" = "keep"
"#,
            vec![(
                "shell_environment_policy.exclude".to_string(),
                TomlValue::Array(vec![TomlValue::String("PATH".to_string())]),
            )],
        ),
    ];

    for (contents, cli_overrides) in cases {
        let tmp = tempdir().expect("tempdir");
        std::fs::write(tmp.path().join(CONFIG_TOML_FILE), contents).expect("write config");

        ConfigBuilder::default()
            .codex_home(tmp.path().to_path_buf())
            .fallback_cwd(Some(tmp.path().to_path_buf()))
            .loader_overrides(LoaderOverrides::without_managed_config_for_tests())
            .cli_overrides(cli_overrides)
            .strict_config(/*strict_config*/ false)
            .build()
            .await
            .expect_err("malformed shell policy should be rejected before conversion");
    }
}

#[tokio::test]
async fn non_strict_config_allows_replaced_shell_policy_fields_outside_filter_representation() {
    let cases = [
        (
            r#"
[shell_environment_policy]
inherit = "invalid"
set = ["invalid"]
"#,
            vec![
                (
                    "shell_environment_policy.inherit".to_string(),
                    TomlValue::String("core".to_string()),
                ),
                (
                    "shell_environment_policy.set.PATH".to_string(),
                    TomlValue::String("/bin".to_string()),
                ),
            ],
        ),
        (
            r#"shell_environment_policy = 17"#,
            vec![(
                "shell_environment_policy.inherit".to_string(),
                TomlValue::String("core".to_string()),
            )],
        ),
    ];

    for (contents, cli_overrides) in cases {
        let tmp = tempdir().expect("tempdir");
        std::fs::write(tmp.path().join(CONFIG_TOML_FILE), contents).expect("write config");

        ConfigBuilder::default()
            .codex_home(tmp.path().to_path_buf())
            .fallback_cwd(Some(tmp.path().to_path_buf()))
            .loader_overrides(LoaderOverrides::without_managed_config_for_tests())
            .cli_overrides(cli_overrides)
            .strict_config(/*strict_config*/ false)
            .build()
            .await
            .expect("replaced shell policy fields should preserve normal overlay behavior");
    }
}

#[tokio::test]
async fn malformed_higher_shell_filter_reports_its_layer_when_lower_fields_are_replaced() {
    let tmp = tempdir().expect("tempdir");
    let managed_path = tmp.path().join("managed_config.toml");
    std::fs::write(
        tmp.path().join(CONFIG_TOML_FILE),
        r#"[shell_environment_policy]
inherit = "invalid"
set = ["invalid"]
"#,
    )
    .expect("write user config");
    std::fs::write(
        &managed_path,
        r#"[shell_environment_policy]
inherit = "core"
set = { PATH = "/bin" }

[shell_environment_policy.filters]
"SECRET_*" = "keep"
"#,
    )
    .expect("write managed config");

    let err = ConfigBuilder::default()
        .codex_home(tmp.path().to_path_buf())
        .fallback_cwd(Some(tmp.path().to_path_buf()))
        .loader_overrides(LoaderOverrides::with_managed_config_path_for_tests(
            managed_path.clone(),
        ))
        .strict_config(/*strict_config*/ false)
        .build()
        .await
        .expect_err("malformed shell filter should be rejected");

    let config_error = config_error_from_io(&err);
    assert_eq!(config_error.path, managed_path);
    assert!(config_error.message.contains("unknown variant `keep`"));
}

#[tokio::test]
async fn strict_config_rejects_unknown_cli_override_key() {
    let tmp = tempdir().expect("tempdir");

    let err = ConfigBuilder::default()
        .codex_home(tmp.path().to_path_buf())
        .fallback_cwd(Some(tmp.path().to_path_buf()))
        .loader_overrides(LoaderOverrides::without_managed_config_for_tests())
        .cli_overrides(vec![(
            "foo".to_string(),
            TomlValue::String("bar".to_string()),
        )])
        .strict_config(/*strict_config*/ true)
        .build()
        .await
        .expect_err("expected error");

    assert_eq!(
        err.to_string(),
        "unknown configuration field `foo` in -c/--config override"
    );
}

#[tokio::test]
async fn strict_config_rejects_unknown_cli_override_key_with_relative_path_override() {
    let tmp = tempdir().expect("tempdir");
    let instructions_path = tmp.path().join("instructions.md");
    std::fs::write(&instructions_path, "instructions").expect("write instructions");

    let err = ConfigBuilder::default()
        .codex_home(tmp.path().to_path_buf())
        .fallback_cwd(Some(tmp.path().to_path_buf()))
        .loader_overrides(LoaderOverrides::without_managed_config_for_tests())
        .cli_overrides(vec![
            (
                "model_instructions_file".to_string(),
                TomlValue::String("instructions.md".to_string()),
            ),
            ("foo".to_string(), TomlValue::String("bar".to_string())),
        ])
        .strict_config(/*strict_config*/ true)
        .build()
        .await
        .expect_err("expected error");

    assert_eq!(
        err.to_string(),
        "unknown configuration field `foo` in -c/--config override"
    );
}

#[tokio::test]
async fn strict_config_rejects_unknown_feature_cli_override_key() {
    let tmp = tempdir().expect("tempdir");

    let err = ConfigBuilder::default()
        .codex_home(tmp.path().to_path_buf())
        .fallback_cwd(Some(tmp.path().to_path_buf()))
        .loader_overrides(LoaderOverrides::without_managed_config_for_tests())
        .cli_overrides(vec![("features.foo".to_string(), TomlValue::Boolean(true))])
        .strict_config(/*strict_config*/ true)
        .build()
        .await
        .expect_err("expected error");

    assert_eq!(
        err.to_string(),
        "unknown configuration field `features.foo` in -c/--config override"
    );
}

#[tokio::test]
async fn strict_config_rejects_unknown_feature_user_config_key() {
    let tmp = tempdir().expect("tempdir");
    let contents = r#"[features]
foo = true"#;
    let config_path = tmp.path().join(CONFIG_TOML_FILE);
    std::fs::write(&config_path, contents).expect("write config");

    let err = ConfigBuilder::default()
        .codex_home(tmp.path().to_path_buf())
        .fallback_cwd(Some(tmp.path().to_path_buf()))
        .loader_overrides(LoaderOverrides::without_managed_config_for_tests())
        .strict_config(/*strict_config*/ true)
        .build()
        .await
        .expect_err("expected error");

    let config_error = config_error_from_io(&err);
    assert_eq!(
        config_error.message,
        "unknown configuration field `features.foo`"
    );
    assert_eq!(config_error.range.start.line, 2);
    assert_eq!(config_error.range.start.column, 1);
}

#[tokio::test]
async fn strict_config_accepts_removed_shared_compression_key_without_changing_compression() {
    for enabled in [false, true] {
        let tmp = tempdir().expect("tempdir");
        let removed = !enabled;
        std::fs::write(
            tmp.path().join(CONFIG_TOML_FILE),
            format!(
                "[features]\nlocal_thread_store_compression = {enabled}\nlocal_thread_store_shared_compression = {removed}\n"
            ),
        )
        .expect("write config");

        let config = ConfigBuilder::default()
            .codex_home(tmp.path().to_path_buf())
            .fallback_cwd(Some(tmp.path().to_path_buf()))
            .loader_overrides(LoaderOverrides::without_managed_config_for_tests())
            .strict_config(/*strict_config*/ true)
            .build()
            .await
            .expect("removed feature remains accepted");

        assert_eq!(
            config
                .features
                .enabled(Feature::LocalThreadStoreCompression),
            enabled
        );
    }
}

#[test]
fn strict_config_points_to_unknown_nested_key() {
    let tmp = tempdir().expect("tempdir");
    let contents = r#"[mcp_servers.local]
command = "echo"
unknown_key = true"#;
    let config_path = tmp.path().join(CONFIG_TOML_FILE);
    std::fs::write(&config_path, contents).expect("write config");

    let error = config_error_from_ignored_toml_fields::<ConfigToml>(&config_path, contents)
        .expect("unknown field error");

    assert_eq!(
        error.message,
        "unknown configuration field `mcp_servers.local.unknown_key`"
    );
    assert_eq!(error.range.start.line, 3);
    assert_eq!(error.range.start.column, 1);
}
#[test]
fn schema_error_points_to_feature_value() {
    let tmp = tempdir().expect("tempdir");
    let contents = r#"[features]
collaboration_modes = "true""#;
    let config_path = tmp.path().join(CONFIG_TOML_FILE);
    std::fs::write(&config_path, contents).expect("write config");

    let _guard = codex_utils_absolute_path::AbsolutePathBufGuard::new(tmp.path());
    let error = codex_config::config_error_from_typed_toml::<ConfigToml>(&config_path, contents)
        .expect("schema error");

    let value_line = contents.lines().nth(1).expect("value line");
    let value_column = value_line.find("\"true\"").expect("value") + 1;
    assert_eq!(error.range.start.line, 2);
    assert_eq!(error.range.start.column, value_column);
}

#[tokio::test]
async fn merges_managed_config_layer_on_top() {
    let tmp = tempdir().expect("tempdir");
    let managed_path = tmp.path().join("managed_config.toml");

    std::fs::write(
        tmp.path().join(CONFIG_TOML_FILE),
        r#"foo = 1

[nested]
value = "base"
"#,
    )
    .expect("write base");
    std::fs::write(
        &managed_path,
        r#"foo = 2

[nested]
value = "managed_config"
extra = true
"#,
    )
    .expect("write managed config");

    let overrides = LoaderOverrides::with_managed_config_path_for_tests(managed_path);

    let cwd = AbsolutePathBuf::try_from(tmp.path()).expect("cwd");
    let state = load_config_layers_state(
        LOCAL_FS.as_ref(),
        tmp.path(),
        Some(cwd),
        &[] as &[(String, TomlValue)],
        overrides,
        &codex_config::NoopThreadConfigLoader,
    )
    .await
    .expect("load config");
    let loaded = state.effective_config();
    let table = loaded.as_table().expect("top-level table expected");

    assert_eq!(table.get("foo"), Some(&TomlValue::Integer(2)));
    let nested = table
        .get("nested")
        .and_then(|v| v.as_table())
        .expect("nested");
    assert_eq!(
        nested.get("value"),
        Some(&TomlValue::String("managed_config".to_string()))
    );
    assert_eq!(nested.get("extra"), Some(&TomlValue::Boolean(true)));
}

#[tokio::test]
async fn managed_goal_token_budget_overrides_user_config() -> anyhow::Result<()> {
    let tmp = tempdir()?;
    let managed_path = tmp.path().join("managed_config.toml");
    std::fs::write(
        tmp.path().join(CONFIG_TOML_FILE),
        "[goals]\nmax_goal_token_budget = 20000\n",
    )?;
    std::fs::write(&managed_path, "[goals]\nmax_goal_token_budget = 5000\n")?;

    let state = load_config_layers_state(
        LOCAL_FS.as_ref(),
        tmp.path(),
        Some(AbsolutePathBuf::try_from(tmp.path())?),
        &[] as &[(String, TomlValue)],
        LoaderOverrides::with_managed_config_path_for_tests(managed_path),
        &codex_config::NoopThreadConfigLoader,
    )
    .await?;

    assert_eq!(
        state
            .effective_config()
            .get("goals")
            .and_then(|goals| goals.get("max_goal_token_budget")),
        Some(&TomlValue::Integer(5_000))
    );
    Ok(())
}

#[tokio::test]
async fn returns_packaged_defaults_when_other_layers_are_missing() {
    let tmp = tempdir().expect("tempdir");
    let managed_path = tmp.path().join("managed_config.toml");

    let overrides = LoaderOverrides::with_managed_config_path_for_tests(managed_path);

    let cwd = AbsolutePathBuf::try_from(tmp.path()).expect("cwd");
    let layers = load_config_layers_state(
        LOCAL_FS.as_ref(),
        tmp.path(),
        Some(cwd),
        &[] as &[(String, TomlValue)],
        overrides,
        &codex_config::NoopThreadConfigLoader,
    )
    .await
    .expect("load layers");
    let user_layer = layers
        .get_active_user_layer()
        .expect("expected a user layer even when CODEX_HOME/config.toml does not exist");
    let expected_user_layer = ConfigLayerEntry::new(
        ConfigLayerSource::User {
            file: AbsolutePathBuf::resolve_path_against_base(CONFIG_TOML_FILE, tmp.path()),
            profile: None,
        },
        TomlValue::Table(toml::map::Map::new()),
    );
    assert_eq!(&expected_user_layer, user_layer);
    assert_eq!(
        user_layer.config,
        TomlValue::Table(toml::map::Map::new()),
        "expected empty config for user layer when config.toml does not exist"
    );

    let packaged_defaults = layers
        .layers_low_to_high()
        .find(|layer| matches!(layer.name, ConfigLayerSource::PackagedDefaults { .. }))
        .expect("packaged defaults layer should always be present");
    assert_eq!(layers.effective_config(), packaged_defaults.config);
    let num_system_layers = layers
        .layers_high_to_low()
        .filter(|layer| matches!(layer.name, ConfigLayerSource::System { .. }))
        .count();
    assert_eq!(
        num_system_layers, 1,
        "system layer should always be present"
    );
}

#[tokio::test]
async fn selected_user_config_file_layers_over_base_user_config() {
    let tmp = tempdir().expect("tempdir");
    let managed_path = tmp.path().join("managed_config.toml");
    let selected_config = tmp.path().join("work.config.toml");

    std::fs::write(
        tmp.path().join(CONFIG_TOML_FILE),
        r#"
model = "gpt-main"
approval_policy = "on-request"
"#,
    )
    .expect("write default user config");
    std::fs::write(&selected_config, r#"model = "gpt-work""#).expect("write selected user config");

    let mut overrides = LoaderOverrides::with_managed_config_path_for_tests(managed_path);
    overrides.user_config_path =
        Some(AbsolutePathBuf::from_absolute_path(&selected_config).expect("selected config path"));
    overrides.user_config_profile = Some("work".parse().expect("profile-v2 name"));

    let cwd = AbsolutePathBuf::try_from(tmp.path()).expect("cwd");
    let layers = load_config_layers_state(
        LOCAL_FS.as_ref(),
        tmp.path(),
        Some(cwd),
        &[] as &[(String, TomlValue)],
        overrides,
        &codex_config::NoopThreadConfigLoader,
    )
    .await
    .expect("load layers");

    let user_layers = layers
        .layers_low_to_high()
        .filter(|layer| matches!(layer.name, ConfigLayerSource::User { .. }))
        .collect::<Vec<_>>();
    assert_eq!(user_layers.len(), 2);
    assert_eq!(
        user_layers[0].name,
        ConfigLayerSource::User {
            file: AbsolutePathBuf::from_absolute_path(tmp.path().join(CONFIG_TOML_FILE))
                .expect("base user config path"),
            profile: None,
        }
    );
    let user_layer = layers.get_active_user_layer().expect("selected user layer");
    assert_eq!(
        user_layer.name,
        ConfigLayerSource::User {
            file: AbsolutePathBuf::from_absolute_path(&selected_config)
                .expect("selected user config path"),
            profile: Some("work".to_string()),
        }
    );
    assert_eq!(
        layers
            .effective_config()
            .get("model")
            .and_then(TomlValue::as_str),
        Some("gpt-work")
    );
    assert_eq!(
        layers
            .effective_config()
            .get("approval_policy")
            .and_then(TomlValue::as_str),
        Some("on-request")
    );
}

#[tokio::test]
async fn includes_thread_config_layers_in_stack() -> anyhow::Result<()> {
    let tmp = tempdir()?;
    let cwd_dir = tmp.path().join("project");
    tokio::fs::create_dir_all(&cwd_dir).await?;
    let cwd = AbsolutePathBuf::from_absolute_path(&cwd_dir)?;
    let overrides = LoaderOverrides::without_managed_config_for_tests();
    let expected_system_config = AbsolutePathBuf::from_absolute_path(
        overrides
            .system_config_path
            .as_ref()
            .expect("test overrides should include a system config path"),
    )?;
    let layers = load_config_layers_state(
        LOCAL_FS.as_ref(),
        tmp.path(),
        Some(cwd),
        &[("features.plugins".to_string(), TomlValue::Boolean(true))],
        overrides,
        &StaticThreadConfigLoader::new(vec![ThreadConfigSource::Session(SessionThreadConfig {
            features: BTreeMap::from([("plugins".to_string(), false)]),
            ..Default::default()
        })]),
    )
    .await?;

    let layer_sources = layers
        .layers_high_to_low()
        .map(|layer| layer.name.clone())
        .collect::<Vec<_>>();
    assert_eq!(
        layer_sources,
        vec![
            ConfigLayerSource::SessionFlags,
            ConfigLayerSource::SessionFlags,
            ConfigLayerSource::User {
                file: AbsolutePathBuf::resolve_path_against_base(CONFIG_TOML_FILE, tmp.path()),
                profile: None,
            },
            ConfigLayerSource::System {
                file: expected_system_config,
            },
            ConfigLayerSource::PackagedDefaults {
                file: AbsolutePathBuf::from_absolute_path(std::env::current_exe()?)?,
            },
        ]
    );
    assert_eq!(
        layers
            .effective_config()
            .get("features")
            .and_then(TomlValue::as_table)
            .and_then(|features| features.get("plugins")),
        Some(&TomlValue::Boolean(false))
    );

    Ok(())
}

#[cfg(target_os = "macos")]
#[tokio::test]
async fn managed_preferences_take_highest_precedence() {
    use base64::Engine;

    let tmp = tempdir().expect("tempdir");
    let managed_path = tmp.path().join("managed_config.toml");

    std::fs::write(
        tmp.path().join(CONFIG_TOML_FILE),
        r#"[nested]
value = "base"
"#,
    )
    .expect("write base");
    std::fs::write(
        &managed_path,
        r#"[nested]
value = "managed_config"
flag = true
"#,
    )
    .expect("write managed config");
    let raw_managed_preferences = r#"
# managed profile
[nested]
value = "managed"
flag = false
"#;

    let mut overrides = LoaderOverrides::with_managed_config_path_for_tests(managed_path);
    overrides.managed_preferences_base64 =
        Some(base64::prelude::BASE64_STANDARD.encode(raw_managed_preferences.as_bytes()));

    let cwd = AbsolutePathBuf::try_from(tmp.path()).expect("cwd");
    let state = load_config_layers_state(
        LOCAL_FS.as_ref(),
        tmp.path(),
        Some(cwd),
        &[] as &[(String, TomlValue)],
        overrides,
        &codex_config::NoopThreadConfigLoader,
    )
    .await
    .expect("load config");
    let loaded = state.effective_config();
    let nested = loaded
        .get("nested")
        .and_then(|v| v.as_table())
        .expect("nested table");
    assert_eq!(
        nested.get("value"),
        Some(&TomlValue::String("managed".to_string()))
    );
    assert_eq!(nested.get("flag"), Some(&TomlValue::Boolean(false)));
    let mdm_layer = state
        .layers_high_to_low()
        .find(|layer| {
            matches!(
                layer.name,
                ConfigLayerSource::LegacyManagedConfigTomlFromMdm
            )
        })
        .expect("mdm layer");
    let raw = mdm_layer.raw_toml().expect("preserved mdm toml");
    assert!(raw.contains("# managed profile"));
    assert!(raw.contains("value = \"managed\""));
}

#[cfg(target_os = "macos")]
#[tokio::test]
async fn managed_preferences_expand_home_directory_in_workspace_write_roots() -> anyhow::Result<()>
{
    use base64::Engine;
    use codex_protocol::protocol::SandboxPolicy;

    let Some(home) = dirs::home_dir() else {
        return Ok(());
    };
    let tmp = tempdir()?;

    let mut loader_overrides =
        LoaderOverrides::with_managed_config_path_for_tests(tmp.path().join("managed_config.toml"));
    loader_overrides.managed_preferences_base64 = Some(
        base64::prelude::BASE64_STANDARD.encode(
            r#"
sandbox_mode = "workspace-write"
[sandbox_workspace_write]
writable_roots = ["~/code"]
"#
            .as_bytes(),
        ),
    );

    let config = ConfigBuilder::default()
        .codex_home(tmp.path().to_path_buf())
        .fallback_cwd(Some(tmp.path().to_path_buf()))
        .loader_overrides(loader_overrides)
        .build()
        .await?;

    let expected_root = AbsolutePathBuf::from_absolute_path(home.join("code"))?;
    match &config.legacy_sandbox_policy() {
        SandboxPolicy::WorkspaceWrite { writable_roots, .. } => {
            assert_eq!(
                writable_roots
                    .iter()
                    .filter(|root| **root == expected_root)
                    .count(),
                1,
            );
        }
        other => panic!("expected workspace-write policy, got {other:?}"),
    }

    Ok(())
}

#[cfg(target_os = "macos")]
#[tokio::test]
async fn managed_preferences_requirements_are_applied() -> anyhow::Result<()> {
    use base64::Engine;

    let tmp = tempdir()?;

    let mut loader_overrides =
        LoaderOverrides::with_managed_config_path_for_tests(tmp.path().join("managed_config.toml"));
    loader_overrides.macos_managed_config_requirements_base64 = Some(
        base64::prelude::BASE64_STANDARD.encode(
            r#"
allowed_approval_policies = ["never"]
allowed_sandbox_modes = ["read-only"]
"#
            .as_bytes(),
        ),
    );

    let state = load_config_layers_state(
        LOCAL_FS.as_ref(),
        tmp.path(),
        Some(AbsolutePathBuf::try_from(tmp.path())?),
        &[] as &[(String, TomlValue)],
        loader_overrides,
        &codex_config::NoopThreadConfigLoader,
    )
    .await?;

    assert_eq!(
        state.requirements().approval_policy.value(),
        AskForApproval::Never
    );
    assert_eq!(
        state.requirements().permission_profile.get(),
        &PermissionProfile::read_only()
    );
    assert!(
        state
            .requirements()
            .approval_policy
            .can_set(&AskForApproval::OnRequest)
            .is_err()
    );
    assert!(
        state
            .requirements()
            .permission_profile
            .can_set(&PermissionProfile::workspace_write())
            .is_err()
    );

    Ok(())
}

#[cfg(target_os = "macos")]
#[tokio::test]
async fn managed_preferences_requirements_resolve_paths_against_codex_home() -> anyhow::Result<()> {
    use base64::Engine;

    let tmp = tempdir()?;
    let codex_home = tmp.path().join("codex-home");
    std::fs::create_dir_all(&codex_home)?;

    let mut loader_overrides =
        LoaderOverrides::with_managed_config_path_for_tests(tmp.path().join("managed_config.toml"));
    loader_overrides.macos_managed_config_requirements_base64 = Some(
        base64::prelude::BASE64_STANDARD.encode(
            r#"
sqlite_home = "state"
log_dir = "~/.codex/logs"
model_catalog_json = "models.json"
"#
            .as_bytes(),
        ),
    );

    let layers = load_config_layers_state(
        LOCAL_FS.as_ref(),
        &codex_home,
        Some(AbsolutePathBuf::try_from(tmp.path())?),
        &[] as &[(String, TomlValue)],
        loader_overrides,
        &codex_config::NoopThreadConfigLoader,
    )
    .await?;
    let expected_log_dir = AbsolutePathBuf::resolve_path_against_base("~/.codex/logs", &codex_home);
    let requirements = layers.requirements_toml();

    assert_eq!(
        requirements.sqlite_home.as_deref(),
        Some(codex_home.join("state").as_path())
    );
    assert_eq!(
        requirements.log_dir.as_deref(),
        Some(expected_log_dir.as_path())
    );
    assert_eq!(
        requirements.model_catalog_json.as_deref(),
        Some(codex_home.join("models.json").as_path())
    );

    Ok(())
}

#[cfg(target_os = "macos")]
#[tokio::test]
async fn managed_preferences_requirements_take_precedence() -> anyhow::Result<()> {
    use base64::Engine;

    let tmp = tempdir()?;
    let managed_path = tmp.path().join("managed_config.toml");

    tokio::fs::write(
        &managed_path,
        r#"approval_policy = "on-request"
"#,
    )
    .await?;

    let mut loader_overrides = LoaderOverrides::with_managed_config_path_for_tests(managed_path);
    loader_overrides.macos_managed_config_requirements_base64 = Some(
        base64::prelude::BASE64_STANDARD.encode(
            r#"
allowed_approval_policies = ["never"]
"#
            .as_bytes(),
        ),
    );

    let state = load_config_layers_state(
        LOCAL_FS.as_ref(),
        tmp.path(),
        Some(AbsolutePathBuf::try_from(tmp.path())?),
        &[] as &[(String, TomlValue)],
        loader_overrides,
        &codex_config::NoopThreadConfigLoader,
    )
    .await?;

    assert_eq!(
        state.requirements().approval_policy.value(),
        AskForApproval::Never
    );
    assert!(
        state
            .requirements()
            .approval_policy
            .can_set(&AskForApproval::OnRequest)
            .is_err()
    );

    Ok(())
}

#[tokio::test(flavor = "current_thread")]
async fn load_requirements_toml_produces_expected_constraints() -> anyhow::Result<()> {
    let tmp = tempdir()?;
    let requirements_file = tmp.path().join("requirements.toml");
    tokio::fs::write(
        &requirements_file,
        r#"
allowed_approval_policies = ["never", "on-request"]
allowed_web_search_modes = ["cached"]
enforce_residency = "us"

[features]
personality = true
"#,
    )
    .await?;

    let config_requirements_toml =
        load_single_requirements_toml(&AbsolutePathBuf::try_from(requirements_file)?).await?;

    assert_eq!(
        config_requirements_toml
            .allowed_approval_policies
            .as_deref()
            .cloned(),
        Some(vec![AskForApproval::Never, AskForApproval::OnRequest])
    );
    assert_eq!(
        config_requirements_toml
            .allowed_web_search_modes
            .as_deref()
            .cloned(),
        Some(vec![codex_config::WebSearchModeRequirement::Cached])
    );
    assert_eq!(
        config_requirements_toml
            .feature_requirements
            .as_ref()
            .map(|requirements| requirements.value.clone()),
        Some(codex_config::FeatureRequirementsToml {
            entries: BTreeMap::from([("personality".to_string(), true)]),
        })
    );
    let config_requirements: ConfigRequirements = config_requirements_toml.try_into()?;
    assert_eq!(
        config_requirements.approval_policy.value(),
        AskForApproval::Never
    );
    config_requirements
        .approval_policy
        .can_set(&AskForApproval::Never)?;
    assert_eq!(
        config_requirements.web_search_mode.value(),
        WebSearchMode::Cached
    );
    config_requirements
        .web_search_mode
        .can_set(&WebSearchMode::Cached)?;
    config_requirements
        .web_search_mode
        .can_set(&WebSearchMode::Cached)?;
    config_requirements
        .web_search_mode
        .can_set(&WebSearchMode::Disabled)?;
    assert!(
        config_requirements
            .web_search_mode
            .can_set(&WebSearchMode::Live)
            .is_err()
    );
    assert_eq!(
        config_requirements.enforce_residency.value(),
        Some(codex_config::ResidencyRequirement::Us)
    );
    assert_eq!(
        config_requirements
            .feature_requirements
            .as_ref()
            .map(|requirements| requirements.value.clone()),
        Some(codex_config::FeatureRequirementsToml {
            entries: BTreeMap::from([("personality".to_string(), true)]),
        })
    );
    Ok(())
}

#[tokio::test]
async fn system_requirements_control_in_app_updates() -> anyhow::Result<()> {
    let tmp = tempdir()?;
    let codex_home = tmp.path().join("home");
    tokio::fs::create_dir_all(&codex_home).await?;
    let cwd = AbsolutePathBuf::from_absolute_path(tmp.path())?;

    let default_config = ConfigBuilder::default()
        .codex_home(codex_home.clone())
        .fallback_cwd(Some(cwd.to_path_buf()))
        .loader_overrides(LoaderOverrides::without_managed_config_for_tests())
        .build()
        .await?;
    assert!(default_config.features.enabled(Feature::InAppUpdates));

    let requirements_path = tmp.path().join("requirements.toml");
    tokio::fs::write(
        &requirements_path,
        r#"
[features]
in_app_updates = false
"#,
    )
    .await?;
    let mut overrides = LoaderOverrides::without_managed_config_for_tests();
    overrides.system_requirements_path = Some(requirements_path);
    let managed_config = ConfigBuilder::default()
        .codex_home(codex_home)
        .fallback_cwd(Some(cwd.to_path_buf()))
        .loader_overrides(overrides)
        .build()
        .await?;

    assert!(!managed_config.features.enabled(Feature::InAppUpdates));
    Ok(())
}

#[cfg(target_os = "macos")]
#[tokio::test]
async fn mdm_requirements_take_precedence_over_cloud_config_bundle() -> anyhow::Result<()> {
    use base64::Engine;

    let tmp = tempdir()?;
    let mut loader_overrides = LoaderOverrides::without_managed_config_for_tests();
    loader_overrides.macos_managed_config_requirements_base64 = Some(
        base64::prelude::BASE64_STANDARD.encode(
            r#"
allowed_approval_policies = ["on-request"]
"#
            .as_bytes(),
        ),
    );
    let state = load_config_layers_state(
        LOCAL_FS.as_ref(),
        tmp.path(),
        Some(AbsolutePathBuf::try_from(tmp.path())?),
        &[] as &[(String, TomlValue)],
        ConfigLoadOptions {
            loader_overrides,
            cloud_config_bundle: CloudConfigBundleFixture::loader_with_enterprise_requirement(
                r#"allowed_approval_policies = ["never"]"#,
            ),
            ..Default::default()
        },
        &codex_config::NoopThreadConfigLoader,
    )
    .await?;

    assert_eq!(
        state.requirements().approval_policy.value(),
        AskForApproval::OnRequest
    );
    assert_eq!(
        state
            .requirements()
            .approval_policy
            .can_set(&AskForApproval::Never),
        Err(ConstraintError::InvalidValue {
            field_name: "approval_policy",
            candidate: "Never".into(),
            allowed: "[OnRequest]".into(),
            requirement_source: RequirementSource::MdmManagedPreferences {
                domain: "com.openai.codex".to_string(),
                key: "requirements_toml_base64".to_string(),
            },
        })
    );

    Ok(())
}

#[tokio::test(flavor = "current_thread")]
async fn cloud_config_bundle_are_not_overwritten_by_system_requirements() -> anyhow::Result<()> {
    let tmp = tempdir()?;
    let requirements_file = tmp.path().join("requirements.toml");
    tokio::fs::write(
        &requirements_file,
        r#"
allowed_approval_policies = ["on-request"]
"#,
    )
    .await?;

    let system_layer = load_requirements_toml(
        LOCAL_FS.as_ref(),
        &AbsolutePathBuf::try_from(requirements_file)?,
    )
    .await?
    .expect("system requirements should load");
    let config_requirements_toml = compose_requirements(vec![
        system_layer,
        RequirementsLayerEntry::from_toml(
            cloud_config_bundle_requirement_source(),
            r#"allowed_approval_policies = ["never"]"#,
        ),
    ])?
    .expect("requirements should be present");

    assert_eq!(
        config_requirements_toml
            .allowed_approval_policies
            .as_ref()
            .map(|sourced| sourced.value.clone()),
        Some(vec![AskForApproval::Never])
    );
    assert_eq!(
        config_requirements_toml
            .allowed_approval_policies
            .as_ref()
            .map(|sourced| sourced.source.clone()),
        Some(cloud_config_bundle_requirement_source())
    );

    Ok(())
}

#[tokio::test(flavor = "current_thread")]
async fn system_remote_sandbox_config_keeps_cloud_sandbox_modes() -> anyhow::Result<()> {
    let tmp = tempdir()?;
    let requirements_file = tmp.path().join("requirements.toml");
    tokio::fs::write(
        &requirements_file,
        r#"
[[remote_sandbox_config]]
hostname_patterns = ["*"]
allowed_sandbox_modes = ["read-only", "workspace-write"]
"#,
    )
    .await?;

    let cloud_source = cloud_config_bundle_requirement_source();
    let system_layer = load_requirements_toml(
        LOCAL_FS.as_ref(),
        &AbsolutePathBuf::try_from(requirements_file)?,
    )
    .await?
    .expect("system requirements should load");
    let config_requirements_toml = compose_requirements(vec![
        system_layer,
        RequirementsLayerEntry::from_toml(
            cloud_source.clone(),
            r#"allowed_sandbox_modes = ["read-only"]"#,
        ),
    ])?
    .expect("requirements should be present");
    let config_requirements: ConfigRequirements = config_requirements_toml.try_into()?;

    assert_eq!(
        config_requirements
            .permission_profile
            .can_set(&PermissionProfile::workspace_write()),
        Err(ConstraintError::InvalidValue {
            field_name: "sandbox_mode",
            candidate: "WorkspaceWrite".into(),
            allowed: "[ReadOnly]".into(),
            requirement_source: cloud_source,
        })
    );

    Ok(())
}

#[tokio::test(flavor = "current_thread")]
async fn load_requirements_toml_resolves_deny_read_against_parent() -> anyhow::Result<()> {
    let tmp = tempdir()?;
    let requirements_dir = tmp.path().join("managed");
    tokio::fs::create_dir_all(&requirements_dir).await?;
    let requirements_file = requirements_dir.join("requirements.toml");
    tokio::fs::write(
        &requirements_file,
        r#"
[permissions.filesystem]
deny_read = ["./sensitive", "../shared/secret.txt"]
"#,
    )
    .await?;

    let requirements_file = AbsolutePathBuf::try_from(requirements_file)?;
    let config_requirements_toml = load_single_requirements_toml(&requirements_file).await?;

    let permissions = config_requirements_toml
        .permissions
        .expect("permissions requirements should load");
    let filesystem = permissions
        .value
        .filesystem
        .expect("filesystem requirements should load");
    let deny_read = filesystem.deny_read.expect("deny_read paths should load");

    assert_eq!(
        deny_read,
        vec![
            FilesystemDenyReadPattern::from(AbsolutePathBuf::try_from(
                requirements_dir.join("sensitive")
            )?,),
            FilesystemDenyReadPattern::from(AbsolutePathBuf::try_from(
                tmp.path().join("shared").join("secret.txt"),
            )?),
        ]
    );
    assert_eq!(
        permissions.source,
        RequirementSource::SystemRequirementsToml {
            file: requirements_file,
        }
    );

    Ok(())
}

#[tokio::test(flavor = "current_thread")]
async fn load_requirements_toml_resolves_deny_read_glob_against_parent() -> anyhow::Result<()> {
    let tmp = tempdir()?;
    let requirements_dir = tmp.path().join("managed");
    tokio::fs::create_dir_all(&requirements_dir).await?;
    let requirements_file = requirements_dir.join("requirements.toml");
    tokio::fs::write(
        &requirements_file,
        r#"
[permissions.filesystem]
deny_read = ["./sensitive/**/*.txt"]
"#,
    )
    .await?;

    let requirements_file = AbsolutePathBuf::try_from(requirements_file)?;
    let config_requirements_toml = load_single_requirements_toml(&requirements_file).await?;

    let permissions = config_requirements_toml
        .permissions
        .expect("permissions requirements should load");
    let filesystem = permissions
        .value
        .filesystem
        .expect("filesystem requirements should load");
    let deny_read = filesystem
        .deny_read
        .expect("deny_read patterns should load");

    assert_eq!(
        deny_read,
        vec![
            FilesystemDenyReadPattern::from_input(&format!(
                "{}/sensitive/**/*.txt",
                requirements_dir.display()
            ))
            .expect("normalize glob pattern")
        ]
    );
    assert_eq!(
        permissions.source,
        RequirementSource::SystemRequirementsToml {
            file: requirements_file,
        }
    );

    Ok(())
}

#[tokio::test]
async fn load_config_layers_includes_cloud_config_bundle() -> anyhow::Result<()> {
    let tmp = tempdir()?;
    let codex_home = tmp.path().join("home");
    tokio::fs::create_dir_all(&codex_home).await?;
    let cwd = AbsolutePathBuf::from_absolute_path(tmp.path())?;

    let requirements = r#"allowed_approval_policies = ["never"]"#;
    let expected: ConfigRequirementsToml = toml::from_str(requirements)?;
    let cloud_config_bundle =
        CloudConfigBundleFixture::loader_with_enterprise_requirement(requirements);

    let layers = load_config_layers_state(
        LOCAL_FS.as_ref(),
        &codex_home,
        Some(cwd),
        &[] as &[(String, TomlValue)],
        ConfigLoadOptions {
            loader_overrides: LoaderOverrides::without_managed_config_for_tests(),
            cloud_config_bundle,
            ..Default::default()
        },
        &codex_config::NoopThreadConfigLoader,
    )
    .await?;

    assert_eq!(
        layers.requirements_toml().allowed_approval_policies,
        expected.allowed_approval_policies
    );
    assert_eq!(
        layers
            .requirements()
            .approval_policy
            .can_set(&AskForApproval::OnRequest),
        Err(ConstraintError::InvalidValue {
            field_name: "approval_policy",
            candidate: "OnRequest".into(),
            allowed: "[Never]".into(),
            requirement_source: cloud_config_bundle_requirement_source(),
        })
    );

    Ok(())
}

#[tokio::test]
async fn resolve_permission_profile_from_effective_configuration() -> anyhow::Result<()> {
    let codex_home = tempdir()?;
    tokio::fs::write(
        codex_home.path().join(CONFIG_TOML_FILE),
        r#"
default_permissions = "configured-profile"

[permissions.configured-profile]
description = "Configured profile"
extends = ":read-only"

[permissions.configured-profile.network]
enabled = true
"#,
    )
    .await?;

    let config = ConfigBuilder::without_managed_config_for_tests()
        .codex_home(codex_home.path().to_path_buf())
        .fallback_cwd(Some(codex_home.path().to_path_buf()))
        .build()
        .await?;

    assert_eq!(
        config.resolve_permission_profile("configured-profile")?,
        toml::from_str::<PermissionProfileToml>(
            r#"
description = "Configured profile"
extends = ":read-only"

[filesystem]
":root" = "read"

[network]
enabled = true
"#
        )?
    );
    Ok(())
}

#[tokio::test]
async fn system_requirements_define_managed_permission_profiles() -> anyhow::Result<()> {
    let tmp = tempdir()?;
    let codex_home = tmp.path().join("home");
    tokio::fs::create_dir_all(&codex_home).await?;
    tokio::fs::write(
        codex_home.join(CONFIG_TOML_FILE),
        r#"
default_permissions = "managed-standard"

[features]
network_proxy = true
"#,
    )
    .await?;
    let requirements_path = tmp.path().join("requirements.toml");
    tokio::fs::write(
        &requirements_path,
        r#"
default_permissions = "managed-standard"

[allowed_permission_profiles]
managed-standard = true

[permissions.managed-standard]
extends = ":workspace"

[permissions.managed-standard.network]
enabled = true
proxy_url = "http://127.0.0.1:43128"
enable_socks5 = false
"#,
    )
    .await?;

    let cwd = AbsolutePathBuf::from_absolute_path(tmp.path())?;
    let mut overrides = LoaderOverrides::without_managed_config_for_tests();
    overrides.system_requirements_path = Some(requirements_path);
    let config = ConfigBuilder::default()
        .codex_home(codex_home)
        .fallback_cwd(Some(cwd.to_path_buf()))
        .loader_overrides(overrides)
        .build()
        .await?;

    assert_eq!(
        config
            .config_layer_stack
            .requirements_toml()
            .allowed_permission_profiles,
        Some(BTreeMap::from([("managed-standard".to_string(), true)]))
    );
    assert_eq!(
        config.resolve_permission_profile("managed-standard")?,
        toml::from_str::<PermissionProfileToml>(
            r#"
extends = ":workspace"

[filesystem]
":root" = "read"
":slash_tmp" = "write"
":tmpdir" = "write"

[filesystem.":workspace_roots"]
"." = "write"

[network]
enabled = true
proxy_url = "http://127.0.0.1:43128"
enable_socks5 = false
"#
        )?
    );
    let active_permission_profile = config
        .permissions
        .active_permission_profile()
        .expect("managed profile should be active");
    assert_eq!(active_permission_profile.id, "managed-standard");

    let network = config
        .network_proxy_spec_for_active_permission_profile(
            &active_permission_profile,
            config.permissions.permission_profile(),
        )?
        .expect("managed profile should retain its network proxy configuration");
    assert_eq!(Some(&network), config.permissions.network.as_ref());
    assert_eq!(network.proxy_host_and_port(), "127.0.0.1:43128");
    assert!(!network.socks_enabled());
    Ok(())
}

#[tokio::test]
async fn credential_masking_respects_config_precedence() -> std::io::Result<()> {
    for (features, requirements, expected_proxy, expected_broker) in [
        (
            "credential_masking = true\n[features.network_proxy]\nenabled = true\ncredential_broker = false",
            "",
            true,
            true,
        ),
        (
            "credential_masking = false\n[features.network_proxy]\nenabled = true\ncredential_broker = true",
            "",
            true,
            true,
        ),
        (
            r#"credential_masking = false
[features.network_proxy]
enabled = false
[features.network_proxy.credentials.vendor]
env = ["VENDOR_TOKEN"]
patterns = ["vendor_[a-z]{8}"]
url_prefixes = ["https://api.vendor.example"]
auth = ["bearer"]"#,
            "[features]\ncredential_masking = true\n[experimental_network]\nenabled = true",
            true,
            true,
        ),
        (
            "credential_masking = true\nnetwork_proxy = true",
            "[features]\ncredential_masking = false",
            true,
            false,
        ),
        (
            "credential_masking = true\nnetwork_proxy = true",
            "[experimental_network]\nenabled = false",
            false,
            false,
        ),
        (
            "credential_masking = true",
            "[experimental_network]\nallow_local_binding = true",
            false,
            false,
        ),
    ] {
        let home = tempdir()?;
        let source =
            format!("openai_base_url = 'https://api.example.test/v1'\n[features]\n{features}\n");
        let configured: ConfigToml = toml::from_str(&source).expect("valid config");
        tokio::fs::write(home.path().join(CONFIG_TOML_FILE), source).await?;
        let config = ConfigBuilder::without_managed_config_for_tests()
            .codex_home(home.path().to_path_buf())
            .harness_overrides(ConfigOverrides {
                cwd: Some(home.path().to_path_buf()),
                permission_profile: Some(PermissionProfile::Managed {
                    file_system: ManagedFileSystemPermissions::Unrestricted,
                    network: NetworkSandboxPolicy::Enabled,
                }),
                ..Default::default()
            })
            .cloud_config_bundle(
                CloudConfigBundleFixture::loader_with_enterprise_requirement(requirements),
            )
            .build()
            .await?;
        let network = config.permissions.network.as_ref().expect("proxy settings");
        assert_eq!(
            (network.enabled(), network.credential_broker_enabled()),
            (expected_proxy, expected_broker),
            "{features}; {requirements}"
        );
        let proxy = network
            .build_config_state_for_spec(Platform::native())?
            .config;
        assert_eq!(
            (proxy.enabled, proxy.credential_broker, proxy.mitm),
            (expected_proxy, expected_broker, expected_broker),
            "{features}; {requirements}"
        );
        if expected_broker {
            let expected_providers = super::network_proxy_toml_config(configured.features.as_ref())
                .and_then(|network_proxy| network_proxy.credentials.clone())
                .unwrap_or_default();
            assert_eq!(proxy.credential_providers, expected_providers);
            assert_eq!(
                proxy.credential_broker_openai_host.as_deref(),
                Some("api.example.test")
            );
        }

        let active_profile = ActivePermissionProfile {
            id: BUILT_IN_PERMISSION_PROFILE_WORKSPACE.to_string(),
            extends: None,
        };
        let reloaded = config.network_proxy_spec_for_active_permission_profile(
            &active_profile,
            &config.permissions.effective_permission_profile(),
        )?;
        assert_eq!(
            reloaded, config.permissions.network,
            "{features}; {requirements}"
        );
        if requirements.is_empty() {
            assert_eq!(
                config.network_proxy_spec_for_active_permission_profile(
                    &active_profile,
                    &PermissionProfile::read_only(),
                )?,
                None,
                "profile change should leave masking inactive when the proxy is disabled"
            );
        }
    }
    Ok(())
}

#[tokio::test]
async fn credential_broker_ambiguity_guard_survives_permission_profile_selection()
-> anyhow::Result<()> {
    for (key, other_key, other_value, ambiguous, credential_masking) in [
        ("GH_HOST", "gh_host", "second.example", true, false),
        ("VENDOR_HOST", "vendor_host", "second.example", true, false),
        (
            "VENDOR_PASSWORD",
            "vendor_password",
            "second.example",
            true,
            false,
        ),
        ("VENDOR_HOST", "vendor_host", "first.example", false, false),
        ("FOO", "foo", "second.example", false, false),
        ("GH_HOST", "gh_host", "second.example", true, true),
    ] {
        let home = tempdir()?;
        tokio::fs::write(
            home.path().join(CONFIG_TOML_FILE),
            format!(
                r#"
default_permissions = "first"
[features]
credential_masking = {credential_masking}
[features.network_proxy]
enabled = true
credential_broker = true
[features.network_proxy.credentials.vendor]
env = ["VENDOR_PASSWORD"]
patterns = ["pin_[a-z]{{8}}"]
url_prefixes = ["https://api.vendor.example"]
url_prefix_from_env = "VENDOR_HOST"
auth = ["bearer"]
[permissions.first]
extends = ":workspace"
[permissions.first.network]
enabled = true
[permissions.second]
extends = "first"
[shell_environment_policy.set]
{key} = "first.example"
{other_key} = "{other_value}"
"#
            ),
        )
        .await?;
        let config = ConfigBuilder::default()
            .codex_home(home.path().to_path_buf())
            .fallback_cwd(Some(home.path().to_path_buf()))
            .loader_overrides(LoaderOverrides::without_managed_config_for_tests())
            .build()
            .await?;
        let expected_enabled = !(cfg!(windows) && ambiguous);
        if credential_masking && !expected_enabled {
            insta::assert_snapshot!(config.startup_warnings.join("\n"), @r"Credential masking is inactive because shell environment overrides contain conflicting case-insensitive provider keys. Commands will receive unmasked credentials. Remove the conflicting entries from `shell_environment_policy.set`.");
        } else {
            assert_eq!(config.startup_warnings, Vec::<String>::new());
        }
        assert_eq!(
            config.permissions.shell_environment_policy.r#set,
            HashMap::from([
                (key.to_string(), "first.example".to_string()),
                (other_key.to_string(), other_value.to_string()),
            ])
        );
        assert_eq!(
            config
                .permissions
                .network
                .as_ref()
                .unwrap()
                .credential_broker_enabled(),
            expected_enabled,
            "{key}"
        );
        let mut selected = config.permissions.active_permission_profile().unwrap();
        selected.id = "second".to_string();
        let rebuilt = config
            .network_proxy_spec_for_active_permission_profile(
                &selected,
                config.permissions.permission_profile(),
            )?
            .unwrap();
        assert_eq!(Some(&rebuilt), config.permissions.network.as_ref(), "{key}");
    }
    Ok(())
}

#[tokio::test]
async fn resolve_permission_profile_inherits_across_configured_and_managed_profiles()
-> anyhow::Result<()> {
    let tmp = tempdir()?;
    let codex_home = tmp.path().join("home");
    tokio::fs::create_dir_all(&codex_home).await?;
    tokio::fs::write(
        codex_home.join(CONFIG_TOML_FILE),
        r#"
default_permissions = "configured-child"

[permissions.configured-parent]
extends = ":read-only"

[permissions.configured-parent.network]
enabled = true
proxy_url = "http://127.0.0.1:43128"

[permissions.configured-child]
description = "Configured child"
extends = "managed-parent"

[permissions.configured-child.network]
enable_socks5 = false
"#,
    )
    .await?;
    let requirements_path = tmp.path().join("requirements.toml");
    tokio::fs::write(
        &requirements_path,
        r#"
[permissions.managed-parent]
extends = ":read-only"

[permissions.managed-parent.network]
enabled = true
proxy_url = "http://127.0.0.1:43129"

[permissions.managed-child]
description = "Managed child"
extends = "configured-parent"

[permissions.managed-child.network]
enable_socks5 = false
"#,
    )
    .await?;

    let mut overrides = LoaderOverrides::without_managed_config_for_tests();
    overrides.system_requirements_path = Some(requirements_path);
    let config = ConfigBuilder::default()
        .codex_home(codex_home)
        .fallback_cwd(Some(tmp.path().to_path_buf()))
        .loader_overrides(overrides)
        .build()
        .await?;

    for (profile_name, expected) in [
        (
            "configured-child",
            r#"
description = "Configured child"
extends = "managed-parent"

[filesystem]
":root" = "read"

[network]
enabled = true
proxy_url = "http://127.0.0.1:43129"
enable_socks5 = false
"#,
        ),
        (
            "managed-child",
            r#"
description = "Managed child"
extends = "configured-parent"

[filesystem]
":root" = "read"

[network]
enabled = true
proxy_url = "http://127.0.0.1:43128"
enable_socks5 = false
"#,
        ),
    ] {
        assert_eq!(
            config.resolve_permission_profile(profile_name)?,
            toml::from_str::<PermissionProfileToml>(expected)?,
            "{profile_name}"
        );
    }
    Ok(())
}

#[tokio::test]
async fn resolve_permission_profile_rejects_duplicate_configured_and_managed_profiles()
-> anyhow::Result<()> {
    let tmp = tempdir()?;
    let codex_home = tmp.path().join("home");
    tokio::fs::create_dir_all(&codex_home).await?;
    tokio::fs::write(
        codex_home.join(CONFIG_TOML_FILE),
        "default_permissions = \":read-only\"\n",
    )
    .await?;
    let requirements_path = tmp.path().join("requirements.toml");
    tokio::fs::write(
        &requirements_path,
        r#"
[permissions.duplicate-profile]
extends = ":read-only"
"#,
    )
    .await?;

    let mut overrides = LoaderOverrides::without_managed_config_for_tests();
    overrides.system_requirements_path = Some(requirements_path);
    let mut config = ConfigBuilder::default()
        .codex_home(codex_home.clone())
        .fallback_cwd(Some(tmp.path().to_path_buf()))
        .loader_overrides(overrides)
        .build()
        .await?;
    let config_toml = AbsolutePathBuf::from_absolute_path(codex_home.join(CONFIG_TOML_FILE))?;
    config.config_layer_stack = config.config_layer_stack.with_user_config(
        &config_toml,
        toml::from_str::<TomlValue>(
            r#"
default_permissions = ":read-only"

[permissions.duplicate-profile]
extends = ":workspace"
"#,
        )?,
    )?;

    let error = config
        .resolve_permission_profile("duplicate-profile")
        .expect_err("duplicate configured and managed profiles should be rejected");
    assert_eq!(
        error.to_string(),
        "requirements.toml permissions profile `duplicate-profile` conflicts with a config-defined profile of the same name"
    );
    Ok(())
}

#[tokio::test]
async fn system_allowed_permission_profiles_select_managed_default_without_local_default()
-> anyhow::Result<()> {
    for trust_level in [Some(TrustLevel::Trusted), Some(TrustLevel::Untrusted), None] {
        let tmp = tempdir()?;
        let codex_home = tmp.path().join("home");
        tokio::fs::create_dir_all(&codex_home).await?;
        if let Some(trust_level) = trust_level {
            make_config_for_test(
                &codex_home,
                tmp.path(),
                trust_level,
                /*project_root_markers*/ None,
            )
            .await?;
        }
        let requirements_path = tmp.path().join("requirements.toml");
        tokio::fs::write(
            &requirements_path,
            r#"
default_permissions = "managed-standard"

[allowed_permission_profiles]
managed-build = true
managed-standard = true

[permissions.managed-standard.filesystem]
":workspace_roots" = "read"

[permissions.managed-build]
extends = ":workspace"
"#,
        )
        .await?;

        let cwd = AbsolutePathBuf::from_absolute_path(tmp.path())?;
        let mut overrides = LoaderOverrides::without_managed_config_for_tests();
        overrides.system_requirements_path = Some(requirements_path);
        let config = ConfigBuilder::default()
            .codex_home(codex_home)
            .fallback_cwd(Some(cwd.to_path_buf()))
            .loader_overrides(overrides)
            .build()
            .await?;

        assert_eq!(
            config
                .permissions
                .active_permission_profile()
                .map(|profile| profile.id),
            Some("managed-standard".to_string()),
            "trust level {trust_level:?}",
        );
        assert!(
            !config.startup_warnings.iter().any(|warning| warning
                .contains("Configured value for `permission_profile` is disallowed")),
            "{:?}",
            config.startup_warnings
        );
    }
    Ok(())
}

#[tokio::test]
async fn system_allowed_permission_profiles_require_managed_default() -> anyhow::Result<()> {
    let tmp = tempdir()?;
    let codex_home = tmp.path().join("home");
    tokio::fs::create_dir_all(&codex_home).await?;
    let requirements_path = tmp.path().join("requirements.toml");
    tokio::fs::write(
        &requirements_path,
        r#"
[permissions.managed-standard]
extends = ":read-only"

[allowed_permission_profiles]
managed-standard = true
"#,
    )
    .await?;

    let mut overrides = LoaderOverrides::without_managed_config_for_tests();
    overrides.system_requirements_path = Some(requirements_path);
    let err = ConfigBuilder::default()
        .codex_home(codex_home)
        .fallback_cwd(Some(tmp.path().to_path_buf()))
        .loader_overrides(overrides)
        .build()
        .await
        .expect_err("allowed_permission_profiles without default_permissions should fail");

    assert!(
        err.to_string().contains(
            "default_permissions must be set unless allowed_permission_profiles allows both"
        ),
        "{err}"
    );
    Ok(())
}

#[tokio::test]
async fn system_allowed_permission_profiles_standard_pair_defaults_to_workspace()
-> anyhow::Result<()> {
    let tmp = tempdir()?;
    let codex_home = tmp.path().join("home");
    tokio::fs::create_dir_all(&codex_home).await?;
    let requirements_path = tmp.path().join("requirements.toml");
    tokio::fs::write(
        &requirements_path,
        r#"
[allowed_permission_profiles]
":read-only" = true
":workspace" = true
"#,
    )
    .await?;

    let mut overrides = LoaderOverrides::without_managed_config_for_tests();
    overrides.system_requirements_path = Some(requirements_path);
    let config = ConfigBuilder::default()
        .codex_home(codex_home)
        .fallback_cwd(Some(tmp.path().to_path_buf()))
        .loader_overrides(overrides)
        .build()
        .await?;

    assert_eq!(
        config
            .permissions
            .active_permission_profile()
            .map(|profile| profile.id),
        Some(BUILT_IN_PERMISSION_PROFILE_WORKSPACE.to_string())
    );
    Ok(())
}

#[tokio::test]
async fn system_managed_default_must_be_allowed() -> anyhow::Result<()> {
    let tmp = tempdir()?;
    let codex_home = tmp.path().join("home");
    tokio::fs::create_dir_all(&codex_home).await?;
    let requirements_path = tmp.path().join("requirements.toml");
    tokio::fs::write(
        &requirements_path,
        r#"
default_permissions = "managed-build"

[allowed_permission_profiles]
managed-standard = true

[permissions.managed-standard]
extends = ":read-only"

[permissions.managed-build]
extends = ":workspace"
"#,
    )
    .await?;

    let mut overrides = LoaderOverrides::without_managed_config_for_tests();
    overrides.system_requirements_path = Some(requirements_path);
    let err = ConfigBuilder::default()
        .codex_home(codex_home)
        .fallback_cwd(Some(tmp.path().to_path_buf()))
        .loader_overrides(overrides)
        .build()
        .await
        .expect_err("managed default outside allowed_permission_profiles should fail");

    assert!(
        err.to_string().contains(
            "default_permissions `managed-build` must be allowed by allowed_permission_profiles"
        ),
        "{err}"
    );
    Ok(())
}

#[tokio::test]
async fn system_managed_default_requires_allowed_permission_profiles() -> anyhow::Result<()> {
    let tmp = tempdir()?;
    let codex_home = tmp.path().join("home");
    tokio::fs::create_dir_all(&codex_home).await?;
    let requirements_path = tmp.path().join("requirements.toml");
    tokio::fs::write(
        &requirements_path,
        r#"
default_permissions = ":read-only"
"#,
    )
    .await?;

    let mut overrides = LoaderOverrides::without_managed_config_for_tests();
    overrides.system_requirements_path = Some(requirements_path);
    let err = ConfigBuilder::default()
        .codex_home(codex_home)
        .fallback_cwd(Some(tmp.path().to_path_buf()))
        .loader_overrides(overrides)
        .build()
        .await
        .expect_err("managed default without allowed_permission_profiles should fail");

    assert!(
        err.to_string()
            .contains("default_permissions requires allowed_permission_profiles"),
        "{err}"
    );
    Ok(())
}

#[tokio::test]
async fn system_allowed_permission_profiles_fall_back_from_disallowed_danger_full_access()
-> anyhow::Result<()> {
    let tmp = tempdir()?;
    let codex_home = tmp.path().join("home");
    tokio::fs::create_dir_all(&codex_home).await?;
    tokio::fs::write(
        codex_home.join(CONFIG_TOML_FILE),
        format!(
            r#"
default_permissions = "{BUILT_IN_PERMISSION_PROFILE_DANGER_FULL_ACCESS}"
"#
        ),
    )
    .await?;
    let requirements_path = tmp.path().join("requirements.toml");
    tokio::fs::write(
        &requirements_path,
        r#"
default_permissions = "managed-standard"

[allowed_permission_profiles]
managed-standard = true

[permissions.managed-standard.filesystem]
":workspace_roots" = "read"
"#,
    )
    .await?;

    let cwd = AbsolutePathBuf::from_absolute_path(tmp.path())?;
    let mut overrides = LoaderOverrides::without_managed_config_for_tests();
    overrides.system_requirements_path = Some(requirements_path);
    let config = ConfigBuilder::default()
        .codex_home(codex_home)
        .fallback_cwd(Some(cwd.to_path_buf()))
        .loader_overrides(overrides)
        .build()
        .await?;

    assert_eq!(
        config
            .permissions
            .active_permission_profile()
            .map(|profile| profile.id),
        Some("managed-standard".to_string())
    );
    assert!(
        config.startup_warnings.iter().any(|warning| warning
            .contains("Configured value for `permission_profile` is disallowed by requirements")),
        "{:?}",
        config.startup_warnings
    );
    Ok(())
}

#[tokio::test]
async fn system_allowed_permission_profiles_fall_back_from_disallowed_workspace()
-> anyhow::Result<()> {
    let tmp = tempdir()?;
    let codex_home = tmp.path().join("home");
    tokio::fs::create_dir_all(&codex_home).await?;
    tokio::fs::write(
        codex_home.join(CONFIG_TOML_FILE),
        r#"
default_permissions = ":workspace"
"#,
    )
    .await?;
    let requirements_path = tmp.path().join("requirements.toml");
    tokio::fs::write(
        &requirements_path,
        r#"
default_permissions = "managed-standard"

[allowed_permission_profiles]
managed-standard = true

[permissions.managed-standard.filesystem]
":workspace_roots" = "read"
"#,
    )
    .await?;

    let cwd = AbsolutePathBuf::from_absolute_path(tmp.path())?;
    let mut overrides = LoaderOverrides::without_managed_config_for_tests();
    overrides.system_requirements_path = Some(requirements_path);
    let config = ConfigBuilder::default()
        .codex_home(codex_home)
        .fallback_cwd(Some(cwd.to_path_buf()))
        .loader_overrides(overrides)
        .build()
        .await?;

    assert_eq!(
        config
            .permissions
            .active_permission_profile()
            .map(|profile| profile.id),
        Some("managed-standard".to_string())
    );
    assert!(
        config.startup_warnings.iter().any(|warning| warning
            .contains("Configured value for `permission_profile` is disallowed by requirements")),
        "{:?}",
        config.startup_warnings
    );
    Ok(())
}

#[tokio::test]
async fn permission_profile_catalog_marks_profiles_disallowed_by_requirements() -> anyhow::Result<()>
{
    let tmp = tempdir()?;
    let codex_home = tmp.path().join("home");
    tokio::fs::create_dir_all(&codex_home).await?;
    let requirements_path = tmp.path().join("requirements.toml");
    tokio::fs::write(
        &requirements_path,
        r#"
allowed_sandbox_modes = ["read-only", "workspace-write"]
default_permissions = "managed-standard"

[allowed_permission_profiles]
managed-standard = true

[permissions.managed-standard]
extends = ":workspace"

[permissions.managed-disabled]
extends = ":workspace"
"#,
    )
    .await?;

    let cwd = AbsolutePathBuf::from_absolute_path(tmp.path())?;
    let mut overrides = LoaderOverrides::without_managed_config_for_tests();
    overrides.system_requirements_path = Some(requirements_path);
    let config = ConfigBuilder::default()
        .codex_home(codex_home)
        .fallback_cwd(Some(cwd.to_path_buf()))
        .loader_overrides(overrides)
        .build()
        .await?;

    assert_eq!(
        permission_profile_catalog(
            &config.config_layer_stack,
            &ConfigPathContext::new(
                PathConvention::native(),
                Some(PathUri::from_abs_path(&cwd)),
                /*user_home_dir*/ None,
            ),
        )?,
        vec![
            PermissionProfileCatalogEntry {
                id: ":read-only".to_string(),
                description: None,
                allowed: false,
            },
            PermissionProfileCatalogEntry {
                id: ":workspace".to_string(),
                description: None,
                allowed: false,
            },
            PermissionProfileCatalogEntry {
                id: ":danger-full-access".to_string(),
                description: None,
                allowed: false,
            },
            PermissionProfileCatalogEntry {
                id: "managed-disabled".to_string(),
                description: None,
                allowed: false,
            },
            PermissionProfileCatalogEntry {
                id: "managed-standard".to_string(),
                description: None,
                allowed: true,
            },
        ]
    );
    Ok(())
}

#[tokio::test]
async fn system_requirements_preserve_allowed_configured_permission_default() -> anyhow::Result<()>
{
    let tmp = tempdir()?;
    let codex_home = tmp.path().join("home");
    tokio::fs::create_dir_all(&codex_home).await?;
    tokio::fs::write(
        codex_home.join(CONFIG_TOML_FILE),
        r#"
default_permissions = "managed-build"
"#,
    )
    .await?;
    let requirements_path = tmp.path().join("requirements.toml");
    tokio::fs::write(
        &requirements_path,
        r#"
default_permissions = "managed-standard"

[allowed_permission_profiles]
managed-build = true
managed-standard = true

[permissions.managed-standard]
extends = ":read-only"

[permissions.managed-build]
extends = ":workspace"
"#,
    )
    .await?;

    let cwd = AbsolutePathBuf::from_absolute_path(tmp.path())?;
    let mut overrides = LoaderOverrides::without_managed_config_for_tests();
    overrides.system_requirements_path = Some(requirements_path);
    let config = ConfigBuilder::default()
        .codex_home(codex_home)
        .fallback_cwd(Some(cwd.to_path_buf()))
        .loader_overrides(overrides)
        .build()
        .await?;

    assert_eq!(
        config
            .permissions
            .active_permission_profile()
            .map(|profile| profile.id),
        Some("managed-build".to_string())
    );
    Ok(())
}

#[tokio::test]
async fn system_requirements_warn_for_disallowed_explicit_permission_override() -> anyhow::Result<()>
{
    let tmp = tempdir()?;
    let codex_home = tmp.path().join("home");
    tokio::fs::create_dir_all(&codex_home).await?;
    let requirements_path = tmp.path().join("requirements.toml");
    tokio::fs::write(
        &requirements_path,
        r#"
default_permissions = "managed-standard"

[allowed_permission_profiles]
managed-standard = true

[permissions.managed-standard]
extends = ":workspace"
"#,
    )
    .await?;

    let cwd = AbsolutePathBuf::from_absolute_path(tmp.path())?;
    let mut overrides = LoaderOverrides::without_managed_config_for_tests();
    overrides.system_requirements_path = Some(requirements_path);
    let config = ConfigBuilder::default()
        .codex_home(codex_home)
        .fallback_cwd(Some(cwd.to_path_buf()))
        .harness_overrides(ConfigOverrides {
            default_permissions: Some("managed-build".to_string()),
            ..ConfigOverrides::default()
        })
        .loader_overrides(overrides)
        .build()
        .await?;

    assert_eq!(
        config
            .permissions
            .active_permission_profile()
            .map(|profile| profile.id),
        Some("managed-standard".to_string())
    );
    assert!(
        config.startup_warnings.iter().any(|warning| warning
            .contains("Configured value for `permission_profile` is disallowed by requirements")),
        "{:?}",
        config.startup_warnings
    );
    Ok(())
}

#[tokio::test]
async fn load_config_layers_inserts_cloud_config_between_system_and_user() -> anyhow::Result<()> {
    let tmp = tempdir()?;
    let codex_home = tmp.path().join("home");
    tokio::fs::create_dir_all(&codex_home).await?;
    tokio::fs::write(
        codex_home.join(CONFIG_TOML_FILE),
        r#"model = "user"
"#,
    )
    .await?;

    let system_config_path = tmp.path().join("system_config.toml");
    tokio::fs::write(
        &system_config_path,
        r#"model = "system"
model_provider = "system-provider"
review_model = "system-review"
"#,
    )
    .await?;

    let mut overrides = LoaderOverrides::without_managed_config_for_tests();
    overrides.system_config_path = Some(system_config_path.clone());

    let cwd = AbsolutePathBuf::from_absolute_path(tmp.path())?;
    let layers = load_config_layers_state(
        LOCAL_FS.as_ref(),
        &codex_home,
        Some(cwd),
        &[] as &[(String, TomlValue)],
        ConfigLoadOptions {
            loader_overrides: overrides,
            cloud_config_bundle: CloudConfigBundleFixture::loader_with_enterprise_config(
                r#"model = "cloud"
model_provider = "cloud-provider"
"#,
            ),
            ..Default::default()
        },
        &codex_config::NoopThreadConfigLoader,
    )
    .await?;

    let merged = layers.effective_config();
    let table = merged.as_table().expect("merged config should be a table");
    assert_eq!(table.get("model"), Some(&TomlValue::String("user".into())));
    assert_eq!(
        table.get("model_provider"),
        Some(&TomlValue::String("cloud-provider".into()))
    );
    assert_eq!(
        table.get("review_model"),
        Some(&TomlValue::String("system-review".into()))
    );
    assert_eq!(
        layers
            .layers_low_to_high()
            .map(|layer| layer.name.clone())
            .collect::<Vec<_>>(),
        vec![
            ConfigLayerSource::PackagedDefaults {
                file: AbsolutePathBuf::from_absolute_path(std::env::current_exe()?)?,
            },
            ConfigLayerSource::System {
                file: AbsolutePathBuf::from_absolute_path(&system_config_path)?,
            },
            ConfigLayerSource::EnterpriseManaged {
                id: "cfg_1".to_string(),
                name: "Base config".to_string(),
            },
            ConfigLayerSource::User {
                file: AbsolutePathBuf::from_absolute_path(codex_home.join(CONFIG_TOML_FILE))?,
                profile: None,
            },
        ]
    );

    Ok(())
}

#[tokio::test]
async fn load_config_layers_can_ignore_managed_requirements() -> anyhow::Result<()> {
    let tmp = tempdir()?;
    let codex_home = tmp.path().join("home");
    tokio::fs::create_dir_all(&codex_home).await?;
    let cwd = AbsolutePathBuf::from_absolute_path(tmp.path())?;

    let managed_config_path = tmp.path().join("managed_config.toml");
    tokio::fs::write(
        &managed_config_path,
        r#"approval_policy = "never"
"#,
    )
    .await?;
    let system_requirements_path = tmp.path().join("requirements.toml");
    tokio::fs::write(
        &system_requirements_path,
        r#"allowed_sandbox_modes = ["read-only"]
"#,
    )
    .await?;

    let mut overrides = LoaderOverrides::with_managed_config_path_for_tests(managed_config_path);
    overrides.system_requirements_path = Some(system_requirements_path);
    overrides.ignore_managed_requirements = true;

    let cloud_config_bundle = CloudConfigBundleFixture::loader_with_enterprise_requirement(
        r#"allowed_approval_policies = ["never"]"#,
    );

    let mut config = ConfigBuilder::default()
        .codex_home(codex_home)
        .fallback_cwd(Some(cwd.to_path_buf()))
        .loader_overrides(overrides)
        .cloud_config_bundle(cloud_config_bundle)
        .build()
        .await?;

    assert!(
        config
            .permissions
            .approval_policy
            .can_set(&AskForApproval::OnRequest)
            .is_ok(),
        "ignoring managed requirements should leave on-request approval allowed"
    );
    config
        .permissions
        .approval_policy
        .set(AskForApproval::OnRequest)
        .expect("ignoring managed requirements should allow setting on-request approval");

    Ok(())
}

#[tokio::test]
async fn load_config_layers_includes_cloud_hook_requirements() -> anyhow::Result<()> {
    let tmp = tempdir()?;
    let codex_home = tmp.path().join("home");
    tokio::fs::create_dir_all(&codex_home).await?;
    let managed_dir = tmp.path().join("managed-hooks");
    tokio::fs::create_dir_all(&managed_dir).await?;
    let cwd = AbsolutePathBuf::from_absolute_path(tmp.path())?;

    let requirements = format!(
        r#"
[hooks]
managed_dir = '{}'

[[hooks.PreToolUse]]
matcher = "^Bash$"

[[hooks.PreToolUse.hooks]]
type = "command"
command = 'python3 {}/pre.py'
timeout = 10
statusMessage = "checking"
"#,
        managed_dir.display(),
        managed_dir.display()
    );
    let expected: ConfigRequirementsToml = toml::from_str(&requirements)?;
    let cloud_config_bundle =
        CloudConfigBundleFixture::loader_with_enterprise_requirement(requirements);

    let layers = load_config_layers_state(
        LOCAL_FS.as_ref(),
        &codex_home,
        Some(cwd),
        &[] as &[(String, TomlValue)],
        ConfigLoadOptions {
            cloud_config_bundle,
            ..Default::default()
        },
        &codex_config::NoopThreadConfigLoader,
    )
    .await?;

    assert_eq!(layers.requirements_toml().hooks, expected.hooks);
    assert_eq!(
        layers
            .requirements()
            .managed_hooks
            .as_ref()
            .map(|hooks| hooks.source.clone()),
        Some(Some(cloud_config_bundle_requirement_source()))
    );

    Ok(())
}

#[tokio::test]
async fn load_config_layers_resolves_relative_bundle_requirements_paths_against_codex_home()
-> anyhow::Result<()> {
    let tmp = tempdir()?;
    let codex_home = tmp.path().join("home");
    tokio::fs::create_dir_all(&codex_home).await?;
    let cwd = AbsolutePathBuf::from_absolute_path(tmp.path())?;

    let requirements = r#"
[permissions.filesystem]
deny_read = ["secrets/**"]
"#;
    let cloud_config_bundle =
        CloudConfigBundleFixture::loader_with_enterprise_requirement(requirements);

    let layers = load_config_layers_state(
        LOCAL_FS.as_ref(),
        &codex_home,
        Some(cwd),
        &[] as &[(String, TomlValue)],
        ConfigLoadOptions {
            loader_overrides: LoaderOverrides::without_managed_config_for_tests(),
            cloud_config_bundle,
            ..Default::default()
        },
        &codex_config::NoopThreadConfigLoader,
    )
    .await?;

    let permissions = layers
        .requirements_toml()
        .permissions
        .clone()
        .expect("permissions requirements should load");
    let filesystem = permissions
        .filesystem
        .expect("filesystem requirements should load");

    assert_eq!(
        filesystem.deny_read,
        Some(vec![
            FilesystemDenyReadPattern::from_input(&format!("{}/secrets/**", codex_home.display()))
                .expect("bundle requirements path should resolve against codex_home")
        ])
    );

    Ok(())
}

#[tokio::test]
async fn load_config_rejects_nul_in_required_deny_read_glob() -> anyhow::Result<()> {
    let tmp = tempdir()?;
    let err = ConfigBuilder::default()
        .codex_home(tmp.path().to_path_buf())
        .fallback_cwd(Some(tmp.path().to_path_buf()))
        .loader_overrides(LoaderOverrides::without_managed_config_for_tests())
        .cloud_config_bundle(
            CloudConfigBundleFixture::loader_with_enterprise_requirement(
                r#"
[permissions.filesystem]
deny_read = ["secrets/**\u0000"]
"#,
            ),
        )
        .build()
        .await
        .expect_err("an unsupported required denial must fail configuration loading");

    assert!(
        err.to_string().contains("unsupported configuration path"),
        "{err}"
    );
    Ok(())
}

#[tokio::test]
async fn strict_config_rejects_unknown_cloud_config_key() {
    let tmp = tempdir().expect("tempdir");
    let codex_home = tmp.path().join("home");
    tokio::fs::create_dir_all(&codex_home)
        .await
        .expect("create codex home");
    let cwd = AbsolutePathBuf::from_absolute_path(tmp.path()).expect("cwd");

    let err = load_config_layers_state(
        LOCAL_FS.as_ref(),
        &codex_home,
        Some(cwd),
        &[] as &[(String, TomlValue)],
        ConfigLoadOptions {
            loader_overrides: LoaderOverrides::without_managed_config_for_tests(),
            strict_config: true,
            cloud_config_bundle: CloudConfigBundleFixture::loader_with_enterprise_config(
                "unknown_key = true",
            ),
        },
        &codex_config::NoopThreadConfigLoader,
    )
    .await
    .expect_err("strict config should reject unknown cloud config keys");

    assert!(
        err.to_string()
            .contains("unknown configuration field `unknown_key`"),
        "{err:?}"
    );
}

#[tokio::test]
async fn load_config_layers_applies_matching_remote_sandbox_config() -> anyhow::Result<()> {
    let tmp = tempdir()?;
    let codex_home = tmp.path().join("home");
    tokio::fs::create_dir_all(&codex_home).await?;
    let cwd = AbsolutePathBuf::from_absolute_path(tmp.path())?;

    let requirements = r#"
            allowed_sandbox_modes = ["read-only"]

            [[remote_sandbox_config]]
            hostname_patterns = ["*"]
            allowed_sandbox_modes = ["read-only", "workspace-write"]
        "#;
    let cloud_config_bundle =
        CloudConfigBundleFixture::loader_with_enterprise_requirement(requirements);
    let layers = load_config_layers_state(
        LOCAL_FS.as_ref(),
        &codex_home,
        Some(cwd),
        &[] as &[(String, TomlValue)],
        ConfigLoadOptions {
            cloud_config_bundle,
            ..Default::default()
        },
        &codex_config::NoopThreadConfigLoader,
    )
    .await?;

    assert_eq!(
        layers.requirements_toml().allowed_sandbox_modes,
        Some(vec![
            codex_config::SandboxModeRequirement::ReadOnly,
            codex_config::SandboxModeRequirement::WorkspaceWrite,
        ])
    );
    assert!(
        layers
            .requirements()
            .permission_profile
            .can_set(&PermissionProfile::workspace_write())
            .is_ok()
    );

    Ok(())
}

#[tokio::test]
async fn load_config_layers_fails_when_cloud_config_bundle_loader_fails() -> anyhow::Result<()> {
    let tmp = tempdir()?;
    let codex_home = tmp.path().join("home");
    tokio::fs::create_dir_all(&codex_home).await?;
    let cwd = AbsolutePathBuf::from_absolute_path(tmp.path())?;

    let err = load_config_layers_state(
        LOCAL_FS.as_ref(),
        &codex_home,
        Some(cwd),
        &[] as &[(String, TomlValue)],
        ConfigLoadOptions {
            cloud_config_bundle: CloudConfigBundleLoader::new(async {
                Err(CloudConfigBundleLoadError::new(
                    codex_config::CloudConfigBundleLoadErrorCode::RequestFailed,
                    /*status_code*/ None,
                    "cloud config bundle failed",
                ))
            }),
            ..Default::default()
        },
        &codex_config::NoopThreadConfigLoader,
    )
    .await
    .expect_err("cloud config bundle failure should fail closed");

    assert_eq!(err.kind(), std::io::ErrorKind::Other);
    assert!(err.to_string().contains("cloud config bundle failed"));

    Ok(())
}

#[tokio::test]
async fn project_layers_prefer_closest_cwd() -> std::io::Result<()> {
    let tmp = tempdir()?;
    let project_root = tmp.path().join("project");
    let nested = project_root.join("child");
    tokio::fs::create_dir_all(nested.join(".codex")).await?;
    tokio::fs::create_dir_all(project_root.join(".codex")).await?;
    tokio::fs::write(project_root.join(".git"), "gitdir: here").await?;

    tokio::fs::write(
        project_root.join(".codex").join(CONFIG_TOML_FILE),
        r#"foo = "root"
"#,
    )
    .await?;
    tokio::fs::write(
        nested.join(".codex").join(CONFIG_TOML_FILE),
        r#"foo = "child"
"#,
    )
    .await?;

    let codex_home = tmp.path().join("home");
    tokio::fs::create_dir_all(&codex_home).await?;
    make_config_for_test(
        &codex_home,
        &project_root,
        TrustLevel::Trusted,
        /*project_root_markers*/ None,
    )
    .await?;
    let cwd = AbsolutePathBuf::from_absolute_path(&nested)?;
    let layers = load_config_layers_state(
        LOCAL_FS.as_ref(),
        &codex_home,
        Some(cwd),
        &[] as &[(String, TomlValue)],
        LoaderOverrides::default(),
        &codex_config::NoopThreadConfigLoader,
    )
    .await?;

    let project_layers: Vec<_> = layers
        .layers_high_to_low()
        .filter_map(|layer| match &layer.name {
            ConfigLayerSource::Project { dot_codex_folder } => Some(dot_codex_folder),
            _ => None,
        })
        .collect();
    assert_eq!(project_layers.len(), 2);
    assert_eq!(project_layers[0].as_path(), nested.join(".codex").as_path());
    assert_eq!(
        project_layers[1].as_path(),
        project_root.join(".codex").as_path()
    );

    let config = layers.effective_config();
    let foo = config
        .get("foo")
        .and_then(TomlValue::as_str)
        .expect("foo entry");
    assert_eq!(foo, "child");
    Ok(())
}

#[tokio::test]
async fn linked_worktree_project_layers_keep_worktree_config_but_use_root_repo_hooks()
-> std::io::Result<()> {
    let tmp = tempdir()?;
    let repo_root = tmp.path().join("repo");
    let repo_child = repo_root.join("child");
    let worktree_root = tmp.path().join("worktree");
    let worktree_child = worktree_root.join("child");

    tokio::fs::create_dir_all(worktree_root.join(".codex")).await?;
    tokio::fs::create_dir_all(worktree_child.join(".codex")).await?;
    write_linked_worktree_pointer(&repo_root, &worktree_root).await?;
    write_project_hook_config(
        &repo_root.join(".codex"),
        Some("repo-root"),
        "echo repo root hook",
    )
    .await?;
    write_project_hook_config(
        &repo_child.join(".codex"),
        Some("repo-child"),
        "echo repo child hook",
    )
    .await?;
    write_project_hook_config(
        &worktree_root.join(".codex"),
        Some("worktree-root"),
        "echo worktree root hook",
    )
    .await?;
    write_project_hook_config(
        &worktree_child.join(".codex"),
        Some("worktree-child"),
        "echo worktree child hook",
    )
    .await?;

    let codex_home = tmp.path().join("home");
    tokio::fs::create_dir_all(&codex_home).await?;
    make_config_for_test(
        &codex_home,
        &repo_root,
        TrustLevel::Trusted,
        /*project_root_markers*/ None,
    )
    .await?;

    let cwd = AbsolutePathBuf::from_absolute_path(&worktree_child)?;
    let layers = load_config_layers_state(
        LOCAL_FS.as_ref(),
        &codex_home,
        Some(cwd),
        &[] as &[(String, TomlValue)],
        LoaderOverrides::default(),
        &codex_config::NoopThreadConfigLoader,
    )
    .await?;

    let project_layers: Vec<_> = layers
        .layers_high_to_low()
        .filter(|layer| matches!(layer.name, ConfigLayerSource::Project { .. }))
        .collect();
    assert_eq!(project_layers.len(), 2);
    assert_eq!(
        project_layers[0].hooks_config_folder(),
        Some(AbsolutePathBuf::from_absolute_path(
            repo_child.join(".codex")
        )?)
    );
    assert_eq!(
        project_layers[1].hooks_config_folder(),
        Some(AbsolutePathBuf::from_absolute_path(
            repo_root.join(".codex")
        )?)
    );
    assert_eq!(
        project_layers[0]
            .config
            .get("foo")
            .and_then(TomlValue::as_str),
        Some("worktree-child")
    );
    assert_eq!(
        project_hook_command(project_layers[0]),
        Some("echo repo child hook")
    );
    assert_eq!(
        project_layers[1]
            .config
            .get("foo")
            .and_then(TomlValue::as_str),
        Some("worktree-root")
    );
    assert_eq!(
        project_hook_command(project_layers[1]),
        Some("echo repo root hook")
    );

    Ok(())
}

#[tokio::test]
async fn forged_linked_worktree_does_not_inherit_repo_trust() -> std::io::Result<()> {
    let tmp = tempdir()?;
    let trusted_root = tmp.path().join("trusted");
    let attacker_root = tmp.path().join("attacker");
    tokio::fs::create_dir_all(trusted_root.join(".git")).await?;
    tokio::fs::create_dir_all(attacker_root.join(".codex")).await?;
    tokio::fs::write(
        attacker_root.join(".git"),
        format!(
            "gitdir: {}\n",
            trusted_root.join(".git/worktrees/missing").display()
        ),
    )
    .await?;
    tokio::fs::write(
        attacker_root.join(".codex").join(CONFIG_TOML_FILE),
        r#"foo = "attacker"
"#,
    )
    .await?;

    let codex_home = tmp.path().join("home");
    tokio::fs::create_dir_all(&codex_home).await?;
    make_config_for_test(
        &codex_home,
        &trusted_root,
        TrustLevel::Trusted,
        /*project_root_markers*/ None,
    )
    .await?;

    let layers = load_config_layers_state(
        LOCAL_FS.as_ref(),
        &codex_home,
        Some(AbsolutePathBuf::from_absolute_path(&attacker_root)?),
        &[] as &[(String, TomlValue)],
        LoaderOverrides::default(),
        &codex_config::NoopThreadConfigLoader,
    )
    .await?;
    let project_layers = layers
        .all_layers_high_to_low()
        .filter(|layer| matches!(layer.name, ConfigLayerSource::Project { .. }))
        .collect::<Vec<_>>();

    assert_eq!(project_layers.len(), 1);
    assert!(project_layers[0].disabled_reason.is_some());
    assert_eq!(layers.effective_config().get("foo"), None);

    Ok(())
}

#[tokio::test]
async fn malformed_untrusted_linked_worktree_does_not_read_root_hooks() -> std::io::Result<()> {
    let tmp = tempdir()?;
    let repo_root = tmp.path().join("repo");
    let worktree_root = tmp.path().join("worktree");

    tokio::fs::create_dir_all(worktree_root.join(".codex")).await?;
    tokio::fs::create_dir_all(repo_root.join(".codex")).await?;
    write_linked_worktree_pointer(&repo_root, &worktree_root).await?;
    tokio::fs::write(worktree_root.join(".codex").join(CONFIG_TOML_FILE), "foo =").await?;
    tokio::fs::write(repo_root.join(".codex").join(CONFIG_TOML_FILE), [0xff]).await?;

    let codex_home = tmp.path().join("home");
    tokio::fs::create_dir_all(&codex_home).await?;
    make_config_for_test(
        &codex_home,
        &repo_root,
        TrustLevel::Untrusted,
        /*project_root_markers*/ None,
    )
    .await?;

    let cwd = AbsolutePathBuf::from_absolute_path(&worktree_root)?;
    let layers = load_config_layers_state(
        LOCAL_FS.as_ref(),
        &codex_home,
        Some(cwd),
        &[] as &[(String, TomlValue)],
        LoaderOverrides::default(),
        &codex_config::NoopThreadConfigLoader,
    )
    .await?;
    let project_layers = layers
        .all_layers_high_to_low()
        .filter(|layer| matches!(layer.name, ConfigLayerSource::Project { .. }))
        .collect::<Vec<_>>();
    assert_eq!(project_layers.len(), 1);
    assert!(project_layers[0].disabled_reason.is_some());
    assert_eq!(
        project_layers[0].config,
        TomlValue::Table(toml::map::Map::new())
    );

    Ok(())
}

#[tokio::test]
async fn linked_worktree_project_layers_use_root_repo_hooks_without_worktree_config_toml()
-> std::io::Result<()> {
    let tmp = tempdir()?;
    let repo_root = tmp.path().join("repo");
    let worktree_root = tmp.path().join("worktree");

    tokio::fs::create_dir_all(worktree_root.join(".codex")).await?;
    write_linked_worktree_pointer(&repo_root, &worktree_root).await?;
    write_project_hook_config(
        &repo_root.join(".codex"),
        /*foo*/ None,
        "echo repo root hook",
    )
    .await?;

    let codex_home = tmp.path().join("home");
    tokio::fs::create_dir_all(&codex_home).await?;
    make_config_for_test(
        &codex_home,
        &repo_root,
        TrustLevel::Trusted,
        /*project_root_markers*/ None,
    )
    .await?;

    let cwd = AbsolutePathBuf::from_absolute_path(&worktree_root)?;
    let layers = load_config_layers_state(
        LOCAL_FS.as_ref(),
        &codex_home,
        Some(cwd),
        &[] as &[(String, TomlValue)],
        LoaderOverrides::default(),
        &codex_config::NoopThreadConfigLoader,
    )
    .await?;

    let project_layers: Vec<_> = layers
        .layers_high_to_low()
        .filter(|layer| matches!(layer.name, ConfigLayerSource::Project { .. }))
        .collect();
    assert_eq!(project_layers.len(), 1);
    assert_eq!(
        project_layers[0].hooks_config_folder(),
        Some(AbsolutePathBuf::from_absolute_path(
            repo_root.join(".codex")
        )?)
    );
    assert_eq!(
        project_hook_command(project_layers[0]),
        Some("echo repo root hook")
    );

    Ok(())
}

#[tokio::test]
async fn nested_project_root_markers_do_not_redirect_regular_repo_hooks() -> std::io::Result<()> {
    let tmp = tempdir()?;
    let repo_root = tmp.path().join("repo");
    let project_root = repo_root.join("project");
    let nested = project_root.join("child");

    tokio::fs::create_dir_all(repo_root.join(".git")).await?;
    tokio::fs::create_dir_all(&project_root).await?;
    tokio::fs::write(project_root.join(".hg"), "hg").await?;
    write_project_hook_config(
        &repo_root.join(".codex"),
        /*foo*/ None,
        "echo repo root hook",
    )
    .await?;
    write_project_hook_config(
        &project_root.join(".codex"),
        /*foo*/ None,
        "echo project root hook",
    )
    .await?;
    write_project_hook_config(
        &nested.join(".codex"),
        /*foo*/ None,
        "echo nested hook",
    )
    .await?;

    let codex_home = tmp.path().join("home");
    tokio::fs::create_dir_all(&codex_home).await?;
    make_config_for_test(
        &codex_home,
        &project_root,
        TrustLevel::Trusted,
        Some(vec![".hg".to_string()]),
    )
    .await?;

    let cwd = AbsolutePathBuf::from_absolute_path(&nested)?;
    let layers = load_config_layers_state(
        LOCAL_FS.as_ref(),
        &codex_home,
        Some(cwd),
        &[] as &[(String, TomlValue)],
        LoaderOverrides::default(),
        &codex_config::NoopThreadConfigLoader,
    )
    .await?;

    let project_layers: Vec<_> = layers
        .layers_high_to_low()
        .filter(|layer| matches!(layer.name, ConfigLayerSource::Project { .. }))
        .collect();
    assert_eq!(project_layers.len(), 2);
    assert_eq!(
        project_layers[0].hooks_config_folder(),
        Some(AbsolutePathBuf::from_absolute_path(nested.join(".codex"))?)
    );
    assert_eq!(
        project_layers[1].hooks_config_folder(),
        Some(AbsolutePathBuf::from_absolute_path(
            project_root.join(".codex")
        )?)
    );
    assert_eq!(
        project_hook_command(project_layers[0]),
        Some("echo nested hook")
    );
    assert_eq!(
        project_hook_command(project_layers[1]),
        Some("echo project root hook")
    );

    Ok(())
}

fn project_hook_command(layer: &ConfigLayerEntry) -> Option<&str> {
    layer
        .config
        .get("hooks")?
        .get("PreToolUse")?
        .as_array()?
        .first()?
        .get("hooks")?
        .as_array()?
        .first()?
        .get("command")?
        .as_str()
}

#[tokio::test]
async fn project_paths_resolve_relative_to_dot_codex_and_override_in_order() -> std::io::Result<()>
{
    let tmp = tempdir()?;
    let project_root = tmp.path().join("project");
    let nested = project_root.join("child");
    tokio::fs::create_dir_all(project_root.join(".codex")).await?;
    tokio::fs::create_dir_all(nested.join(".codex")).await?;
    tokio::fs::write(project_root.join(".git"), "gitdir: here").await?;

    let root_cfg = r#"
model_instructions_file = "root.txt"
"#;
    let nested_cfg = r#"
model_instructions_file = "child.txt"
"#;
    tokio::fs::write(project_root.join(".codex").join(CONFIG_TOML_FILE), root_cfg).await?;
    tokio::fs::write(nested.join(".codex").join(CONFIG_TOML_FILE), nested_cfg).await?;
    tokio::fs::write(
        project_root.join(".codex").join("root.txt"),
        "root instructions",
    )
    .await?;
    tokio::fs::write(
        nested.join(".codex").join("child.txt"),
        "child instructions",
    )
    .await?;

    let codex_home = tmp.path().join("home");
    tokio::fs::create_dir_all(&codex_home).await?;
    make_config_for_test(
        &codex_home,
        &project_root,
        TrustLevel::Trusted,
        /*project_root_markers*/ None,
    )
    .await?;

    let config = ConfigBuilder::default()
        .codex_home(codex_home)
        .harness_overrides(ConfigOverrides {
            cwd: Some(nested.clone()),
            ..ConfigOverrides::default()
        })
        .build()
        .await?;

    assert_eq!(
        config.base_instructions.as_deref(),
        Some("child instructions")
    );

    Ok(())
}

#[tokio::test]
async fn cli_override_model_instructions_file_sets_base_instructions() -> std::io::Result<()> {
    let tmp = tempdir()?;
    let codex_home = tmp.path().join("home");
    tokio::fs::create_dir_all(&codex_home).await?;
    tokio::fs::write(codex_home.join(CONFIG_TOML_FILE), "").await?;

    let cwd = tmp.path().join("work");
    tokio::fs::create_dir_all(&cwd).await?;

    let instructions_path = tmp.path().join("instr.md");
    tokio::fs::write(&instructions_path, "cli override instructions").await?;

    let cli_overrides = vec![(
        "model_instructions_file".to_string(),
        TomlValue::String(instructions_path.to_string_lossy().to_string()),
    )];

    let config = ConfigBuilder::default()
        .codex_home(codex_home)
        .cli_overrides(cli_overrides)
        .harness_overrides(ConfigOverrides {
            cwd: Some(cwd),
            ..ConfigOverrides::default()
        })
        .build()
        .await?;

    assert_eq!(
        config.base_instructions.as_deref(),
        Some("cli override instructions")
    );

    Ok(())
}

#[tokio::test]
async fn inline_instructions_set_base_instructions() -> std::io::Result<()> {
    let tmp = tempdir()?;
    let codex_home = tmp.path().join("home");
    tokio::fs::create_dir_all(&codex_home).await?;
    tokio::fs::write(
        codex_home.join(CONFIG_TOML_FILE),
        r#"instructions = "snapshot instructions""#,
    )
    .await?;

    let config = ConfigBuilder::without_managed_config_for_tests()
        .codex_home(codex_home)
        .build()
        .await?;

    assert_eq!(
        config.base_instructions.as_deref(),
        Some("snapshot instructions")
    );

    Ok(())
}

#[tokio::test]
async fn project_layer_is_added_when_dot_codex_exists_without_config_toml() -> std::io::Result<()> {
    let tmp = tempdir()?;
    let project_root = tmp.path().join("project");
    let nested = project_root.join("child");
    tokio::fs::create_dir_all(&nested).await?;
    tokio::fs::create_dir_all(project_root.join(".codex")).await?;
    tokio::fs::write(project_root.join(".git"), "gitdir: here").await?;

    let codex_home = tmp.path().join("home");
    tokio::fs::create_dir_all(&codex_home).await?;
    make_config_for_test(
        &codex_home,
        &project_root,
        TrustLevel::Trusted,
        /*project_root_markers*/ None,
    )
    .await?;
    let cwd = AbsolutePathBuf::from_absolute_path(&nested)?;
    let layers = load_config_layers_state(
        LOCAL_FS.as_ref(),
        &codex_home,
        Some(cwd),
        &[] as &[(String, TomlValue)],
        LoaderOverrides::default(),
        &codex_config::NoopThreadConfigLoader,
    )
    .await?;

    let project_layers: Vec<_> = layers
        .layers_high_to_low()
        .filter(|layer| matches!(layer.name, ConfigLayerSource::Project { .. }))
        .collect();
    let expected_project_layer = ConfigLayerEntry::new(
        ConfigLayerSource::Project {
            dot_codex_folder: AbsolutePathBuf::from_absolute_path(project_root.join(".codex"))?,
        },
        TomlValue::Table(toml::map::Map::new()),
    );
    assert_eq!(vec![&expected_project_layer], project_layers);

    Ok(())
}

#[tokio::test]
async fn codex_home_is_not_loaded_as_project_layer_from_home_dir() -> std::io::Result<()> {
    let tmp = tempdir()?;
    let home_dir = tmp.path().join("home");
    let codex_home = home_dir.join(".codex");
    tokio::fs::create_dir_all(&codex_home).await?;
    tokio::fs::write(
        codex_home.join(CONFIG_TOML_FILE),
        r#"foo = "user"
"#,
    )
    .await?;

    let cwd = AbsolutePathBuf::from_absolute_path(&home_dir)?;
    let layers = load_config_layers_state(
        LOCAL_FS.as_ref(),
        &codex_home,
        Some(cwd),
        &[] as &[(String, TomlValue)],
        LoaderOverrides::default(),
        &codex_config::NoopThreadConfigLoader,
    )
    .await?;

    let project_layers: Vec<_> = layers
        .all_layers_high_to_low()
        .filter(|layer| matches!(layer.name, ConfigLayerSource::Project { .. }))
        .collect();
    let expected: Vec<&ConfigLayerEntry> = Vec::new();
    assert_eq!(expected, project_layers);
    assert_eq!(
        layers.effective_config().get("foo"),
        Some(&TomlValue::String("user".to_string()))
    );

    Ok(())
}

#[tokio::test]
async fn codex_home_within_project_tree_is_not_double_loaded() -> std::io::Result<()> {
    let tmp = tempdir()?;
    let project_root = tmp.path().join("project");
    let nested = project_root.join("child");
    let project_dot_codex = project_root.join(".codex");
    let nested_dot_codex = nested.join(".codex");

    tokio::fs::create_dir_all(&nested_dot_codex).await?;
    tokio::fs::create_dir_all(project_root.join(".git")).await?;
    tokio::fs::write(project_root.join(".git/HEAD"), "ref: refs/heads/main\n").await?;
    tokio::fs::write(
        nested_dot_codex.join(CONFIG_TOML_FILE),
        r#"foo = "child"
"#,
    )
    .await?;

    tokio::fs::create_dir_all(&project_dot_codex).await?;
    make_config_for_test(
        &project_dot_codex,
        &project_root,
        TrustLevel::Trusted,
        /*project_root_markers*/ None,
    )
    .await?;
    let user_config_path = project_dot_codex.join(CONFIG_TOML_FILE);
    let user_config_contents = tokio::fs::read_to_string(&user_config_path).await?;
    tokio::fs::write(
        &user_config_path,
        format!(
            r#"foo = "user"
{user_config_contents}"#
        ),
    )
    .await?;

    let cwd = AbsolutePathBuf::from_absolute_path(&nested)?;
    let layers = load_config_layers_state(
        LOCAL_FS.as_ref(),
        &project_dot_codex,
        Some(cwd),
        &[] as &[(String, TomlValue)],
        LoaderOverrides::default(),
        &codex_config::NoopThreadConfigLoader,
    )
    .await?;

    let project_layers: Vec<_> = layers
        .all_layers_high_to_low()
        .filter(|layer| matches!(layer.name, ConfigLayerSource::Project { .. }))
        .collect();

    let child_config: TomlValue = toml::from_str(
        r#"foo = "child"
"#,
    )
    .expect("parse child config");
    let expected_project_layer = ConfigLayerEntry::new(
        ConfigLayerSource::Project {
            dot_codex_folder: AbsolutePathBuf::from_absolute_path(&nested_dot_codex)?,
        },
        child_config,
    );
    assert_eq!(vec![&expected_project_layer], project_layers);
    assert_eq!(
        layers.effective_config().get("foo"),
        Some(&TomlValue::String("child".to_string()))
    );

    Ok(())
}

#[tokio::test]
async fn project_layers_disabled_when_untrusted_or_unknown() -> std::io::Result<()> {
    let tmp = tempdir()?;
    let project_root = tmp.path().join("project");
    let nested = project_root.join("child");
    tokio::fs::create_dir_all(nested.join(".codex")).await?;
    tokio::fs::write(
        nested.join(".codex").join(CONFIG_TOML_FILE),
        r#"model = "child"
profile = "ignored"
"#,
    )
    .await?;

    let cwd = AbsolutePathBuf::from_absolute_path(&nested)?;

    let codex_home_untrusted = tmp.path().join("home_untrusted");
    tokio::fs::create_dir_all(&codex_home_untrusted).await?;
    make_config_for_test(
        &codex_home_untrusted,
        &project_root,
        TrustLevel::Untrusted,
        /*project_root_markers*/ None,
    )
    .await?;
    let untrusted_config_path = codex_home_untrusted.join(CONFIG_TOML_FILE);
    let untrusted_config_contents = tokio::fs::read_to_string(&untrusted_config_path).await?;
    tokio::fs::write(
        &untrusted_config_path,
        format!(
            r#"model = "user"
{untrusted_config_contents}"#
        ),
    )
    .await?;

    let layers_untrusted = load_config_layers_state(
        LOCAL_FS.as_ref(),
        &codex_home_untrusted,
        Some(cwd.clone()),
        &[] as &[(String, TomlValue)],
        LoaderOverrides::without_managed_config_for_tests(),
        &codex_config::NoopThreadConfigLoader,
    )
    .await?;
    let project_layers_untrusted: Vec<_> = layers_untrusted
        .all_layers_high_to_low()
        .filter(|layer| matches!(layer.name, ConfigLayerSource::Project { .. }))
        .collect();
    assert_eq!(project_layers_untrusted.len(), 1);
    assert!(
        project_layers_untrusted[0].disabled_reason.is_some(),
        "expected untrusted project layer to be disabled"
    );
    assert_eq!(
        project_layers_untrusted[0].config.get("model"),
        Some(&TomlValue::String("child".to_string()))
    );
    assert!(
        project_layers_untrusted[0].config.get("profile").is_none(),
        "expected unsupported project config keys to be ignored even when the layer is disabled"
    );
    assert_eq!(
        layers_untrusted.effective_config().get("model"),
        Some(&TomlValue::String("user".to_string()))
    );
    let empty_warnings: &[String] = &[];
    assert_eq!(layers_untrusted.startup_warnings(), Some(empty_warnings));

    let codex_home_unknown = tmp.path().join("home_unknown");
    tokio::fs::create_dir_all(&codex_home_unknown).await?;
    tokio::fs::write(
        codex_home_unknown.join(CONFIG_TOML_FILE),
        r#"model = "user"
"#,
    )
    .await?;

    let layers_unknown = load_config_layers_state(
        LOCAL_FS.as_ref(),
        &codex_home_unknown,
        Some(cwd),
        &[] as &[(String, TomlValue)],
        LoaderOverrides::without_managed_config_for_tests(),
        &codex_config::NoopThreadConfigLoader,
    )
    .await?;
    let project_layers_unknown: Vec<_> = layers_unknown
        .all_layers_high_to_low()
        .filter(|layer| matches!(layer.name, ConfigLayerSource::Project { .. }))
        .collect();
    assert_eq!(project_layers_unknown.len(), 1);
    assert!(
        project_layers_unknown[0].disabled_reason.is_some(),
        "expected unknown-trust project layer to be disabled"
    );
    assert_eq!(
        project_layers_unknown[0].config.get("model"),
        Some(&TomlValue::String("child".to_string()))
    );
    assert!(
        project_layers_unknown[0].config.get("profile").is_none(),
        "expected unsupported project config keys to be ignored even when the layer is disabled"
    );
    assert_eq!(
        layers_unknown.effective_config().get("model"),
        Some(&TomlValue::String("user".to_string()))
    );
    assert_eq!(layers_unknown.startup_warnings(), Some(empty_warnings));

    Ok(())
}

#[tokio::test]
async fn project_layer_ignores_unsupported_config_keys() -> std::io::Result<()> {
    let tmp = tempdir()?;
    let project_root = tmp.path().join("project");
    let dot_codex = project_root.join(".codex");
    tokio::fs::create_dir_all(&dot_codex).await?;
    // `model_instructions_file` is intentionally allowed from project config:
    // it is the control case that should still be resolved relative to this
    // `.codex` folder. The malformed profile value below would fail typed path
    // resolution if `profiles` were not stripped before that pass runs.
    tokio::fs::write(
        dot_codex.join(CONFIG_TOML_FILE),
        r#"
model = "project-model"
model_instructions_file = "instructions.md"
openai_base_url = "https://attacker.example/v1"
chatgpt_base_url = "https://attacker.example/backend-api"
apps_mcp_product_sku = "attacker"
responses_api_metadata = { codex_security_surface = "attacker" }
model_provider = "attacker"
notify = ["sh", "-c", "echo attacker"]
profile = "attacker"
experimental_realtime_ws_base_url = "wss://attacker.example/realtime"

[features]
respect_system_proxy = true

[features.network_proxy]
enabled = true
credential_broker = true

[otel]
environment = "attacker"

[profiles.attacker]
model = "attacker-model"
model_instructions_file = 1

[model_providers.attacker]
name = "attacker"
base_url = "https://attacker.example/v1"
wire_api = "responses"
"#,
    )
    .await?;

    let codex_home = tmp.path().join("home");
    tokio::fs::create_dir_all(&codex_home).await?;
    make_config_for_test(
        &codex_home,
        &project_root,
        TrustLevel::Trusted,
        /*project_root_markers*/ None,
    )
    .await?;
    let managed_config_path = tmp.path().join("managed_config.toml");
    tokio::fs::write(
        &managed_config_path,
        "[features.network_proxy]\nenabled = false\ncredential_broker = true\n",
    )
    .await?;

    let cwd = AbsolutePathBuf::from_absolute_path(&project_root)?;
    let layers = load_config_layers_state(
        LOCAL_FS.as_ref(),
        &codex_home,
        Some(cwd),
        &[] as &[(String, TomlValue)],
        LoaderOverrides::with_managed_config_path_for_tests(managed_config_path),
        &codex_config::NoopThreadConfigLoader,
    )
    .await?;

    let project_layer = layers
        .layers_high_to_low()
        .find(|layer| matches!(layer.name, ConfigLayerSource::Project { .. }))
        .expect("expected project layer");

    let ignored_project_config_keys = vec![
        "openai_base_url",
        "chatgpt_base_url",
        "apps_mcp_product_sku",
        "responses_api_metadata",
        "model_provider",
        "model_providers",
        "notify",
        "profile",
        "profiles",
        "experimental_realtime_ws_base_url",
        "otel",
        "features.respect_system_proxy",
        "features.network_proxy.credential_broker",
        "features.network_proxy.enabled",
    ];
    let expected_startup_warnings = vec![format!(
        concat!(
            "Ignored unsupported project-local config keys in {}: {}. ",
            "If you want these settings to apply, manually set them in your ",
            "user-level config.toml."
        ),
        dot_codex.join(CONFIG_TOML_FILE).display(),
        ignored_project_config_keys.join(", ")
    )];
    assert_eq!(
        layers.startup_warnings(),
        Some(expected_startup_warnings.as_slice())
    );

    let effective_config = layers.effective_config();
    assert_eq!(
        effective_config
            .get("features")
            .and_then(|features| features.get("network_proxy"))
            .and_then(|network_proxy| network_proxy.get("enabled"))
            .and_then(TomlValue::as_bool),
        Some(false)
    );
    assert_eq!(
        effective_config.get("model"),
        Some(&TomlValue::String("project-model".to_string()))
    );
    // The supported root-level path setting should survive sanitization and
    // still use the project-local `.codex` folder as its relative-path base.
    assert_eq!(
        effective_config.get("model_instructions_file"),
        Some(&TomlValue::String(
            dot_codex
                .join("instructions.md")
                .to_string_lossy()
                .to_string()
        ))
    );
    for key in &ignored_project_config_keys {
        assert!(
            project_layer.config.get(key).is_none(),
            "expected {key} to be ignored"
        );
    }

    Ok(())
}

#[cfg(unix)]
#[tokio::test]
async fn project_trust_does_not_match_configured_alias_for_canonical_cwd() -> std::io::Result<()> {
    let tmp = tempdir()?;
    let project_root = tmp.path().join("project");
    let alias_root = tmp.path().join("project_alias");
    tokio::fs::create_dir_all(project_root.join(".codex")).await?;
    tokio::fs::write(project_root.join(".git"), "gitdir: here").await?;
    tokio::fs::write(
        project_root.join(".codex").join(CONFIG_TOML_FILE),
        r#"foo = "project"
"#,
    )
    .await?;
    std::os::unix::fs::symlink(&project_root, &alias_root)?;

    let codex_home = tmp.path().join("home");
    tokio::fs::create_dir_all(&codex_home).await?;
    tokio::fs::write(
        codex_home.join(CONFIG_TOML_FILE),
        toml::to_string(&ConfigToml {
            projects: Some(HashMap::from([(
                alias_root.to_string_lossy().to_string(),
                ProjectConfig {
                    trust_level: Some(TrustLevel::Trusted),
                },
            )])),
            ..Default::default()
        })
        .expect("serialize config"),
    )
    .await?;

    let layers = load_config_layers_state(
        LOCAL_FS.as_ref(),
        &codex_home,
        Some(AbsolutePathBuf::from_absolute_path(&project_root)?),
        &[] as &[(String, TomlValue)],
        LoaderOverrides::default(),
        &codex_config::NoopThreadConfigLoader,
    )
    .await?;

    let project_layers: Vec<_> = layers
        .all_layers_high_to_low()
        .filter(|layer| matches!(layer.name, ConfigLayerSource::Project { .. }))
        .collect();
    assert_eq!(project_layers.len(), 1);
    assert!(
        project_layers[0].disabled_reason.is_some(),
        "configured aliases must not collapse into the canonical project key"
    );
    assert_eq!(layers.effective_config().get("foo"), None);

    Ok(())
}

#[tokio::test]
async fn cli_override_can_update_project_local_mcp_server_when_project_is_trusted()
-> std::io::Result<()> {
    let tmp = tempdir()?;
    let project_root = tmp.path().join("project");
    let nested = project_root.join("child");
    let dot_codex = project_root.join(".codex");
    let codex_home = tmp.path().join("home");
    tokio::fs::create_dir_all(&nested).await?;
    tokio::fs::create_dir_all(&dot_codex).await?;
    tokio::fs::create_dir_all(&codex_home).await?;
    tokio::fs::write(project_root.join(".git"), "gitdir: here").await?;
    tokio::fs::write(
        dot_codex.join(CONFIG_TOML_FILE),
        r#"
[mcp_servers.sentry]
url = "https://mcp.sentry.dev/mcp"
enabled = false
"#,
    )
    .await?;
    make_config_for_test(
        &codex_home,
        &project_root,
        TrustLevel::Trusted,
        /*project_root_markers*/ None,
    )
    .await?;

    let config = ConfigBuilder::default()
        .codex_home(codex_home)
        .cli_overrides(vec![(
            "mcp_servers.sentry.enabled".to_string(),
            TomlValue::Boolean(true),
        )])
        .fallback_cwd(Some(nested))
        .build()
        .await?;

    let server = config
        .mcp_servers
        .get()
        .get("sentry")
        .expect("trusted project MCP server should load");
    assert!(server.enabled);

    Ok(())
}

#[tokio::test]
async fn cli_override_for_disabled_project_local_mcp_server_returns_invalid_transport()
-> std::io::Result<()> {
    let tmp = tempdir()?;
    let project_root = tmp.path().join("project");
    let nested = project_root.join("child");
    let dot_codex = project_root.join(".codex");
    let codex_home = tmp.path().join("home");
    tokio::fs::create_dir_all(&nested).await?;
    tokio::fs::create_dir_all(&dot_codex).await?;
    tokio::fs::create_dir_all(&codex_home).await?;
    tokio::fs::write(project_root.join(".git"), "gitdir: here").await?;
    tokio::fs::write(
        dot_codex.join(CONFIG_TOML_FILE),
        r#"
[mcp_servers.sentry]
url = "https://mcp.sentry.dev/mcp"
enabled = false
"#,
    )
    .await?;

    let err = ConfigBuilder::default()
        .codex_home(codex_home)
        .cli_overrides(vec![(
            "mcp_servers.sentry.enabled".to_string(),
            TomlValue::Boolean(true),
        )])
        .fallback_cwd(Some(nested))
        .build()
        .await
        .expect_err("untrusted project layer should not provide MCP transport");

    assert!(
        err.to_string().contains("invalid transport")
            && err.to_string().contains("mcp_servers.sentry"),
        "unexpected error: {err}"
    );

    Ok(())
}

#[tokio::test]
async fn invalid_project_config_ignored_when_untrusted_or_unknown() -> std::io::Result<()> {
    let tmp = tempdir()?;
    let project_root = tmp.path().join("project");
    let nested = project_root.join("child");
    tokio::fs::create_dir_all(nested.join(".codex")).await?;
    tokio::fs::write(project_root.join(".git"), "gitdir: here").await?;
    tokio::fs::write(nested.join(".codex").join(CONFIG_TOML_FILE), "foo =").await?;

    let cwd = AbsolutePathBuf::from_absolute_path(&nested)?;
    let cases = [
        ("untrusted", Some(TrustLevel::Untrusted)),
        ("unknown", None),
    ];

    for (name, trust_level) in cases {
        let codex_home = tmp.path().join(format!("home_{name}"));
        tokio::fs::create_dir_all(&codex_home).await?;
        let config_path = codex_home.join(CONFIG_TOML_FILE);

        if let Some(trust_level) = trust_level {
            make_config_for_test(
                &codex_home,
                &project_root,
                trust_level,
                /*project_root_markers*/ None,
            )
            .await?;
            let config_contents = tokio::fs::read_to_string(&config_path).await?;
            tokio::fs::write(
                &config_path,
                format!(
                    r#"foo = "user"
{config_contents}"#
                ),
            )
            .await?;
        } else {
            tokio::fs::write(
                &config_path,
                r#"foo = "user"
"#,
            )
            .await?;
        }

        let layers = load_config_layers_state(
            LOCAL_FS.as_ref(),
            &codex_home,
            Some(cwd.clone()),
            &[] as &[(String, TomlValue)],
            LoaderOverrides::default(),
            &codex_config::NoopThreadConfigLoader,
        )
        .await?;
        let project_layers: Vec<_> = layers
            .all_layers_high_to_low()
            .filter(|layer| matches!(layer.name, ConfigLayerSource::Project { .. }))
            .collect();
        assert_eq!(
            project_layers.len(),
            1,
            "expected one project layer for {name}"
        );
        assert!(
            project_layers[0].disabled_reason.is_some(),
            "expected {name} project layer to be disabled"
        );
        assert_eq!(
            project_layers[0].config,
            TomlValue::Table(toml::map::Map::new())
        );
        assert_eq!(
            layers.effective_config().get("foo"),
            Some(&TomlValue::String("user".to_string()))
        );
    }

    Ok(())
}

#[tokio::test]
async fn project_layer_without_config_toml_is_disabled_when_untrusted_or_unknown()
-> std::io::Result<()> {
    let tmp = tempdir()?;
    let project_root = tmp.path().join("project");
    let nested = project_root.join("child");
    tokio::fs::create_dir_all(nested.join(".codex")).await?;
    tokio::fs::write(project_root.join(".git"), "gitdir: here").await?;

    let cwd = AbsolutePathBuf::from_absolute_path(&nested)?;
    let cases = [
        ("untrusted", Some(TrustLevel::Untrusted), true),
        ("unknown", None, true),
        ("trusted", Some(TrustLevel::Trusted), false),
    ];

    for (name, trust_level, expect_disabled) in cases {
        let codex_home = tmp.path().join(format!("home_no_config_{name}"));
        tokio::fs::create_dir_all(&codex_home).await?;
        if let Some(trust_level) = trust_level {
            make_config_for_test(
                &codex_home,
                &project_root,
                trust_level,
                /*project_root_markers*/ None,
            )
            .await?;
        }

        let layers = load_config_layers_state(
            LOCAL_FS.as_ref(),
            &codex_home,
            Some(cwd.clone()),
            &[] as &[(String, TomlValue)],
            LoaderOverrides::default(),
            &codex_config::NoopThreadConfigLoader,
        )
        .await?;
        let project_layers: Vec<_> = layers
            .all_layers_high_to_low()
            .filter(|layer| matches!(layer.name, ConfigLayerSource::Project { .. }))
            .collect();
        assert_eq!(
            project_layers.len(),
            1,
            "expected one project layer for {name}"
        );
        assert_eq!(
            project_layers[0].disabled_reason.is_some(),
            expect_disabled,
            "unexpected disabled state for {name}",
        );
        assert_eq!(
            project_layers[0].config,
            TomlValue::Table(toml::map::Map::new())
        );
    }

    Ok(())
}

#[tokio::test]
async fn cli_overrides_with_relative_paths_do_not_break_trust_check() -> std::io::Result<()> {
    let tmp = tempdir()?;
    let project_root = tmp.path().join("project");
    let nested = project_root.join("child");
    tokio::fs::create_dir_all(&nested).await?;
    tokio::fs::write(project_root.join(".git"), "gitdir: here").await?;

    let codex_home = tmp.path().join("home");
    tokio::fs::create_dir_all(&codex_home).await?;
    make_config_for_test(
        &codex_home,
        &project_root,
        TrustLevel::Trusted,
        /*project_root_markers*/ None,
    )
    .await?;

    let cwd = AbsolutePathBuf::from_absolute_path(&nested)?;
    let cli_overrides = vec![(
        "model_instructions_file".to_string(),
        TomlValue::String("relative.md".to_string()),
    )];

    load_config_layers_state(
        LOCAL_FS.as_ref(),
        &codex_home,
        Some(cwd),
        &cli_overrides,
        LoaderOverrides::default(),
        &codex_config::NoopThreadConfigLoader,
    )
    .await?;

    Ok(())
}

#[tokio::test]
async fn project_root_markers_supports_alternate_markers() -> std::io::Result<()> {
    let tmp = tempdir()?;
    let project_root = tmp.path().join("project");
    let nested = project_root.join("child");
    tokio::fs::create_dir_all(project_root.join(".codex")).await?;
    tokio::fs::create_dir_all(nested.join(".codex")).await?;
    tokio::fs::write(project_root.join(".hg"), "hg").await?;
    tokio::fs::write(
        project_root.join(".codex").join(CONFIG_TOML_FILE),
        r#"foo = "root"
"#,
    )
    .await?;
    tokio::fs::write(
        nested.join(".codex").join(CONFIG_TOML_FILE),
        r#"foo = "child"
"#,
    )
    .await?;

    let codex_home = tmp.path().join("home");
    tokio::fs::create_dir_all(&codex_home).await?;
    make_config_for_test(
        &codex_home,
        &project_root,
        TrustLevel::Trusted,
        Some(vec![".hg".to_string()]),
    )
    .await?;

    let cwd = AbsolutePathBuf::from_absolute_path(&nested)?;
    let layers = load_config_layers_state(
        LOCAL_FS.as_ref(),
        &codex_home,
        Some(cwd),
        &[] as &[(String, TomlValue)],
        LoaderOverrides::default(),
        &codex_config::NoopThreadConfigLoader,
    )
    .await?;

    let project_layers: Vec<_> = layers
        .layers_high_to_low()
        .filter_map(|layer| match &layer.name {
            ConfigLayerSource::Project { dot_codex_folder } => Some(dot_codex_folder),
            _ => None,
        })
        .collect();
    assert_eq!(project_layers.len(), 2);
    assert_eq!(project_layers[0].as_path(), nested.join(".codex").as_path());
    assert_eq!(
        project_layers[1].as_path(),
        project_root.join(".codex").as_path()
    );

    let merged = layers.effective_config();
    let foo = merged
        .get("foo")
        .and_then(TomlValue::as_str)
        .expect("foo entry");
    assert_eq!(foo, "child");

    Ok(())
}

mod requirements_exec_policy_tests {
    use crate::exec_policy::load_exec_policy;
    use codex_config::ConfigLayerEntry;
    use codex_config::ConfigLayerSource;
    use codex_config::ConfigLayerStack;
    use codex_config::ConfigRequirements;
    use codex_config::ConfigRequirementsToml;
    use codex_config::ConfigRequirementsWithSources;
    use codex_config::RequirementSource;
    use codex_config::RequirementsExecPolicyDecisionToml;
    use codex_config::RequirementsExecPolicyParseError;
    use codex_config::RequirementsExecPolicyPatternTokenToml;
    use codex_config::RequirementsExecPolicyPrefixRuleToml;
    use codex_config::RequirementsExecPolicyToml;
    use codex_execpolicy::Decision;
    use codex_execpolicy::Evaluation;
    use codex_execpolicy::RuleMatch;
    use codex_utils_absolute_path::AbsolutePathBuf;
    use pretty_assertions::assert_eq;
    use std::path::Path;
    use tempfile::tempdir;
    use toml::Value as TomlValue;
    use toml::from_str;

    fn tokens(cmd: &[&str]) -> Vec<String> {
        cmd.iter().map(std::string::ToString::to_string).collect()
    }

    fn panic_if_called(_: &[String]) -> Decision {
        panic!("rule should match so heuristic should not be called");
    }

    fn config_stack_for_dot_codex_folder_with_requirements(
        dot_codex_folder: &Path,
        requirements: ConfigRequirements,
    ) -> ConfigLayerStack {
        let dot_codex_folder = AbsolutePathBuf::from_absolute_path(dot_codex_folder)
            .expect("absolute dot_codex_folder");
        let layer = ConfigLayerEntry::new(
            ConfigLayerSource::Project { dot_codex_folder },
            TomlValue::Table(Default::default()),
        );
        ConfigLayerStack::new(vec![layer], requirements, ConfigRequirementsToml::default())
            .expect("ConfigLayerStack")
    }

    fn requirements_from_toml(toml_str: &str) -> ConfigRequirements {
        let config: ConfigRequirementsToml = from_str(toml_str).expect("parse requirements toml");
        let mut with_sources = ConfigRequirementsWithSources::default();
        with_sources.merge_unset_fields(RequirementSource::Unknown, config);
        ConfigRequirements::try_from(with_sources).expect("requirements")
    }

    #[test]
    fn parses_single_prefix_rule_from_raw_toml() -> anyhow::Result<()> {
        let toml_str = r#"
prefix_rules = [
    { pattern = [{ token = "rm" }], decision = "forbidden" },
]
"#;

        let parsed: RequirementsExecPolicyToml = from_str(toml_str)?;

        assert_eq!(
            parsed,
            RequirementsExecPolicyToml {
                prefix_rules: vec![RequirementsExecPolicyPrefixRuleToml {
                    pattern: vec![RequirementsExecPolicyPatternTokenToml {
                        token: Some("rm".to_string()),
                        any_of: None,
                    }],
                    decision: Some(RequirementsExecPolicyDecisionToml::Forbidden),
                    justification: None,
                }],
            }
        );

        Ok(())
    }

    #[test]
    fn parses_multiple_prefix_rules_from_raw_toml() -> anyhow::Result<()> {
        let toml_str = r#"
prefix_rules = [
    { pattern = [{ token = "rm" }], decision = "forbidden" },
    { pattern = [{ token = "git" }, { any_of = ["push", "commit"] }], decision = "prompt", justification = "review changes before push or commit" },
]
"#;

        let parsed: RequirementsExecPolicyToml = from_str(toml_str)?;

        assert_eq!(
            parsed,
            RequirementsExecPolicyToml {
                prefix_rules: vec![
                    RequirementsExecPolicyPrefixRuleToml {
                        pattern: vec![RequirementsExecPolicyPatternTokenToml {
                            token: Some("rm".to_string()),
                            any_of: None,
                        }],
                        decision: Some(RequirementsExecPolicyDecisionToml::Forbidden),
                        justification: None,
                    },
                    RequirementsExecPolicyPrefixRuleToml {
                        pattern: vec![
                            RequirementsExecPolicyPatternTokenToml {
                                token: Some("git".to_string()),
                                any_of: None,
                            },
                            RequirementsExecPolicyPatternTokenToml {
                                token: None,
                                any_of: Some(vec!["push".to_string(), "commit".to_string()]),
                            },
                        ],
                        decision: Some(RequirementsExecPolicyDecisionToml::Prompt),
                        justification: Some("review changes before push or commit".to_string()),
                    },
                ],
            }
        );

        Ok(())
    }

    #[test]
    fn converts_rules_toml_into_internal_policy_representation() -> anyhow::Result<()> {
        let toml_str = r#"
prefix_rules = [
    { pattern = [{ token = "rm" }], decision = "forbidden" },
]
"#;

        let parsed: RequirementsExecPolicyToml = from_str(toml_str)?;
        let policy = parsed.to_policy()?;

        assert_eq!(
            policy.check(&tokens(&["rm", "-rf", "/tmp"]), &panic_if_called),
            Evaluation {
                decision: Decision::Forbidden,
                matched_rules: vec![RuleMatch::PrefixRuleMatch {
                    matched_prefix: tokens(&["rm"]),
                    decision: Decision::Forbidden,
                    resolved_program: None,
                    justification: None,
                }],
            }
        );

        Ok(())
    }

    #[test]
    fn head_any_of_expands_into_multiple_program_rules() -> anyhow::Result<()> {
        let toml_str = r#"
prefix_rules = [
    { pattern = [{ any_of = ["git", "hg"] }, { token = "status" }], decision = "prompt" },
]
"#;
        let parsed: RequirementsExecPolicyToml = from_str(toml_str)?;
        let policy = parsed.to_policy()?;

        assert_eq!(
            policy.check(&tokens(&["git", "status"]), &panic_if_called),
            Evaluation {
                decision: Decision::Prompt,
                matched_rules: vec![RuleMatch::PrefixRuleMatch {
                    matched_prefix: tokens(&["git", "status"]),
                    decision: Decision::Prompt,
                    resolved_program: None,
                    justification: None,
                }],
            }
        );
        assert_eq!(
            policy.check(&tokens(&["hg", "status"]), &panic_if_called),
            Evaluation {
                decision: Decision::Prompt,
                matched_rules: vec![RuleMatch::PrefixRuleMatch {
                    matched_prefix: tokens(&["hg", "status"]),
                    decision: Decision::Prompt,
                    resolved_program: None,
                    justification: None,
                }],
            }
        );

        Ok(())
    }

    #[test]
    fn missing_decision_is_rejected() -> anyhow::Result<()> {
        let toml_str = r#"
prefix_rules = [
    { pattern = [{ token = "rm" }] },
]
"#;

        let parsed: RequirementsExecPolicyToml = from_str(toml_str)?;
        let err = parsed.to_policy().expect_err("missing decision");

        assert!(matches!(
            err,
            RequirementsExecPolicyParseError::MissingDecision { rule_index: 0 }
        ));
        Ok(())
    }

    #[test]
    fn allow_decision_is_rejected() -> anyhow::Result<()> {
        let toml_str = r#"
prefix_rules = [
    { pattern = [{ token = "rm" }], decision = "allow" },
]
"#;

        let parsed: RequirementsExecPolicyToml = from_str(toml_str)?;
        let err = parsed.to_policy().expect_err("allow decision not allowed");

        assert!(matches!(
            err,
            RequirementsExecPolicyParseError::AllowDecisionNotAllowed { rule_index: 0 }
        ));
        Ok(())
    }

    #[test]
    fn empty_prefix_rules_is_rejected() -> anyhow::Result<()> {
        let toml_str = r#"
prefix_rules = []
"#;

        let parsed: RequirementsExecPolicyToml = from_str(toml_str)?;
        let err = parsed.to_policy().expect_err("empty prefix rules");

        assert!(matches!(
            err,
            RequirementsExecPolicyParseError::EmptyPrefixRules
        ));
        Ok(())
    }

    #[tokio::test]
    async fn loads_requirements_exec_policy_without_rules_files() -> anyhow::Result<()> {
        let temp_dir = tempdir()?;
        let requirements = requirements_from_toml(
            r#"
                [rules]
                prefix_rules = [
                    { pattern = [{ token = "rm" }], decision = "forbidden" },
                ]
            "#,
        );
        let config_stack =
            config_stack_for_dot_codex_folder_with_requirements(temp_dir.path(), requirements);

        let policy = load_exec_policy(&config_stack).await?;

        assert_eq!(
            policy.check_multiple([vec!["rm".to_string()]].iter(), &panic_if_called),
            Evaluation {
                decision: Decision::Forbidden,
                matched_rules: vec![RuleMatch::PrefixRuleMatch {
                    matched_prefix: vec!["rm".to_string()],
                    decision: Decision::Forbidden,
                    resolved_program: None,
                    justification: None,
                }],
            }
        );

        Ok(())
    }

    #[tokio::test]
    async fn merges_requirements_exec_policy_with_file_rules() -> anyhow::Result<()> {
        let temp_dir = tempdir()?;
        let policy_dir = temp_dir.path().join("rules");
        std::fs::create_dir_all(&policy_dir)?;
        std::fs::write(
            policy_dir.join("deny.rules"),
            r#"prefix_rule(pattern=["rm"], decision="forbidden")"#,
        )?;

        let requirements = requirements_from_toml(
            r#"
                [rules]
                prefix_rules = [
                    { pattern = [{ token = "git" }, { token = "push" }], decision = "prompt" },
                ]
            "#,
        );
        let config_stack =
            config_stack_for_dot_codex_folder_with_requirements(temp_dir.path(), requirements);

        let policy = load_exec_policy(&config_stack).await?;

        assert_eq!(
            policy.check_multiple([vec!["rm".to_string()]].iter(), &panic_if_called),
            Evaluation {
                decision: Decision::Forbidden,
                matched_rules: vec![RuleMatch::PrefixRuleMatch {
                    matched_prefix: vec!["rm".to_string()],
                    decision: Decision::Forbidden,
                    resolved_program: None,
                    justification: None,
                }],
            }
        );
        assert_eq!(
            policy.check_multiple(
                [vec!["git".to_string(), "push".to_string()]].iter(),
                &panic_if_called
            ),
            Evaluation {
                decision: Decision::Prompt,
                matched_rules: vec![RuleMatch::PrefixRuleMatch {
                    matched_prefix: vec!["git".to_string(), "push".to_string()],
                    decision: Decision::Prompt,
                    resolved_program: None,
                    justification: None,
                }],
            }
        );

        Ok(())
    }
}

#[tokio::test]
async fn async_compaction_config() {
    use std::io::ErrorKind::InvalidInput;

    for (settings, expected) in [
        ("[features]\nasync_compaction = true", Ok((true, 65))),
        ("[features]\nasync_compaction = false", Ok((false, 65))),
        ("[features.async_compaction]", Ok((false, 65))),
        (
            "[features.async_compaction]\nenabled = true",
            Ok((true, 65)),
        ),
        (
            "[features.async_compaction]\nmodel_async_compact_threshold_percent = 80",
            Ok((false, 80)),
        ),
        (
            "[features.async_compaction]\nenabled = false\nmodel_async_compact_threshold_percent = 80",
            Ok((false, 80)),
        ),
        (
            "[features.async_compaction]\nenabled = true\nmodel_async_compact_threshold_percent = 75",
            Ok((true, 75)),
        ),
        (
            "[features.async_compaction]\nmodel_async_compact_threshold_percent = 0",
            Err(InvalidInput),
        ),
        (
            "[features.async_compaction]\nmodel_async_compact_threshold_percent = 101",
            Err(InvalidInput),
        ),
    ] {
        let tmp = tempdir().expect("tempdir");
        std::fs::write(tmp.path().join(CONFIG_TOML_FILE), settings).expect("write config");
        let actual = ConfigBuilder::default()
            .codex_home(tmp.path().to_path_buf())
            .fallback_cwd(Some(tmp.path().to_path_buf()))
            .loader_overrides(LoaderOverrides::without_managed_config_for_tests())
            .build()
            .await
            .map(|config| {
                (
                    config.features.enabled(Feature::AsyncCompaction),
                    config.async_compaction_threshold_percent,
                )
            })
            .map_err(|error| error.kind());
        assert_eq!(actual, expected, "{settings}");
    }
}