Skip to content

armgit / codex

Public Imported from GitHub
0

Lightweight coding agent that runs in your terminal

Rust

Restrict login setup redirects to known platform origins (#44670)

Drew Hintz1b83e5cdf998
diff --git a/codex-rs/login/src/assets/success.html b/codex-rs/login/src/assets/success.html
index 5b01ceb90e..eeeb5bc4e3 100644
--- a/codex-rs/login/src/assets/success.html
+++ b/codex-rs/login/src/assets/success.html
@@ -209,6 +209,13 @@
}
if (needsSetup) {
+ // The login server selects one of these platform origins from the OAuth issuer.
+ if (
+ platformUrl !== "https://platform.openai.com" &&
+ platformUrl !== "https://platform.api.openai.org"
+ ) {
+ return;
+ }
const setupBox = document.getElementById("setup-box");
const countdownNode = document.getElementById("countdown");
setupBox.style.display = "block";
diff --git a/codex-rs/login/src/assets/success_legacy.html b/codex-rs/login/src/assets/success_legacy.html
index 015866ee54..9b441e290b 100644
--- a/codex-rs/login/src/assets/success_legacy.html
+++ b/codex-rs/login/src/assets/success_legacy.html
@@ -166,6 +166,13 @@
const idToken = params.get('id_token');
// Show different message and optional redirect when setup is required
if (needsSetup) {
+ // The login server selects one of these platform origins from the OAuth issuer.
+ if (
+ platformUrl !== 'https://platform.openai.com' &&
+ platformUrl !== 'https://platform.api.openai.org'
+ ) {
+ return;
+ }
const setupBox = document.querySelector('.setup-box');
setupBox.style.display = 'flex';
const redirectUrlObj = new URL('/org-setup', platformUrl);