Lightweight coding agent that runs in your terminal
Rust
Enable analytics by default for daemon-launched app servers (#49426)
Benjamin Carlsson2cc65cdd4c7c
diff --git a/codex-rs/app-server-daemon/src/backend/pid.rs b/codex-rs/app-server-daemon/src/backend/pid.rsindex 22e34d9095..0e69a3f0e9 100644--- a/codex-rs/app-server-daemon/src/backend/pid.rs+++ b/codex-rs/app-server-daemon/src/backend/pid.rs@@ -394,6 +394,8 @@ impl PidBackend {}};if matches!(self.command_kind, PidCommandKind::AppServer { .. }) {+ // Match first-party clients' default while preserving explicit analytics opt-outs.+ args.push("--analytics-default-enabled".into());for (name, enabled) in &self.feature_overrides {args.extend(["-c".into(), format!("features.{name}={enabled}").into()]);}diff --git a/codex-rs/app-server-daemon/src/backend/pid_tests.rs b/codex-rs/app-server-daemon/src/backend/pid_tests.rsindex 19d262c097..dbd6a4075a 100644--- a/codex-rs/app-server-daemon/src/backend/pid_tests.rs+++ b/codex-rs/app-server-daemon/src/backend/pid_tests.rs@@ -602,7 +602,13 @@ fn app_server_remote_control_uses_runtime_flag() {assert_eq!(backend.command_args(),- vec!["app-server", "--remote-control", "--listen", "unix://"]+ vec![+ "app-server",+ "--remote-control",+ "--listen",+ "unix://",+ "--analytics-default-enabled"+ ]);}@@ -616,7 +622,12 @@ fn app_server_disabled_remote_control_uses_compatible_args_and_runtime_env() {assert_eq!(backend.command_args(),- vec!["app-server", "--listen", "unix://"]+ vec![+ "app-server",+ "--listen",+ "unix://",+ "--analytics-default-enabled"+ ]);assert_eq!(backend.command_env(),diff --git a/codex-rs/app-server-daemon/src/update_loop_tests.rs b/codex-rs/app-server-daemon/src/update_loop_tests.rsindex d932742371..0847655a30 100644--- a/codex-rs/app-server-daemon/src/update_loop_tests.rs+++ b/codex-rs/app-server-daemon/src/update_loop_tests.rs@@ -584,9 +584,9 @@ async fn daemon_start_and_restart_preserve_launch_features() {features);let expected = if features.is_empty() {- "app-server\n--listen\nunix://\n--managed-daemon\n"+ "app-server\n--listen\nunix://\n--analytics-default-enabled\n--managed-daemon\n"} else {- "app-server\n--listen\nunix://\n-c\nfeatures.api_key_model_discovery=true\n-c\nfeatures.code_mode_host=false\n--managed-daemon\n"+ "app-server\n--listen\nunix://\n--analytics-default-enabled\n-c\nfeatures.api_key_model_discovery=true\n-c\nfeatures.code_mode_host=false\n--managed-daemon\n"};assert_eq!(std::fs::read_to_string(&args_path).unwrap(), expected);let reused = daemon