Lightweight coding agent that runs in your terminal
Rust
Include transparent background in image generation analytics (#40544)
alicec-oai348f49b292e7
diff --git a/codex-rs/analytics/src/analytics_client_tests.rs b/codex-rs/analytics/src/analytics_client_tests.rsindex 724e83ec18..c1022a3125 100644--- a/codex-rs/analytics/src/analytics_client_tests.rs+++ b/codex-rs/analytics/src/analytics_client_tests.rs@@ -5092,6 +5092,78 @@ async fn turn_lifecycle_emits_turn_event() {assert_eq!(payload["event_params"]["total_tokens"], json!(321));}+#[tokio::test]+async fn image_generation_events_preserve_transparent_background_metadata() {+ for (status, transparent_background) in [+ ("completed", Some(true)),+ ("completed", Some(false)),+ ("completed", None),+ ("failed", None),+ ] {+ let mut reducer = AnalyticsReducer::default();+ let mut out = Vec::new();++ ingest_turn_prerequisites(+ &mut reducer,+ &mut out,+ /*include_initialize*/ true,+ /*include_resolved_config*/ true,+ /*include_started*/ true,+ /*include_token_usage*/ false,+ )+ .await;++ let item = ThreadItem::ImageGeneration(ImageGenerationItem {+ id: "image-1".to_string(),+ status: status.to_string(),+ revised_prompt: None,+ result: "ok".to_string(),+ transparent_background,+ failure: None,+ saved_path: None,+ });++ reducer+ .ingest(+ AnalyticsFact::Notification(Box::new(ServerNotification::ItemStarted(+ ItemStartedNotification {+ thread_id: "thread-2".to_string(),+ turn_id: "turn-2".to_string(),+ started_at_ms: 998,+ item: item.clone(),+ },+ ))),+ &mut out,+ )+ .await;+ reducer+ .ingest(+ AnalyticsFact::Notification(Box::new(ServerNotification::ItemCompleted(+ ItemCompletedNotification {+ thread_id: "thread-2".to_string(),+ turn_id: "turn-2".to_string(),+ completed_at_ms: 1_000,+ item,+ },+ ))),+ &mut out,+ )+ .await;++ let event = out+ .iter()+ .find(|event| matches!(event, TrackEventRequest::ImageGeneration(_)))+ .expect("image generation event should be emitted");+ let payload = serde_json::to_value(event).expect("serialize image generation event");++ assert_eq!(+ payload["event_params"].get("transparent_background"),+ Some(&json!(transparent_background))+ );+ assert_eq!(payload["event_params"]["terminal_status"], json!(status));+ }+}+#[tokio::test]async fn turn_event_counts_completed_tool_items() {let mut reducer = AnalyticsReducer::default();diff --git a/codex-rs/analytics/src/events.rs b/codex-rs/analytics/src/events.rsindex 0e00c80b88..34ef099c8f 100644--- a/codex-rs/analytics/src/events.rs+++ b/codex-rs/analytics/src/events.rs@@ -895,6 +895,7 @@ pub(crate) struct CodexImageGenerationEventParams {pub(crate) base: CodexToolItemEventBase,pub(crate) revised_prompt_present: bool,pub(crate) saved_path_present: bool,+ pub(crate) transparent_background: Option<bool>,}#[derive(Serialize)]diff --git a/codex-rs/analytics/src/reducer.rs b/codex-rs/analytics/src/reducer.rsindex aee7b8af36..0fb54c9257 100644--- a/codex-rs/analytics/src/reducer.rs+++ b/codex-rs/analytics/src/reducer.rs@@ -2831,6 +2831,7 @@ fn tool_item_event(input: ToolItemEventInput<'_>) -> Option<TrackEventRequest> {base,revised_prompt_present: item.revised_prompt.is_some(),saved_path_present: item.saved_path.is_some(),+ transparent_background: item.transparent_background,},},))