Skip to content

armgit / codex

Public Imported from GitHub
0

Lightweight coding agent that runs in your terminal

Rust

Add a requirements feature gate for the browser annotation API (#49784)

Oliver Tepman3bbf8ec3a1e1
diff --git a/codex-rs/core/config.schema.json b/codex-rs/core/config.schema.json
index 7d0898ee2e..de866e4609 100644
--- a/codex-rs/core/config.schema.json
+++ b/codex-rs/core/config.schema.json
@@ -759,6 +759,9 @@
"bedrock_setup_wizard": {
"type": "boolean"
},
+ "browser_annotation_api": {
+ "type": "boolean"
+ },
"browser_use": {
"type": "boolean"
},
@@ -6805,6 +6808,9 @@
"bedrock_setup_wizard": {
"type": "boolean"
},
+ "browser_annotation_api": {
+ "type": "boolean"
+ },
"browser_use": {
"type": "boolean"
},
diff --git a/codex-rs/core/src/config/config_tests.rs b/codex-rs/core/src/config/config_tests.rs
index d3e3b12437..9a2a979b0e 100644
--- a/codex-rs/core/src/config/config_tests.rs
+++ b/codex-rs/core/src/config/config_tests.rs
@@ -11657,6 +11657,7 @@ async fn browser_feature_requirements_are_valid() -> std::io::Result<()> {
r#"
[features]
in_app_browser = false
+browser_annotation_api = false
browser_use = false
browser_use_full_cdp_access = false
"#,
@@ -11666,6 +11667,7 @@ browser_use_full_cdp_access = false
.await?;
assert!(!config.features.enabled(Feature::InAppBrowser));
+ assert!(!config.features.enabled(Feature::BrowserAnnotationApi));
assert!(!config.features.enabled(Feature::BrowserUse));
assert!(!config.features.enabled(Feature::BrowserUseFullCdpAccess));
diff --git a/codex-rs/features/src/lib.rs b/codex-rs/features/src/lib.rs
index 970c37bd9c..e47731d1e6 100644
--- a/codex-rs/features/src/lib.rs
+++ b/codex-rs/features/src/lib.rs
@@ -264,6 +264,11 @@ pub enum Feature {
///
/// Requirements-only gate: this should be set from requirements, not user config.
InAppBrowser,
+ /// Allow websites to open and customize annotation tools in desktop apps.
+ /// Ordinary user-driven annotation is independent of this gate.
+ ///
+ /// Requirements-only gate: this should be set from requirements, not user config.
+ BrowserAnnotationApi,
/// Allow the in-app chat pane in desktop apps.
///
/// Requirements-only gate: this should be set from requirements, not user config.
@@ -1517,6 +1522,12 @@ pub const FEATURES: &[FeatureSpec] = &[
stage: Stage::Stable,
default_enabled: true,
},
+ FeatureSpec {
+ id: Feature::BrowserAnnotationApi,
+ key: "browser_annotation_api",
+ stage: Stage::Stable,
+ default_enabled: true,
+ },
FeatureSpec {
id: Feature::InAppChat,
key: "in_app_chat",