Skip to content

armgit / codex

Public Imported from GitHub
0

Lightweight coding agent that runs in your terminal

Rust

Remove `repo_url` from skill invocation analytics events (#44586)

marksteinbrick-oai818f1cca8ccf
diff --git a/codex-rs/analytics/src/analytics_client_tests.rs b/codex-rs/analytics/src/analytics_client_tests.rs
index 4c343db5b8..7a49f7221e 100644
--- a/codex-rs/analytics/src/analytics_client_tests.rs
+++ b/codex-rs/analytics/src/analytics_client_tests.rs
@@ -4442,7 +4442,6 @@ async fn reducer_ingests_skill_invoked_fact() {
"skill_scope": "user",
"plugin_id": null,
"remote_plugin_id": null,
- "repo_url": null,
"thread_id": "thread-1",
"turn_id": "turn-1",
"invoke_type": "explicit",
diff --git a/codex-rs/analytics/src/client_tests.rs b/codex-rs/analytics/src/client_tests.rs
index 7797072415..494c23a358 100644
--- a/codex-rs/analytics/src/client_tests.rs
+++ b/codex-rs/analytics/src/client_tests.rs
@@ -146,7 +146,6 @@ fn sample_skill_track_event(thread_id: &str, plugin_id: Option<&str>) -> TrackEv
skill_scope: None,
plugin_id: plugin_id.map(str::to_string),
remote_plugin_id: None,
- repo_url: None,
thread_id: Some(thread_id.to_string()),
turn_id: Some("turn-1".to_string()),
invoke_type: Some(InvocationType::Explicit),
diff --git a/codex-rs/analytics/src/events.rs b/codex-rs/analytics/src/events.rs
index c1729ef678..61303b0e46 100644
--- a/codex-rs/analytics/src/events.rs
+++ b/codex-rs/analytics/src/events.rs
@@ -209,7 +209,6 @@ pub(crate) struct SkillInvocationEventParams {
pub(crate) skill_scope: Option<String>,
pub(crate) plugin_id: Option<String>,
pub(crate) remote_plugin_id: Option<String>,
- pub(crate) repo_url: Option<String>,
pub(crate) thread_id: Option<String>,
pub(crate) turn_id: Option<String>,
pub(crate) invoke_type: Option<InvocationType>,
diff --git a/codex-rs/analytics/src/reducer.rs b/codex-rs/analytics/src/reducer.rs
index c736552130..f2e3c6454d 100644
--- a/codex-rs/analytics/src/reducer.rs
+++ b/codex-rs/analytics/src/reducer.rs
@@ -1283,7 +1283,7 @@ impl AnalyticsReducer {
invocations,
} = input;
for invocation in invocations {
- let (skill_id, repo_url, skill_scope) = match invocation.location {
+ let (skill_id, skill_scope) = match invocation.location {
SkillInvocationLocation::Host { path, scope } => {
let skill_scope = match scope {
SkillScope::User => "user",
@@ -1305,7 +1305,7 @@ impl AnalyticsReducer {
path.as_path(),
invocation.skill_name.as_str(),
);
- (skill_id, repo_url, Some(skill_scope.to_string()))
+ (skill_id, Some(skill_scope.to_string()))
}
SkillInvocationLocation::Resource {
id,
@@ -1328,7 +1328,7 @@ impl AnalyticsReducer {
SkillScope::Admin => "admin",
})
.map(str::to_owned);
- (skill_id, None, skill_scope)
+ (skill_id, skill_scope)
}
};
out.push(TrackEventRequest::SkillInvocation(
@@ -1342,7 +1342,6 @@ impl AnalyticsReducer {
invoke_type: Some(invocation.invocation_type),
model_slug: Some(tracking.model_slug.clone()),
product_client_id: Some(tracking.product_client_id.clone()),
- repo_url: repo_url.map(String::from),
skill_scope,
plugin_id: invocation.plugin_id,
remote_plugin_id: invocation.remote_plugin_id,