Skip to content

armgit / codex

Public Imported from GitHub
0

Lightweight coding agent that runs in your terminal

Rust

Remove redundant test coverage (#42069)

jif82461c99903c
diff --git a/codex-rs/core/src/config/config_tests.rs b/codex-rs/core/src/config/config_tests.rs
index dcc504c87c..87938ad87f 100644
--- a/codex-rs/core/src/config/config_tests.rs
+++ b/codex-rs/core/src/config/config_tests.rs
@@ -1234,21 +1234,6 @@ fn config_toml_deserializes_model_availability_nux() {
);
}
-#[test]
-fn config_toml_status_line_use_colors_defaults_to_enabled() {
- let toml = r#"
-[tui]
-"#;
- let cfg: ConfigToml =
- toml::from_str(toml).expect("TOML deserialization should succeed for TUI config");
-
- assert!(
- cfg.tui
- .expect("tui config should deserialize")
- .status_line_use_colors
- );
-}
-
#[test]
fn config_toml_deserializes_status_line_use_colors_disabled() {
let toml = r#"
@@ -1298,20 +1283,6 @@ async fn runtime_config_defaults_model_availability_nux() {
);
}
-#[test]
-fn test_tui_vim_mode_default_defaults_to_false() {
- let toml = r#"
- [tui]
- "#;
- let parsed: ConfigToml = toml::from_str(toml).expect("deserialize empty [tui] table");
- assert!(
- !parsed
- .tui
- .expect("config should include tui section")
- .vim_mode_default
- );
-}
-
#[test]
fn test_tui_vim_mode_default_true() {
let toml = r#"
@@ -1327,35 +1298,6 @@ fn test_tui_vim_mode_default_true() {
);
}
-#[test]
-fn test_tui_raw_output_mode_defaults_to_false() {
- let toml = r#"
- [tui]
- "#;
- let parsed: ConfigToml = toml::from_str(toml).expect("deserialize empty [tui] table");
- assert!(
- !parsed
- .tui
- .expect("config should include tui section")
- .raw_output_mode
- );
-}
-
-#[test]
-fn test_tui_raw_output_mode_true() {
- let toml = r#"
- [tui]
- raw_output_mode = true
- "#;
- let parsed: ConfigToml = toml::from_str(toml).expect("deserialize raw_output_mode=true");
- assert!(
- parsed
- .tui
- .expect("config should include tui section")
- .raw_output_mode
- );
-}
-
#[tokio::test]
async fn runtime_config_uses_tui_raw_output_mode() {
let toml = r#"
@@ -4164,15 +4106,6 @@ theme = "dracula"
);
}
-#[test]
-fn tui_theme_defaults_to_none() {
- let cfg = r#"
-[tui]
-"#;
- let parsed = toml::from_str::<ConfigToml>(cfg).expect("TOML deserialization should succeed");
- assert_eq!(parsed.tui.as_ref().and_then(|t| t.theme.as_deref()), None);
-}
-
#[test]
fn tui_session_picker_view_deserializes_from_toml() {
let cfg = r#"
@@ -4212,27 +4145,6 @@ pet = "chefito"
);
}
-#[test]
-fn tui_session_picker_view_defaults_to_none() {
- let cfg = r#"
-[tui]
-"#;
- let parsed = toml::from_str::<ConfigToml>(cfg).expect("TOML deserialization should succeed");
- assert_eq!(
- parsed.tui.as_ref().and_then(|t| t.session_picker_view),
- None,
- );
-}
-
-#[test]
-fn tui_pet_defaults_to_none() {
- let cfg = r#"
-[tui]
-"#;
- let parsed = toml::from_str::<ConfigToml>(cfg).expect("TOML deserialization should succeed");
- assert_eq!(parsed.tui.as_ref().and_then(|t| t.pet.as_deref()), None);
-}
-
#[test]
fn tui_pet_anchor_deserializes_from_toml() {
let cfg = r#"
@@ -4246,18 +4158,6 @@ pet_anchor = "screen-bottom"
);
}
-#[test]
-fn tui_pet_anchor_defaults_to_composer() {
- let cfg = r#"
-[tui]
-"#;
- let parsed = toml::from_str::<ConfigToml>(cfg).expect("TOML deserialization should succeed");
- assert_eq!(
- parsed.tui.as_ref().map(|t| t.pet_anchor),
- Some(TuiPetAnchor::Composer),
- );
-}
-
#[test]
fn tui_pet_anchor_rejects_unknown_value() {
let cfg = r#"
diff --git a/codex-rs/core/tests/suite/json_result.rs b/codex-rs/core/tests/suite/json_result.rs
index 7bc8653245..dbe24124fd 100644
--- a/codex-rs/core/tests/suite/json_result.rs
+++ b/codex-rs/core/tests/suite/json_result.rs
@@ -40,11 +40,6 @@ async fn codex_returns_json_result_for_gpt5() -> anyhow::Result<()> {
codex_returns_json_result("gpt-5.4".to_string()).await
}
-#[tokio::test(flavor = "multi_thread", worker_threads = 2)]
-async fn codex_returns_json_result_for_gpt5_codex() -> anyhow::Result<()> {
- codex_returns_json_result("gpt-5.4".to_string()).await
-}
-
async fn codex_returns_json_result(model: String) -> anyhow::Result<()> {
skip_if_no_network!(Ok(()));
diff --git a/codex-rs/protocol/src/openai_models.rs b/codex-rs/protocol/src/openai_models.rs
index c942db4d9a..9bd7e1b1b6 100644
--- a/codex-rs/protocol/src/openai_models.rs
+++ b/codex-rs/protocol/src/openai_models.rs
@@ -2071,19 +2071,4 @@ mod tests {
);
assert_eq!(model.service_tier_for_request(/*service_tier*/ None), None);
}
-
- #[test]
- fn service_tier_for_request_does_not_apply_catalog_default() {
- let model = ModelInfo {
- default_service_tier: Some(ServiceTier::Fast.request_value().to_string()),
- service_tiers: vec![ModelServiceTier {
- id: ServiceTier::Fast.request_value().to_string(),
- name: "Fast".to_string(),
- description: "Priority processing.".to_string(),
- }],
- ..test_model(/*spec*/ None)
- };
-
- assert_eq!(model.service_tier_for_request(/*service_tier*/ None), None);
- }
}