Lightweight coding agent that runs in your terminal
Rust
Cache the placeholder regex for MCP hook argument expansion (#49956)
jif8a400e7812b0
diff --git a/codex-rs/hooks/src/engine/mcp_runner.rs b/codex-rs/hooks/src/engine/mcp_runner.rsindex 7a8da53e4d..71bf050e0f 100644--- a/codex-rs/hooks/src/engine/mcp_runner.rs+++ b/codex-rs/hooks/src/engine/mcp_runner.rs@@ -1,3 +1,4 @@+use std::sync::LazyLock;use std::time::Duration;use std::time::Instant;@@ -121,7 +122,9 @@ fn resolve_value(value: &Value, hook_event: &Value) -> Result<Value> {}fn resolve_string(text: &str, hook_event: &Value) -> Result<Value> {- let pattern = Regex::new(r"\$\{([^{}]+)\}")?;+ static PLACEHOLDER_PATTERN: LazyLock<Result<Regex, regex::Error>> =+ LazyLock::new(|| Regex::new(r"\$\{([^{}]+)\}"));+ let pattern = PLACEHOLDER_PATTERN.as_ref().map_err(Clone::clone)?;let captures = pattern.captures_iter(text).collect::<Vec<_>>();if captures.is_empty() {return Ok(Value::String(text.to_string()));