Skip to content

armgit / codex

Public Imported from GitHub
0

Lightweight coding agent that runs in your terminal

Rust

Hide reasoning summary settings in `/status` for server connections (#49145)

Eric Traut8d48f71922dc
diff --git a/codex-rs/tui/src/status/card.rs b/codex-rs/tui/src/status/card.rs
index 60300d079e..73b6daf68c 100644
--- a/codex-rs/tui/src/status/card.rs
+++ b/codex-rs/tui/src/status/card.rs
@@ -322,13 +322,15 @@ impl StatusHistoryCell {
.map(|effort| effort.to_string())
.unwrap_or_else(|| "none".to_string());
config_entries.push(("reasoning effort", effort_value));
- config_entries.push((
- "reasoning summaries",
- config
- .model_reasoning_summary
- .map(|summary| summary.to_string())
- .unwrap_or_else(|| "auto".to_string()),
- ));
+ if remote_connection.is_none() {
+ config_entries.push((
+ "reasoning summaries",
+ config
+ .model_reasoning_summary
+ .map(|summary| summary.to_string())
+ .unwrap_or_else(|| "auto".to_string()),
+ ));
+ }
}
let (model_name, model_details) = compose_model_display(model_name, &config_entries);
let approval = config_entries
diff --git a/codex-rs/tui/src/status/snapshots/codex_tui__status__tests__status_snapshot_local_background_server.snap b/codex-rs/tui/src/status/snapshots/codex_tui__status__tests__status_snapshot_local_background_server.snap
index 163ee982b5..6cc0ff032c 100644
--- a/codex-rs/tui/src/status/snapshots/codex_tui__status__tests__status_snapshot_local_background_server.snap
+++ b/codex-rs/tui/src/status/snapshots/codex_tui__status__tests__status_snapshot_local_background_server.snap
@@ -11,7 +11,7 @@ expression: sanitized
Server: Local background server
- Model: gpt-5.1-codex-max (reasoning medium, summaries auto)
+ Model: gpt-5.1-codex-max (reasoning medium)
Directory: [[workspace]]
Permissions: Custom (workspace with network access, Ask for approval)
Agents.md: <none>
diff --git a/codex-rs/tui/src/status/snapshots/codex_tui__status__tests__status_snapshot_remote_server.snap b/codex-rs/tui/src/status/snapshots/codex_tui__status__tests__status_snapshot_remote_server.snap
new file mode 100644
index 0000000000..8478305e3e
--- /dev/null
+++ b/codex-rs/tui/src/status/snapshots/codex_tui__status__tests__status_snapshot_remote_server.snap
@@ -0,0 +1,22 @@
+---
+source: tui/src/status/tests.rs
+expression: sanitized
+---
+/status
+
+ >_ OpenAI Codex (v0.0.0)
+
+ Visit https://chatgpt.com/codex/settings/usage for up-to-date
+ information on rate limits and credits
+
+ Server: unix:///tmp/codex-home/app-server-control/app-server-
+ control.sock (v0.133.0)
+
+ Model: gpt-5.1-codex-max (reasoning medium)
+ Directory: [[workspace]]
+ Permissions: Custom (workspace with network access, Ask for approval)
+ Agents.md: <none>
+
+ Token usage: 750 total (500 input + 250 output)
+ Context window: 100% left (750 used / 272K)
+ Limits: data not available yet
diff --git a/codex-rs/tui/src/status/snapshots/codex_tui__status__tests__status_snapshot_uses_default_reasoning_when_config_empty.snap b/codex-rs/tui/src/status/snapshots/codex_tui__status__tests__status_snapshot_uses_default_reasoning_when_config_empty.snap
index 03e80108e2..bf5bb867e3 100644
--- a/codex-rs/tui/src/status/snapshots/codex_tui__status__tests__status_snapshot_uses_default_reasoning_when_config_empty.snap
+++ b/codex-rs/tui/src/status/snapshots/codex_tui__status__tests__status_snapshot_uses_default_reasoning_when_config_empty.snap
@@ -9,9 +9,6 @@ expression: sanitized
Visit https://chatgpt.com/codex/settings/usage for up-to-date
information on rate limits and credits
- Server: unix:///tmp/codex-home/app-server-control/app-server-
- control.sock (v0.133.0)
-
Model: gpt-5.1-codex-max (reasoning medium, summaries auto)
Directory: [[workspace]]
Permissions: Custom (workspace with network access, Ask for approval)
diff --git a/codex-rs/tui/src/status/tests.rs b/codex-rs/tui/src/status/tests.rs
index f501402ef3..d2016cabc5 100644
--- a/codex-rs/tui/src/status/tests.rs
+++ b/codex-rs/tui/src/status/tests.rs
@@ -1710,17 +1710,18 @@ async fn status_snapshot_uses_default_reasoning_when_config_empty() {
.expect("timestamp");
for (is_local_daemon, snapshot) in [
(
- false,
+ None,
"status_snapshot_uses_default_reasoning_when_config_empty",
),
- (true, "status_snapshot_local_background_server"),
+ (Some(false), "status_snapshot_remote_server"),
+ (Some(true), "status_snapshot_local_background_server"),
] {
- let remote_connection = RemoteConnectionStatus {
+ let remote_connection = is_local_daemon.map(|is_local_daemon| RemoteConnectionStatus {
address: "unix:///tmp/codex-home/app-server-control/app-server-control.sock"
.to_string(),
version: "v0.133.0".to_string(),
is_local_daemon,
- };
+ });
let model_slug = get_model_offline_for_tests(config.model.as_deref());
let token_info = token_info_for(&model_slug, &config, &usage);
@@ -1728,7 +1729,7 @@ async fn status_snapshot_uses_default_reasoning_when_config_empty() {
&config,
/*requires_openai_auth*/ true,
/*model_provider_id*/ None,
- Some(&remote_connection),
+ remote_connection.as_ref(),
account_display.as_ref(),
Some(&token_info),
&usage,