Skip to content

armgit / codex

Public Imported from GitHub
0

Lightweight coding agent that runs in your terminal

Rust

Limit TUI streaming traces in SQLite logs (#38036)

Tamir Dubersteindad1db87bb5a
diff --git a/codex-rs/state/src/log_db.rs b/codex-rs/state/src/log_db.rs
index e500354ecc..e2b3fcedc8 100644
--- a/codex-rs/state/src/log_db.rs
+++ b/codex-rs/state/src/log_db.rs
@@ -65,6 +65,9 @@ pub fn default_filter() -> Targets {
// SQLite log database, but remain available to explicit TRACE subscribers.
.with_target("codex_http_client::transport", LevelFilter::DEBUG)
.with_target("codex_api::sse", LevelFilter::DEBUG)
+ // Per-chunk streaming traces otherwise flood the bounded SQLite log queue.
+ .with_target("codex_tui::streaming::controller", LevelFilter::DEBUG)
+ .with_target("codex_tui::streaming::table_holdback", LevelFilter::DEBUG)
}
#[derive(Clone, Copy, Debug, Eq, PartialEq)]
diff --git a/codex-rs/state/src/log_db_filter_tests.rs b/codex-rs/state/src/log_db_filter_tests.rs
index 8396c89112..51f89f6060 100644
--- a/codex-rs/state/src/log_db_filter_tests.rs
+++ b/codex-rs/state/src/log_db_filter_tests.rs
@@ -7,7 +7,7 @@ use uuid::Uuid;
use super::*;
#[tokio::test]
-async fn sqlite_sink_drops_low_level_opentelemetry_sdk_logs() {
+async fn sqlite_sink_filters_noisy_targets_without_dropping_useful_diagnostics() {
let codex_home =
std::env::temp_dir().join(format!("codex-state-log-db-filter-{}", Uuid::new_v4()));
let _cleanup = scopeguard::guard(codex_home.clone(), |codex_home| {
@@ -44,6 +44,26 @@ async fn sqlite_sink_drops_low_level_opentelemetry_sdk_logs() {
tracing::trace!(target: "codex_api::sse::responses", "dropped-sse-payload");
tracing::debug!(target: "codex_api::sse::responses", "retained-sse-diagnostic");
tracing::trace!(target: "codex_state", "retained-trace");
+ tracing::trace!(
+ target: "codex_tui::streaming::controller",
+ "dropped-controller-trace"
+ );
+ tracing::debug!(
+ target: "codex_tui::streaming::controller",
+ "retained-controller-debug"
+ );
+ tracing::trace!(
+ target: "codex_tui::streaming::table_holdback",
+ "dropped-table-holdback-trace"
+ );
+ tracing::debug!(
+ target: "codex_tui::streaming::table_holdback",
+ "retained-table-holdback-debug"
+ );
+ tracing::trace!(
+ target: "codex_tui::streaming::commit_tick",
+ "retained-commit-tick-trace"
+ );
tracing::trace!(
target: "codex_api::responses_websocket_timing",
payload = "complete timing payload",
@@ -84,6 +104,21 @@ async fn sqlite_sink_drops_low_level_opentelemetry_sdk_logs() {
Some("retained-sse-diagnostic")
),
("TRACE", "codex_state", Some("retained-trace")),
+ (
+ "DEBUG",
+ "codex_tui::streaming::controller",
+ Some("retained-controller-debug"),
+ ),
+ (
+ "DEBUG",
+ "codex_tui::streaming::table_holdback",
+ Some("retained-table-holdback-debug"),
+ ),
+ (
+ "TRACE",
+ "codex_tui::streaming::commit_tick",
+ Some("retained-commit-tick-trace"),
+ ),
]
);
}