Skip to content

armgit / codex

Public Imported from GitHub
0

Lightweight coding agent that runs in your terminal

Rust

Remove obsolete rusty_v8 146.4.0 Bazel targets (#35997)

seanh-oaidf326d31cda4
diff --git a/MODULE.bazel b/MODULE.bazel
index 91e731b0e6..d46ceaba70 100644
--- a/MODULE.bazel
+++ b/MODULE.bazel
@@ -483,15 +483,6 @@ archive_override(
urls = ["https://github.com/v8/v8/archive/refs/tags/15.0.245.2.tar.gz"],
)
-http_archive(
- name = "v8_crate_146_4_0",
- build_file = "//third_party/v8:v8_crate.BUILD.bazel",
- sha256 = "d97bcac5cdc5a195a4813f1855a6bc658f240452aac36caa12fd6c6f16026ab1",
- strip_prefix = "v8-146.4.0",
- type = "tar.gz",
- urls = ["https://static.crates.io/crates/v8/v8-146.4.0.crate"],
-)
-
http_archive(
name = "v8_crate_150_4_0",
build_file = "//third_party/v8:v8_crate.BUILD.bazel",
diff --git a/third_party/v8/BUILD.bazel b/third_party/v8/BUILD.bazel
index d0c35848bf..d874bce0e0 100644
--- a/third_party/v8/BUILD.bazel
+++ b/third_party/v8/BUILD.bazel
@@ -52,26 +52,6 @@ alias(
actual = ":v8_150_4_0_x86_64_pc_windows_gnullvm_bazel",
)
-filegroup(
- name = "src_binding_release_x86_64_apple_darwin",
- srcs = ["@v8_crate_146_4_0//:src_binding_release_x86_64_apple_darwin"],
-)
-
-filegroup(
- name = "src_binding_release_aarch64_apple_darwin",
- srcs = ["@v8_crate_146_4_0//:src_binding_release_aarch64_apple_darwin"],
-)
-
-filegroup(
- name = "src_binding_release_aarch64_unknown_linux_gnu",
- srcs = ["@v8_crate_146_4_0//:src_binding_release_aarch64_unknown_linux_gnu"],
-)
-
-filegroup(
- name = "src_binding_release_x86_64_unknown_linux_gnu",
- srcs = ["@v8_crate_146_4_0//:src_binding_release_x86_64_unknown_linux_gnu"],
-)
-
alias(
name = "src_binding_release_x86_64_pc_windows_gnullvm_150_4_0_release",
# `rusty_v8` does not publish a Windows GNU binding file. The generated
@@ -166,46 +146,6 @@ cc_library(
],
)
-genrule(
- name = "binding_cc",
- srcs = ["@v8_crate_146_4_0//:binding_cc"],
- outs = ["binding.cc"],
- # Keep this as one physical shell line. In Windows cross CI, this genrule
- # runs on Linux RBE from a Windows Bazel client; multiline command text can
- # carry CRLF into `/bin/bash` as a standalone `$'\r'` command. Use an
- # explicit argv-style join so separators stay visible without shell
- # newlines.
- cmd = " ".join([
- "sed",
- "-e '/#include \"v8\\/src\\/flags\\/flags.h\"/d'",
- "-e 's|\"v8/src/libplatform/default-platform.h\"|\"src/libplatform/default-platform.h\"|'",
- "-e 's| namespace i = v8::internal;| (void)usage;|'",
- "-e '/using HelpOptions = i::FlagList::HelpOptions;/d'",
- "-e '/HelpOptions help_options = HelpOptions(HelpOptions::kExit, usage);/d'",
- "-e 's| i::FlagList::SetFlagsFromCommandLine(argc, argv, true, help_options);| v8::V8::SetFlagsFromCommandLine(argc, argv, true);|'",
- "$(location @v8_crate_146_4_0//:binding_cc)",
- ">",
- '"$@"',
- ]),
-)
-
-copy_file(
- name = "support_h",
- src = "@v8_crate_146_4_0//:support_h",
- out = "support.h",
-)
-
-cc_library(
- name = "v8_146_4_0_binding",
- srcs = [":binding_cc"],
- hdrs = [":support_h"],
- copts = V8_COPTS,
- deps = [
- "@v8//:core_lib_icu",
- "@v8//:rusty_v8_internal_headers",
- ],
-)
-
genrule(
name = "binding_cc_150_4_0",
srcs = ["@v8_crate_150_4_0//:binding_cc"],
@@ -265,88 +205,6 @@ cc_library(
}),
)
-cc_static_library(
- name = "v8_146_4_0_aarch64_apple_darwin_bazel",
- features = V8_STATIC_LIBRARY_FEATURES,
- deps = [":v8_146_4_0_binding"],
-)
-
-cc_static_library(
- name = "v8_146_4_0_aarch64_unknown_linux_gnu_bazel",
- features = V8_STATIC_LIBRARY_FEATURES,
- deps = [":v8_146_4_0_binding"],
-)
-
-cc_static_library(
- name = "v8_146_4_0_aarch64_pc_windows_gnullvm_bazel",
- features = V8_STATIC_LIBRARY_FEATURES,
- deps = [":v8_146_4_0_binding"],
-)
-
-cc_static_library(
- name = "v8_146_4_0_x86_64_apple_darwin_bazel",
- features = V8_STATIC_LIBRARY_FEATURES,
- deps = [":v8_146_4_0_binding"],
-)
-
-cc_static_library(
- name = "v8_146_4_0_x86_64_pc_windows_gnullvm_bazel",
- features = V8_STATIC_LIBRARY_FEATURES,
- deps = [":v8_146_4_0_binding"],
-)
-
-cc_static_library(
- name = "v8_146_4_0_x86_64_unknown_linux_gnu_bazel",
- features = V8_STATIC_LIBRARY_FEATURES,
- deps = [":v8_146_4_0_binding"],
-)
-
-cc_static_library(
- name = "v8_146_4_0_aarch64_unknown_linux_musl_release_base",
- features = V8_STATIC_LIBRARY_FEATURES,
- deps = [":v8_146_4_0_binding"],
-)
-
-genrule(
- name = "v8_146_4_0_aarch64_unknown_linux_musl_release",
- srcs = [
- ":v8_146_4_0_aarch64_unknown_linux_musl_release_base",
- "@llvm//runtimes/compiler-rt:clang_rt.builtins.static",
- ],
- outs = ["libv8_146_4_0_aarch64_unknown_linux_musl.a"],
- cmd = """
- cat > "$(@D)/merge.mri" <<'EOF'
-create $@
-addlib $(location :v8_146_4_0_aarch64_unknown_linux_musl_release_base)
-addlib $(location @llvm//runtimes/compiler-rt:clang_rt.builtins.static)
-save
-end
-EOF
- $(location @llvm//tools:llvm-ar) -M < "$(@D)/merge.mri"
- $(location @llvm//tools:llvm-ranlib) "$@"
- """,
- tools = [
- "@llvm//tools:llvm-ar",
- "@llvm//tools:llvm-ranlib",
- ],
-)
-
-cc_static_library(
- name = "v8_146_4_0_x86_64_unknown_linux_musl_release",
- features = V8_STATIC_LIBRARY_FEATURES,
- deps = [":v8_146_4_0_binding"],
-)
-
-filegroup(
- name = "src_binding_release_aarch64_unknown_linux_musl_release",
- srcs = ["@v8_crate_146_4_0//:src_binding_release_aarch64_unknown_linux_gnu"],
-)
-
-filegroup(
- name = "src_binding_release_x86_64_unknown_linux_musl_release",
- srcs = ["@v8_crate_146_4_0//:src_binding_release_x86_64_unknown_linux_gnu"],
-)
-
cc_static_library(
name = "v8_150_4_0_aarch64_apple_darwin_bazel",
features = V8_STATIC_LIBRARY_FEATURES,