Skip to content

armgit / cogit

Public Imported from GitHub
0

Git for the intent behind agent-written code. Records what your coding agent decided and why, and links every commit to it.

feat(settings): one Save for the whole settings modal

Erenac73de7ac37f
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 41fb6f1..a23609c 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -10,6 +10,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Changed
- A setting's "?" explanation now appears on hover or keyboard focus, floating over the settings, instead of opening on a click inside the row and pushing the rest of the list down.
+- The settings modal has one Save at its bottom instead of one per setting: it saves every changed setting at once, counts the unsaved ones and marks their rows; a value the server refuses keeps its edit and shows why.
## [0.15.0] - 2026-10-27
### Added
diff --git a/packages/template/src/SettingsModal.tsx b/packages/template/src/SettingsModal.tsx
index b17f7f4..8f53eb8 100644
--- a/packages/template/src/SettingsModal.tsx
+++ b/packages/template/src/SettingsModal.tsx
@@ -62,62 +62,41 @@ function FieldDetails({ id, field }: { id: string; field: SettingField }) {
);
}
+/** What a control holds before Save: text for inputs and selects, a flag for a checkbox. */
+type Draft = string | boolean;
+type SettingKey = keyof PanelSettings;
+
+/** The value a draft saves as; a number field sends a number. */
+function draftValue(field: SettingField, draft: Draft): SettingValue {
+ if (field.kind === "boolean") return Boolean(draft);
+ return field.kind === "number" ? Number(draft) : String(draft);
+}
+
+/** Whether a draft still differs from the saved value. */
+function differs(field: SettingField, draft: Draft, value: SettingValue): boolean {
+ return field.kind === "boolean"
+ ? Boolean(draft) !== Boolean(value)
+ : String(draft) !== String(value);
+}
+
interface EditableProps {
id: string;
field: SettingField;
value: SettingValue;
- token: string;
- onSaved: (key: keyof PanelSettings, value: SettingValue) => void;
+ /** The unsaved edit, if any; the control shows it instead of the saved value. */
+ draft: Draft | undefined;
+ error: string | undefined;
+ onChange: (field: SettingField, draft: Draft) => void;
}
/**
- * One editable setting with its control and Save button. The draft follows the
- * parent value, so the live value from `GET /api/config` (or a successful save)
- * is what the form shows.
+ * One editable setting. It holds no state of its own: the dialog keeps every
+ * unsaved edit and saves them together with its single Save button.
*/
-function EditableSetting({ id, field, value, token, onSaved }: EditableProps) {
- const [draft, setDraft] = useState(String(value));
- const [checked, setChecked] = useState(Boolean(value));
- const [saving, setSaving] = useState(false);
- const [status, setStatus] = useState<string | null>(null);
- const [error, setError] = useState<string | null>(null);
-
- useEffect(() => {
- setDraft(String(value));
- setChecked(Boolean(value));
- setSaving(false);
- setError(null);
- }, [value]);
-
- const dirty = field.kind === "boolean" ? checked !== Boolean(value) : draft !== String(value);
-
- /** A new edit supersedes the previous "Saved" / error line. */
- function edited(): void {
- setStatus(null);
- setError(null);
- }
-
- async function submit(event: FormEvent): Promise<void> {
- event.preventDefault();
- if (!dirty || saving) return;
- const next: SettingValue =
- field.kind === "boolean" ? checked : field.kind === "number" ? Number(draft) : draft;
- setSaving(true);
- setStatus(null);
- setError(null);
- try {
- await saveSetting(field.key, next, token);
- onSaved(field.key, next);
- setStatus("Saved");
- } catch (err) {
- setError(err instanceof Error ? err.message : String(err));
- } finally {
- setSaving(false);
- }
- }
-
+function EditableSetting({ id, field, value, draft, error, onChange }: EditableProps) {
+ const shown = draft ?? (field.kind === "boolean" ? Boolean(value) : String(value));
return (
- <div className="settings-field">
+ <div className={draft === undefined ? "settings-field" : "settings-field is-changed"}>
<div className="settings-field-text">
<span className="settings-label">
<label htmlFor={id}>{field.label}</label>
@@ -127,27 +106,21 @@ function EditableSetting({ id, field, value, token, onSaved }: EditableProps) {
{field.help}
</p>
</div>
- <form className="setting-form" onSubmit={submit}>
+ <div className="setting-form">
{field.kind === "boolean" ? (
<input
id={id}
type="checkbox"
- checked={checked}
+ checked={Boolean(shown)}
aria-describedby={`${id}-help`}
- onChange={(event) => {
- setChecked(event.target.checked);
- edited();
- }}
+ onChange={(event) => onChange(field, event.target.checked)}
/>
) : field.kind === "select" ? (
<select
id={id}
- value={draft}
+ value={String(shown)}
aria-describedby={`${id}-help`}
- onChange={(event) => {
- setDraft(event.target.value);
- edited();
- }}
+ onChange={(event) => onChange(field, event.target.value)}
>
{(field.options ?? []).map((option) => (
<option key={option.value} value={option.value}>
@@ -159,20 +132,13 @@ function EditableSetting({ id, field, value, token, onSaved }: EditableProps) {
<input
id={id}
type={field.kind === "number" ? "number" : "text"}
- value={draft}
+ value={String(shown)}
aria-describedby={`${id}-help`}
- onChange={(event) => {
- setDraft(event.target.value);
- edited();
- }}
+ onChange={(event) => onChange(field, event.target.value)}
/>
)}
- <button type="submit" disabled={!dirty || saving}>
- {saving ? "Saving…" : "Save"}
- </button>
- {status ? <span className="setting-status">{status}</span> : null}
{error ? <span className="setting-error">{error}</span> : null}
- </form>
+ </div>
</div>
);
}
@@ -189,6 +155,10 @@ function SettingsDialog({
const [values, setValues] = useState<PanelSettings>(() => withDefaults(embedded));
const [loading, setLoading] = useState(token !== null);
const [loadError, setLoadError] = useState<string | null>(null);
+ const [drafts, setDrafts] = useState<Partial<Record<SettingKey, Draft>>>({});
+ const [errors, setErrors] = useState<Partial<Record<SettingKey, string>>>({});
+ const [saving, setSaving] = useState(false);
+ const [status, setStatus] = useState<string | null>(null);
const closeRef = useRef<HTMLButtonElement>(null);
useEffect(() => {
@@ -224,6 +194,54 @@ function SettingsDialog({
const canEdit = token !== null;
const sections = settingsSections(canEdit);
+ const fields = new Map(sections.flatMap((section) => section.fields).map((f) => [f.key, f]));
+ const changed = Object.keys(drafts) as SettingKey[];
+
+ /** Keeps an edit as a draft, or drops it once it is back at the saved value. */
+ function change(field: SettingField, draft: Draft): void {
+ setDrafts((current) => {
+ const next = { ...current };
+ if (differs(field, draft, values[field.key])) next[field.key] = draft;
+ else delete next[field.key];
+ return next;
+ });
+ setErrors((current) => {
+ const next = { ...current };
+ delete next[field.key];
+ return next;
+ });
+ setStatus(null);
+ }
+
+ /** Saves every changed setting; one that fails keeps its draft and shows why. */
+ async function save(event: FormEvent): Promise<void> {
+ event.preventDefault();
+ if (!token || saving || changed.length === 0) return;
+ setSaving(true);
+ setStatus(null);
+ const failed: Partial<Record<SettingKey, string>> = {};
+ for (const key of changed) {
+ const field = fields.get(key);
+ const draft = drafts[key];
+ if (!field || draft === undefined) continue;
+ const next = draftValue(field, draft);
+ try {
+ await saveSetting(key, next, token);
+ setValues((current) => ({ ...current, [key]: next }));
+ setDrafts((current) => {
+ const rest = { ...current };
+ delete rest[key];
+ return rest;
+ });
+ } catch (err) {
+ failed[key] = err instanceof Error ? err.message : String(err);
+ }
+ }
+ setErrors(failed);
+ const failures = Object.keys(failed).length;
+ setStatus(failures === 0 ? "Saved" : `${failures} not saved`);
+ setSaving(false);
+ }
return (
<div
@@ -258,38 +276,55 @@ function SettingsDialog({
{loading ? <p className="settings-help">Reading the current settings…</p> : null}
{loadError ? <p className="setting-error">{loadError}</p> : null}
- {sections.map((section) => (
- <section key={section.title} className="settings-section" aria-label={section.title}>
- <h3>{section.title}</h3>
- {section.fields.map((field) => {
- const id = `setting-${field.key}`;
- const value = values[field.key];
- return field.editable && token ? (
- <EditableSetting
- key={field.key}
- id={id}
- field={field}
- value={value}
- token={token}
- onSaved={(key, next) => setValues((current) => ({ ...current, [key]: next }))}
- />
- ) : (
- <div key={field.key} className="settings-field">
- <div className="settings-field-text">
- <span className="settings-label">
- {field.label}
- <FieldDetails id={id} field={field} />
- </span>
- <p className="settings-help" id={`${id}-help`}>
- {field.help}
- </p>
+ <form onSubmit={save}>
+ {sections.map((section) => (
+ <section key={section.title} className="settings-section" aria-label={section.title}>
+ <h3>{section.title}</h3>
+ {section.fields.map((field) => {
+ const id = `setting-${field.key}`;
+ const value = values[field.key];
+ return field.editable && token ? (
+ <EditableSetting
+ key={field.key}
+ id={id}
+ field={field}
+ value={value}
+ draft={drafts[field.key]}
+ error={errors[field.key]}
+ onChange={change}
+ />
+ ) : (
+ <div key={field.key} className="settings-field">
+ <div className="settings-field-text">
+ <span className="settings-label">
+ {field.label}
+ <FieldDetails id={id} field={field} />
+ </span>
+ <p className="settings-help" id={`${id}-help`}>
+ {field.help}
+ </p>
+ </div>
+ <span className="settings-value">{formatSetting(value)}</span>
</div>
- <span className="settings-value">{formatSetting(value)}</span>
- </div>
- );
- })}
- </section>
- ))}
+ );
+ })}
+ </section>
+ ))}
+ {canEdit ? (
+ <div className="settings-foot">
+ <span className="setting-status" role="status">
+ {saving
+ ? "Saving…"
+ : changed.length > 0
+ ? `${changed.length} unsaved ${changed.length === 1 ? "change" : "changes"}`
+ : (status ?? "")}
+ </span>
+ <button type="submit" disabled={changed.length === 0 || saving}>
+ Save
+ </button>
+ </div>
+ ) : null}
+ </form>
</div>
</div>
);
diff --git a/packages/template/src/styles.css b/packages/template/src/styles.css
index e613553..6cb27f6 100644
--- a/packages/template/src/styles.css
+++ b/packages/template/src/styles.css
@@ -2228,6 +2228,26 @@ time {
margin: 0;
}
+/* The one Save of the modal, pinned to its bottom edge while the list scrolls. */
+.settings-foot {
+ position: sticky;
+ bottom: -22px;
+ display: flex;
+ align-items: center;
+ justify-content: flex-end;
+ gap: 12px;
+ margin: 8px -20px -22px;
+ padding: 12px 20px;
+ background: var(--panel);
+ border-top: 1px solid var(--line);
+}
+
+.settings-field.is-changed .settings-label::after {
+ content: "•";
+ color: var(--accent, var(--text));
+}
+
+.settings-foot button,
.setting-form button {
padding: 3px 10px;
color: var(--text);
@@ -2239,6 +2259,7 @@ time {
cursor: pointer;
}
+.settings-foot button:disabled,
.setting-form button:disabled {
opacity: 0.45;
cursor: default;