Skip to content

Open-source and local-first Slack and Notion alternative that puts you in control of your data

Fix button types

Hakan Shehu302a2a1ebec9
diff --git a/desktop/src/renderer/components/channels/channel-create-dialog.tsx b/desktop/src/renderer/components/channels/channel-create-dialog.tsx
index c715e97e..f410f5ba 100644
--- a/desktop/src/renderer/components/channels/channel-create-dialog.tsx
+++ b/desktop/src/renderer/components/channels/channel-create-dialog.tsx
@@ -105,6 +105,7 @@ export const ChannelCreateDialog = ({
</div>
<DialogFooter>
<Button
+ type="button"
variant="outline"
disabled={isPending}
onClick={handleCancel}
diff --git a/desktop/src/renderer/components/databases/database-create-dialog.tsx b/desktop/src/renderer/components/databases/database-create-dialog.tsx
index 4327fdf7..0b17df7a 100644
--- a/desktop/src/renderer/components/databases/database-create-dialog.tsx
+++ b/desktop/src/renderer/components/databases/database-create-dialog.tsx
@@ -100,7 +100,7 @@ export const DatabaseCreateDialog = ({
/>
</div>
<DialogFooter>
- <Button variant="outline" onClick={handleCancel}>
+ <Button type="button" variant="outline" onClick={handleCancel}>
Cancel
</Button>
<Button type="submit" disabled={isPending}>
diff --git a/desktop/src/renderer/components/databases/fields/field-create-popover.tsx b/desktop/src/renderer/components/databases/fields/field-create-popover.tsx
index d2342f50..cec681ec 100644
--- a/desktop/src/renderer/components/databases/fields/field-create-popover.tsx
+++ b/desktop/src/renderer/components/databases/fields/field-create-popover.tsx
@@ -128,7 +128,12 @@ export const FieldCreatePopover = () => {
<FieldAttrs />
</div>
<div className="mt-2 flex flex-col-reverse sm:flex-row sm:justify-end sm:space-x-2">
- <Button variant="outline" size="sm" onClick={handleCancelClick}>
+ <Button
+ type="button"
+ variant="outline"
+ size="sm"
+ onClick={handleCancelClick}
+ >
Cancel
</Button>
<Button type="submit" size="sm" disabled={isPending}>
diff --git a/desktop/src/renderer/components/databases/fields/field-select.tsx b/desktop/src/renderer/components/databases/fields/field-select.tsx
index 50127ca3..5667fe6d 100644
--- a/desktop/src/renderer/components/databases/fields/field-select.tsx
+++ b/desktop/src/renderer/components/databases/fields/field-select.tsx
@@ -32,6 +32,7 @@ export const FieldSelect = ({ fields, value, onChange }: FieldSelectProps) => {
<Popover open={open} onOpenChange={setOpen} modal={true}>
<PopoverTrigger asChild>
<Button
+ type="button"
variant="outline"
role="combobox"
aria-expanded={open}
diff --git a/desktop/src/renderer/components/databases/fields/field-type-select.tsx b/desktop/src/renderer/components/databases/fields/field-type-select.tsx
index caa52e2b..c6f06a0b 100644
--- a/desktop/src/renderer/components/databases/fields/field-type-select.tsx
+++ b/desktop/src/renderer/components/databases/fields/field-type-select.tsx
@@ -93,6 +93,7 @@ export const FieldDataTypeSelect = ({
<Popover open={open} onOpenChange={setOpen} modal={true}>
<PopoverTrigger asChild>
<Button
+ type="button"
variant="outline"
role="combobox"
aria-expanded={open}
diff --git a/desktop/src/renderer/components/databases/search/view-boolean-field-filter.tsx b/desktop/src/renderer/components/databases/search/view-boolean-field-filter.tsx
index 7b9ee117..8ebe4200 100644
--- a/desktop/src/renderer/components/databases/search/view-boolean-field-filter.tsx
+++ b/desktop/src/renderer/components/databases/search/view-boolean-field-filter.tsx
@@ -45,6 +45,7 @@ export const ViewBooleanFieldFilter = ({
>
<PopoverTrigger asChild>
<Button
+ type="button"
variant="outline"
size="sm"
className="border-dashed text-xs text-muted-foreground"
diff --git a/desktop/src/renderer/components/databases/search/view-created-at-field-fitler.tsx b/desktop/src/renderer/components/databases/search/view-created-at-field-fitler.tsx
index e51a845e..fc4fada5 100644
--- a/desktop/src/renderer/components/databases/search/view-created-at-field-fitler.tsx
+++ b/desktop/src/renderer/components/databases/search/view-created-at-field-fitler.tsx
@@ -49,6 +49,7 @@ export const ViewCreatedAtFieldFilter = ({
>
<PopoverTrigger asChild>
<Button
+ type="button"
variant="outline"
size="sm"
className="border-dashed text-xs text-muted-foreground"
diff --git a/desktop/src/renderer/components/databases/search/view-date-field-filter.tsx b/desktop/src/renderer/components/databases/search/view-date-field-filter.tsx
index ada61ea5..db3e20ca 100644
--- a/desktop/src/renderer/components/databases/search/view-date-field-filter.tsx
+++ b/desktop/src/renderer/components/databases/search/view-date-field-filter.tsx
@@ -52,6 +52,7 @@ export const ViewDateFieldFilter = ({
>
<PopoverTrigger asChild>
<Button
+ type="button"
variant="outline"
size="sm"
className="border-dashed text-xs text-muted-foreground"
diff --git a/desktop/src/renderer/components/databases/search/view-email-field-filter.tsx b/desktop/src/renderer/components/databases/search/view-email-field-filter.tsx
index 35e92dc4..5f6e4c71 100644
--- a/desktop/src/renderer/components/databases/search/view-email-field-filter.tsx
+++ b/desktop/src/renderer/components/databases/search/view-email-field-filter.tsx
@@ -51,6 +51,7 @@ export const ViewEmailFieldFilter = ({
>
<PopoverTrigger asChild>
<Button
+ type="button"
variant="outline"
size="sm"
className="border-dashed text-xs text-muted-foreground"
diff --git a/desktop/src/renderer/components/databases/search/view-multi-select-field-filter.tsx b/desktop/src/renderer/components/databases/search/view-multi-select-field-filter.tsx
index 23db9f65..ee656820 100644
--- a/desktop/src/renderer/components/databases/search/view-multi-select-field-filter.tsx
+++ b/desktop/src/renderer/components/databases/search/view-multi-select-field-filter.tsx
@@ -55,6 +55,7 @@ export const ViewMultiSelectFieldFilter = ({
>
<PopoverTrigger asChild>
<Button
+ type="button"
variant="outline"
size="sm"
className="border-dashed text-xs text-muted-foreground"
diff --git a/desktop/src/renderer/components/databases/search/view-number-field-filter.tsx b/desktop/src/renderer/components/databases/search/view-number-field-filter.tsx
index f0091f8c..27bfff85 100644
--- a/desktop/src/renderer/components/databases/search/view-number-field-filter.tsx
+++ b/desktop/src/renderer/components/databases/search/view-number-field-filter.tsx
@@ -51,6 +51,7 @@ export const ViewNumberFieldFilter = ({
>
<PopoverTrigger asChild>
<Button
+ type="button"
variant="outline"
size="sm"
className="border-dashed text-xs text-muted-foreground"
diff --git a/desktop/src/renderer/components/databases/search/view-phone-field-filter.tsx b/desktop/src/renderer/components/databases/search/view-phone-field-filter.tsx
index 6bf96128..8411e666 100644
--- a/desktop/src/renderer/components/databases/search/view-phone-field-filter.tsx
+++ b/desktop/src/renderer/components/databases/search/view-phone-field-filter.tsx
@@ -51,6 +51,7 @@ export const ViewPhoneFieldFilter = ({
>
<PopoverTrigger asChild>
<Button
+ type="button"
variant="outline"
size="sm"
className="border-dashed text-xs text-muted-foreground"
diff --git a/desktop/src/renderer/components/databases/search/view-select-field-filter.tsx b/desktop/src/renderer/components/databases/search/view-select-field-filter.tsx
index 7af67cad..760b15e3 100644
--- a/desktop/src/renderer/components/databases/search/view-select-field-filter.tsx
+++ b/desktop/src/renderer/components/databases/search/view-select-field-filter.tsx
@@ -55,6 +55,7 @@ export const ViewSelectFieldFilter = ({
>
<PopoverTrigger asChild>
<Button
+ type="button"
variant="outline"
size="sm"
className="border-dashed text-xs text-muted-foreground"
diff --git a/desktop/src/renderer/components/databases/search/view-sorts.tsx b/desktop/src/renderer/components/databases/search/view-sorts.tsx
index 40c646f1..c5f328ef 100644
--- a/desktop/src/renderer/components/databases/search/view-sorts.tsx
+++ b/desktop/src/renderer/components/databases/search/view-sorts.tsx
@@ -28,6 +28,7 @@ export const ViewSorts = () => {
>
<PopoverTrigger asChild>
<Button
+ type="button"
variant="outline"
size="sm"
className="border-dashed text-xs text-muted-foreground"
diff --git a/desktop/src/renderer/components/databases/search/view-text-field-filter.tsx b/desktop/src/renderer/components/databases/search/view-text-field-filter.tsx
index a8ab34de..6f023ba6 100644
--- a/desktop/src/renderer/components/databases/search/view-text-field-filter.tsx
+++ b/desktop/src/renderer/components/databases/search/view-text-field-filter.tsx
@@ -51,6 +51,7 @@ export const ViewTextFieldFilter = ({
>
<PopoverTrigger asChild>
<Button
+ type="button"
variant="outline"
size="sm"
className="border-dashed text-xs text-muted-foreground"
diff --git a/desktop/src/renderer/components/databases/search/view-url-field-filter.tsx b/desktop/src/renderer/components/databases/search/view-url-field-filter.tsx
index aec30a2b..944be32f 100644
--- a/desktop/src/renderer/components/databases/search/view-url-field-filter.tsx
+++ b/desktop/src/renderer/components/databases/search/view-url-field-filter.tsx
@@ -51,6 +51,7 @@ export const ViewUrlFieldFilter = ({
>
<PopoverTrigger asChild>
<Button
+ type="button"
variant="outline"
size="sm"
className="border-dashed text-xs text-muted-foreground"
diff --git a/desktop/src/renderer/components/databases/tables/table-view-settings-popover.tsx b/desktop/src/renderer/components/databases/tables/table-view-settings-popover.tsx
index 3b820a4e..f9522fab 100644
--- a/desktop/src/renderer/components/databases/tables/table-view-settings-popover.tsx
+++ b/desktop/src/renderer/components/databases/tables/table-view-settings-popover.tsx
@@ -64,7 +64,7 @@ export const TableViewSettingsPopover = () => {
});
}}
>
- <Button variant="outline" size="icon">
+ <Button type="button" variant="outline" size="icon">
<Avatar
id={tableView.id}
name={tableView.name}
diff --git a/desktop/src/renderer/components/databases/view-create-dialog.tsx b/desktop/src/renderer/components/databases/view-create-dialog.tsx
index 5b14d53e..583c1641 100644
--- a/desktop/src/renderer/components/databases/view-create-dialog.tsx
+++ b/desktop/src/renderer/components/databases/view-create-dialog.tsx
@@ -253,7 +253,7 @@ export const ViewCreateDialog = ({
)}
</div>
<DialogFooter>
- <Button variant="outline" onClick={handleCancel}>
+ <Button type="button" variant="outline" onClick={handleCancel}>
Cancel
</Button>
<Button type="submit" disabled={isPending}>
diff --git a/desktop/src/renderer/components/folders/folder-container.tsx b/desktop/src/renderer/components/folders/folder-container.tsx
index ac440d59..cac6103f 100644
--- a/desktop/src/renderer/components/folders/folder-container.tsx
+++ b/desktop/src/renderer/components/folders/folder-container.tsx
@@ -71,18 +71,18 @@ export const FolderContainer = ({ nodeId }: FolderContainerProps) => {
<div className="flex h-full max-h-full flex-col gap-4 overflow-y-auto px-10 pt-4">
<div className="flex flex-row justify-between">
<div className="flex flex-row gap-2">
- <Button variant="outline" onClick={openFileDialog}>
+ <Button type="button" variant="outline" onClick={openFileDialog}>
<Icon name="upload-line" className="mr-1" /> Upload
</Button>
</div>
<div className="flex flex-row gap-2">
- <Button variant="outline" size="icon" disabled>
+ <Button type="button" variant="outline" size="icon" disabled>
<Icon name="filter-line" />
</Button>
<DropdownMenu>
<DropdownMenuTrigger asChild>
- <Button variant="outline" size="icon">
+ <Button type="button" variant="outline" size="icon">
<Icon name={currentLayout?.icon} />
</Button>
</DropdownMenuTrigger>
diff --git a/desktop/src/renderer/components/folders/folder-create-dialog.tsx b/desktop/src/renderer/components/folders/folder-create-dialog.tsx
index aec924ff..a02358c7 100644
--- a/desktop/src/renderer/components/folders/folder-create-dialog.tsx
+++ b/desktop/src/renderer/components/folders/folder-create-dialog.tsx
@@ -101,7 +101,7 @@ export const FolderCreateDialog = ({
/>
</div>
<DialogFooter>
- <Button variant="outline" onClick={handleCancel}>
+ <Button type="button" variant="outline" onClick={handleCancel}>
Cancel
</Button>
<Button type="submit" disabled={isPending}>
diff --git a/desktop/src/renderer/components/pages/page-create-dialog.tsx b/desktop/src/renderer/components/pages/page-create-dialog.tsx
index ff9e8d32..3ac9f6a5 100644
--- a/desktop/src/renderer/components/pages/page-create-dialog.tsx
+++ b/desktop/src/renderer/components/pages/page-create-dialog.tsx
@@ -101,7 +101,7 @@ export const PageCreateDialog = ({
/>
</div>
<DialogFooter>
- <Button variant="outline" onClick={handleCancel}>
+ <Button type="button" variant="outline" onClick={handleCancel}>
Cancel
</Button>
<Button type="submit" disabled={isPending}>
diff --git a/desktop/src/renderer/components/servers/server-create-dialog.tsx b/desktop/src/renderer/components/servers/server-create-dialog.tsx
index 8748005c..315ba5bb 100644
--- a/desktop/src/renderer/components/servers/server-create-dialog.tsx
+++ b/desktop/src/renderer/components/servers/server-create-dialog.tsx
@@ -42,7 +42,11 @@ export const ServerCreateDialog = ({
/>
</div>
<DialogFooter>
- <Button variant="outline" onClick={() => onOpenChange(false)}>
+ <Button
+ type="button"
+ variant="outline"
+ onClick={() => onOpenChange(false)}
+ >
Cancel
</Button>
<Button
diff --git a/desktop/src/renderer/components/spaces/space-create-dialog.tsx b/desktop/src/renderer/components/spaces/space-create-dialog.tsx
index 62d40311..a588c862 100644
--- a/desktop/src/renderer/components/spaces/space-create-dialog.tsx
+++ b/desktop/src/renderer/components/spaces/space-create-dialog.tsx
@@ -56,6 +56,14 @@ export const SpaceCreateDialog = ({
};
const handleSubmit = async (values: z.infer<typeof formSchema>) => {
+ if (isPending) {
+ return;
+ }
+
+ if (values.name.length < 3) {
+ return;
+ }
+
mutate({
input: {
type: 'space_create',
@@ -116,7 +124,7 @@ export const SpaceCreateDialog = ({
/>
</div>
<DialogFooter>
- <Button variant="outline" onClick={handleCancel}>
+ <Button type="button" variant="outline" onClick={handleCancel}>
Cancel
</Button>
<Button type="submit" disabled={isPending}>
diff --git a/desktop/src/renderer/components/spaces/space-update-form.tsx b/desktop/src/renderer/components/spaces/space-update-form.tsx
index 1e801602..6e60e7c5 100644
--- a/desktop/src/renderer/components/spaces/space-update-form.tsx
+++ b/desktop/src/renderer/components/spaces/space-update-form.tsx
@@ -106,7 +106,7 @@ export const SpaceUpdateForm = ({ id }: SpaceUpdateFormProps) => {
<div className="space-y-4 pb-4">
<div className="flex flex-row items-end gap-4">
<AvatarPopover onPick={(avatar) => form.setValue('avatar', avatar)}>
- <Button variant="outline" size="icon">
+ <Button type="button" variant="outline" size="icon">
<Avatar
id={id}
name={name}
diff --git a/desktop/src/renderer/components/workspaces/containers/breadcrumb-item-popover.tsx b/desktop/src/renderer/components/workspaces/containers/breadcrumb-item-popover.tsx
index e7398407..4a40ef6d 100644
--- a/desktop/src/renderer/components/workspaces/containers/breadcrumb-item-popover.tsx
+++ b/desktop/src/renderer/components/workspaces/containers/breadcrumb-item-popover.tsx
@@ -43,7 +43,7 @@ export const BreadcrumbItemPopover = ({
});
}}
>
- <Button variant="outline" size="icon">
+ <Button type="button" variant="outline" size="icon">
<Avatar
size="small"
id={node.id}