Open-source and local-first Slack and Notion alternative that puts you in control of your data
TypeScript chatchat-applicationcrdteditorelectronknowledge-baselocal-firstnotionnotion-alternativerealtime-collaborationself-hostedslacksqliteteam-collaborationwikiyjs
Fix internal link handling in editor (#315)
Hakan Shehu60ccfe79408f
diff --git a/packages/ui/src/editor/extensions/link.tsx b/packages/ui/src/editor/extensions/link.tsxindex cdd1200a..7fb097e8 100644--- a/packages/ui/src/editor/extensions/link.tsx+++ b/packages/ui/src/editor/extensions/link.tsx@@ -23,22 +23,27 @@ export const LinkMark = Link.extend({props: {handleClick: (_, __, event) => {// Don't handle clicks on links that are created and handled by Tanstack Router+ // Find the link element that is closest to the target - based on the original Tiptap link implementationlet link: HTMLAnchorElement | null = null;if (event.target instanceof HTMLAnchorElement) {link = event.target;} else {- let a = event.target as HTMLElement;- const els = [];+ const target = event.target as HTMLElement | null;+ if (!target) {+ return false;+ }++ const root = this.editor.view.dom;++ // Tntentionally limit the lookup to the editor root.+ // Using tag names like DIV as boundaries breaks with custom NodeViews,+ link = target.closest<HTMLAnchorElement>('a');- while (a.nodeName !== 'DIV') {- els.push(a);- a = a.parentNode as HTMLElement;+ if (link && !root.contains(link)) {+ link = null;}- link = els.find(- (value) => value.nodeName === 'A'- ) as HTMLAnchorElement;}if (!link) {