Skip to content

Open-source and local-first Slack and Notion alternative that puts you in control of your data

Wrap the queue name in curly braces to handle Redis clusters in Bullmq

Hakan Shehu6a4f14f8b89a
diff --git a/apps/server/src/services/job-service.ts b/apps/server/src/services/job-service.ts
index 23eda3c7..dc40e207 100644
--- a/apps/server/src/services/job-service.ts
+++ b/apps/server/src/services/job-service.ts
@@ -3,17 +3,28 @@ import { Job, JobsOptions, Queue, Worker } from 'bullmq';
import { configuration } from '@/lib/configuration';
import { jobHandlerMap } from '@/jobs';
import { JobHandler, JobInput } from '@/types/jobs';
+import { createLogger } from '@/lib/logger';
+
+const logger = createLogger('job-service');
class JobService {
private jobQueue: Queue | undefined;
private jobWorker: Worker | undefined;
+ // Bullmq performs atomic operations across different keys, which can cause
+ // issues with Redis clusters, so we wrap the queue name in curly braces to
+ // ensure that all keys are in the same slot (Redis node)
+
+ // for more information, see: https://docs.bullmq.io/bull/patterns/redis-cluster
+
+ private readonly queueName = `{${configuration.redis.jobsQueueName}}`;
+
public initQueue() {
if (this.jobQueue) {
return;
}
- this.jobQueue = new Queue(configuration.redis.jobsQueueName, {
+ this.jobQueue = new Queue(this.queueName, {
connection: {
db: configuration.redis.db,
url: configuration.redis.url,
@@ -24,7 +35,7 @@ class JobService {
});
this.jobQueue.on('error', (error) => {
- console.error('Job queue error:', error);
+ logger.error(error, 'Job queue error');
});
}
@@ -33,16 +44,12 @@ class JobService {
return;
}
- this.jobWorker = new Worker(
- configuration.redis.jobsQueueName,
- this.handleJobJob,
- {
- connection: {
- url: configuration.redis.url,
- db: configuration.redis.db,
- },
- }
- );
+ this.jobWorker = new Worker(this.queueName, this.handleJobJob, {
+ connection: {
+ url: configuration.redis.url,
+ db: configuration.redis.db,
+ },
+ });
}
public async addJob(job: JobInput, options?: JobsOptions) {