Skip to content

Open-source and local-first Slack and Notion alternative that puts you in control of your data

Fix page create name, sidebar items ordering and name popover placeholder

Hakan Shehud8cc99efdf1a
diff --git a/desktop/src/main/handlers/mutations/page-create.ts b/desktop/src/main/handlers/mutations/page-create.ts
index d42ef658..3b14b97a 100644
--- a/desktop/src/main/handlers/mutations/page-create.ts
+++ b/desktop/src/main/handlers/mutations/page-create.ts
@@ -45,6 +45,7 @@ export class PageCreateMutationHandler
type: NodeTypes.Page,
parentId: input.parentId,
index: index,
+ name: input.name,
},
},
input.userId,
diff --git a/desktop/src/main/handlers/queries/sidebar-space-list.ts b/desktop/src/main/handlers/queries/sidebar-space-list.ts
index bb2ac38d..d348eb60 100644
--- a/desktop/src/main/handlers/queries/sidebar-space-list.ts
+++ b/desktop/src/main/handlers/queries/sidebar-space-list.ts
@@ -13,6 +13,7 @@ import { mapNode } from '@/lib/nodes';
import { LocalNode } from '@/types/nodes';
import { MutationChange } from '@/operations/mutations';
import { isEqual } from 'lodash';
+import { compareString } from '@/lib/utils';
export class SidebarSpaceListQueryHandler
implements QueryHandler<SidebarSpaceListQueryInput>
@@ -101,7 +102,10 @@ export class SidebarSpaceListQueryHandler
continue;
}
- const children = nodes.filter((n) => n.parentId === node.id);
+ const children = nodes
+ .filter((n) => n.parentId === node.id)
+ .sort((a, b) => compareString(a.index, b.index));
+
spaces.push(this.buildSpaceNode(node, children));
}
diff --git a/desktop/src/renderer/components/workspaces/containers/breadcrumb-item-popover.tsx b/desktop/src/renderer/components/workspaces/containers/breadcrumb-item-popover.tsx
index dff819a0..e7398407 100644
--- a/desktop/src/renderer/components/workspaces/containers/breadcrumb-item-popover.tsx
+++ b/desktop/src/renderer/components/workspaces/containers/breadcrumb-item-popover.tsx
@@ -54,6 +54,7 @@ export const BreadcrumbItemPopover = ({
</AvatarPopover>
<SmartTextInput
value={node.name}
+ placeholder="Unnamed"
onChange={(newName) => {
if (isPending) return;
if (newName === node.name) return;