Colota - Android GPS Location tracker
Harden app security: restrict cleartext traffic, validate deep link imports, narrow ProGuard rules
Max Dietrich22b35a33add9
diff --git a/apps/mobile/android/app/proguard-rules.pro b/apps/mobile/android/app/proguard-rules.proindex 9180409b..235b117f 100644--- a/apps/mobile/android/app/proguard-rules.pro+++ b/apps/mobile/android/app/proguard-rules.pro@@ -11,7 +11,10 @@-keep class com.facebook.react.bridge.** { *; }-keep class com.facebook.react.modules.core.DeviceEventManagerModule$RCTDeviceEventEmitter { *; }--keep class com.Colota.** { *; }+# Keep classes accessed via React Native bridge and reflection+-keep class com.Colota.bridge.** { *; }+-keep class com.Colota.MainApplication { *; }+-keep class com.Colota.MainActivity { *; }# Keep Google Play Services Location (only present in gms flavor)-keep class com.google.android.gms.location.** { *; }diff --git a/apps/mobile/android/app/src/main/AndroidManifest.xml b/apps/mobile/android/app/src/main/AndroidManifest.xmlindex 3378d090..e94ac9eb 100644--- a/apps/mobile/android/app/src/main/AndroidManifest.xml+++ b/apps/mobile/android/app/src/main/AndroidManifest.xml@@ -40,8 +40,7 @@android:allowBackup="false"android:theme="@style/AppTheme"android:supportsRtl="true"- android:networkSecurityConfig="@xml/network_security_config"- android:usesCleartextTraffic="true">+ android:networkSecurityConfig="@xml/network_security_config"><activityandroid:name=".MainActivity"diff --git a/apps/mobile/android/app/src/main/java/com/colota/data/DatabaseHelper.kt b/apps/mobile/android/app/src/main/java/com/colota/data/DatabaseHelper.ktindex b99ee39c..1a305538 100644--- a/apps/mobile/android/app/src/main/java/com/colota/data/DatabaseHelper.kt+++ b/apps/mobile/android/app/src/main/java/com/colota/data/DatabaseHelper.kt@@ -19,6 +19,13 @@ import org.json.JSONObject/*** SQLite database helper for Colota location tracking.+ *+ * SECURITY NOTE: The database is NOT encrypted. Location history (coordinates,+ * timestamps, battery) is stored in plaintext. This is a known limitation —+ * an attacker with physical device access or root could read the data.+ * Migrating to SQLCipher would address this but adds APK size (~3 MB) and+ * a performance cost. Auth credentials are stored separately in+ * EncryptedSharedPreferences (see SecureStorageHelper).*/class DatabaseHelper private constructor(context: Context) :SQLiteOpenHelper(context, DATABASE_NAME, null, DATABASE_VERSION) {diff --git a/apps/mobile/android/app/src/main/java/com/colota/util/FileOperations.kt b/apps/mobile/android/app/src/main/java/com/colota/util/FileOperations.ktindex 2750009e..7d3058ef 100644--- a/apps/mobile/android/app/src/main/java/com/colota/util/FileOperations.kt+++ b/apps/mobile/android/app/src/main/java/com/colota/util/FileOperations.kt@@ -87,7 +87,7 @@ class FileOperations(private val context: ReactApplicationContext) {*/fun deleteFile(filePath: String) {val file = File(filePath)- if (file.exists()) {+ if (file.canonicalPath.startsWith(context.cacheDir.canonicalPath) && file.exists()) {file.delete()}}diff --git a/apps/mobile/android/app/src/main/res/xml/network_security_config.xml b/apps/mobile/android/app/src/main/res/xml/network_security_config.xmlindex 81a69d96..9e786278 100644--- a/apps/mobile/android/app/src/main/res/xml/network_security_config.xml+++ b/apps/mobile/android/app/src/main/res/xml/network_security_config.xml@@ -1,6 +1,14 @@<?xml version="1.0" encoding="utf-8"?><network-security-config>- <!-- Allow cleartext HTTP for self-hosted servers on local networks -->+ <!--+ Cleartext HTTP is permitted here because Android's network_security_config+ does not support IP-range matching (CIDR), and users need HTTP access to+ self-hosted servers on private networks (10.x.x.x, 192.168.x.x, 172.16-31.x.x).++ Actual enforcement happens at the app level:+ - NetworkManager.isValidProtocol() restricts HTTP to private hosts+ - settingsValidation.isEndpointAllowed() blocks public HTTP endpoints in the UI+ --><base-config cleartextTrafficPermitted="true"><trust-anchors><certificates src="system" />diff --git a/apps/mobile/src/screens/SetupImportScreen.tsx b/apps/mobile/src/screens/SetupImportScreen.tsxindex 82263f83..b1a0c4f9 100644--- a/apps/mobile/src/screens/SetupImportScreen.tsx+++ b/apps/mobile/src/screens/SetupImportScreen.tsx@@ -11,6 +11,7 @@ import { Container, Card, Button, SectionTitle } from "../components"import { fonts } from "../styles/typography"import { CircleAlert, CircleCheck, Import } from "lucide-react-native"import SettingsService from "../services/SettingsService"+import { isEndpointAllowed } from "../utils/settingsValidation"import NativeLocationService from "../services/NativeLocationService"import { showAlert } from "../services/modalService"import { logger } from "../utils/logger"@@ -40,6 +41,7 @@ interface ConfigEntry {label: stringvalue: stringcategory: "tracking" | "api" | "auth"+ rejected?: boolean}interface ValidationResult {@@ -84,8 +86,12 @@ function validateConfig(raw: unknown): ValidationResult {// --- API settings (endpoint) ---if ("endpoint" in obj && typeof obj.endpoint === "string" && obj.endpoint.length > 0) {- settings.endpoint = obj.endpoint- entries.push({ label: "Endpoint", value: obj.endpoint, category: "api" })+ if (isEndpointAllowed(obj.endpoint)) {+ settings.endpoint = obj.endpoint+ entries.push({ label: "Endpoint", value: obj.endpoint, category: "api" })+ } else {+ entries.push({ label: "Endpoint", value: "HTTP not allowed for public hosts", category: "api", rejected: true })+ }}// --- Tracking settings ---@@ -332,8 +338,13 @@ export function SetupImportScreen({ route, navigation }: any) {i < entries.length - 1 && { borderBottomColor: colors.border }]}>- <Text style={[styles.settingLabel, { color: colors.textSecondary }]}>{entry.label}</Text>- <Text style={[styles.settingValue, { color: colors.text }]} numberOfLines={1}>+ <Text style={[styles.settingLabel, { color: entry.rejected ? colors.error : colors.textSecondary }]}>+ {entry.label}+ </Text>+ <Text+ style={[styles.settingValue, { color: entry.rejected ? colors.error : colors.text }]}+ numberOfLines={1}+ >{entry.value}</Text></View>