Colota - Android GPS Location tracker
Add tests for ApiSettingsScreen, AuthSettingsScreen, and SyncStrategySettings blur behavior
Max Dietrichbf497acedcc1
diff --git a/apps/mobile/src/components/features/settings/__tests__/SyncStrategySettings.test.tsx b/apps/mobile/src/components/features/settings/__tests__/SyncStrategySettings.test.tsxindex d2ca0398..1563d060 100644--- a/apps/mobile/src/components/features/settings/__tests__/SyncStrategySettings.test.tsx+++ b/apps/mobile/src/components/features/settings/__tests__/SyncStrategySettings.test.tsx@@ -260,4 +260,141 @@ describe("SyncStrategySettings", () => {expect(queryByText("Accuracy Threshold")).toBeNull()})})++ describe("numeric input blur behavior", () => {+ it("clamps interval to min 1 on blur when value is 0", () => {+ const { getByText, getByDisplayValue } = renderComponent({+ interval: 5,+ syncPreset: "custom"+ })++ fireEvent.press(getByText("+ Show Advanced Settings"))++ const intervalInput = getByDisplayValue("5")+ fireEvent.changeText(intervalInput, "0")+ fireEvent(intervalInput, "blur")++ // Should clamp to 1 and call onSettingsChange + onImmediateSave+ expect(mockOnSettingsChange).toHaveBeenCalledWith(expect.objectContaining({ interval: 1 }))+ expect(mockOnImmediateSave).toHaveBeenCalledWith(expect.objectContaining({ interval: 1 }))+ })++ it("clamps interval to min 1 on blur when value is negative", () => {+ const { getByText, getByDisplayValue } = renderComponent({+ interval: 5,+ syncPreset: "custom"+ })++ fireEvent.press(getByText("+ Show Advanced Settings"))++ const intervalInput = getByDisplayValue("5")+ fireEvent.changeText(intervalInput, "-3")+ fireEvent(intervalInput, "blur")++ expect(mockOnSettingsChange).toHaveBeenCalledWith(expect.objectContaining({ interval: 1 }))+ expect(mockOnImmediateSave).toHaveBeenCalledWith(expect.objectContaining({ interval: 1 }))+ })++ it("clamps interval to min 1 on blur when value is NaN", () => {+ const { getByText, getByDisplayValue } = renderComponent({+ interval: 5,+ syncPreset: "custom"+ })++ fireEvent.press(getByText("+ Show Advanced Settings"))++ const intervalInput = getByDisplayValue("5")+ fireEvent.changeText(intervalInput, "abc")+ fireEvent(intervalInput, "blur")++ expect(mockOnSettingsChange).toHaveBeenCalledWith(expect.objectContaining({ interval: 1 }))+ expect(mockOnImmediateSave).toHaveBeenCalledWith(expect.objectContaining({ interval: 1 }))+ })++ it("does not clamp interval on blur when value is valid", () => {+ const { getByText, getByDisplayValue } = renderComponent({+ interval: 5,+ syncPreset: "custom"+ })++ fireEvent.press(getByText("+ Show Advanced Settings"))++ const intervalInput = getByDisplayValue("5")+ fireEvent.changeText(intervalInput, "10")+ fireEvent(intervalInput, "blur")++ // Valid value — onSettingsChange should only have been called from changeText (debounced save),+ // not from blur (no clamping needed)+ expect(mockOnImmediateSave).not.toHaveBeenCalled()+ })++ it("clamps distance to min 0 on blur when value is negative", () => {+ const { getByText, getByDisplayValue } = renderComponent({+ interval: 5,+ distance: 10,+ syncPreset: "custom"+ })++ fireEvent.press(getByText("+ Show Advanced Settings"))++ const distanceInput = getByDisplayValue("10")+ fireEvent.changeText(distanceInput, "-5")+ fireEvent(distanceInput, "blur")++ expect(mockOnSettingsChange).toHaveBeenCalledWith(expect.objectContaining({ distance: 0 }))+ expect(mockOnImmediateSave).toHaveBeenCalledWith(expect.objectContaining({ distance: 0 }))+ })++ it("clamps distance to min 0 on blur when value is NaN", () => {+ const { getByText, getByDisplayValue } = renderComponent({+ interval: 5,+ distance: 10,+ syncPreset: "custom"+ })++ fireEvent.press(getByText("+ Show Advanced Settings"))++ const distanceInput = getByDisplayValue("10")+ fireEvent.changeText(distanceInput, "abc")+ fireEvent(distanceInput, "blur")++ expect(mockOnSettingsChange).toHaveBeenCalledWith(expect.objectContaining({ distance: 0 }))+ expect(mockOnImmediateSave).toHaveBeenCalledWith(expect.objectContaining({ distance: 0 }))+ })++ it("clamps accuracy threshold to min 50 on blur when value is below", () => {+ const { getByText, getByDisplayValue } = renderComponent({+ interval: 5,+ filterInaccurateLocations: true,+ accuracyThreshold: 100,+ syncPreset: "custom"+ })++ fireEvent.press(getByText("+ Show Advanced Settings"))++ const thresholdInput = getByDisplayValue("100")+ fireEvent.changeText(thresholdInput, "10")+ fireEvent(thresholdInput, "blur")++ expect(mockOnSettingsChange).toHaveBeenCalledWith(expect.objectContaining({ accuracyThreshold: 50 }))+ expect(mockOnImmediateSave).toHaveBeenCalledWith(expect.objectContaining({ accuracyThreshold: 50 }))+ })++ it("does not clamp accuracy threshold on blur when value is valid", () => {+ const { getByText, getByDisplayValue } = renderComponent({+ interval: 5,+ filterInaccurateLocations: true,+ accuracyThreshold: 100,+ syncPreset: "custom"+ })++ fireEvent.press(getByText("+ Show Advanced Settings"))++ const thresholdInput = getByDisplayValue("100")+ fireEvent.changeText(thresholdInput, "200")+ fireEvent(thresholdInput, "blur")++ expect(mockOnImmediateSave).not.toHaveBeenCalled()+ })+ })})diff --git a/apps/mobile/src/screens/__tests__/ApiSettingsScreen.test.tsx b/apps/mobile/src/screens/__tests__/ApiSettingsScreen.test.tsxnew file mode 100644index 00000000..0d0a35a6--- /dev/null+++ b/apps/mobile/src/screens/__tests__/ApiSettingsScreen.test.tsx@@ -0,0 +1,227 @@+import React from "react"+import { render, fireEvent } from "@testing-library/react-native"+import { DEFAULT_SETTINGS, API_TEMPLATES, Settings } from "../../types/global"++// --- Mocks ---++const mockSetSettings = jest.fn().mockResolvedValue(undefined)+const mockRestartTracking = jest.fn().mockResolvedValue(undefined)+let mockSettings: Settings = { ...DEFAULT_SETTINGS }++jest.mock("../../contexts/TrackingProvider", () => ({+ useTracking: () => ({+ settings: mockSettings,+ setSettings: mockSetSettings,+ restartTracking: mockRestartTracking+ })+}))++jest.mock("../../hooks/useTheme", () => ({+ useTheme: () => ({+ colors: {+ primary: "#0d9488",+ primaryDark: "#115E59",+ border: "#e5e7eb",+ text: "#000",+ textSecondary: "#6b7280",+ textLight: "#9ca3af",+ background: "#fff",+ info: "#3b82f6",+ success: "#22c55e",+ error: "#ef4444",+ card: "#fff",+ backgroundElevated: "#f9fafb",+ placeholder: "#9ca3af",+ textOnPrimary: "#fff"+ }+ })+}))++const mockDebouncedSaveAndRestart = jest.fn()+const mockImmediateSaveAndRestart = jest.fn()++jest.mock("../../hooks/useAutoSave", () => ({+ useAutoSave: () => ({+ saving: false,+ saveSuccess: false,+ debouncedSaveAndRestart: mockDebouncedSaveAndRestart,+ immediateSaveAndRestart: mockImmediateSaveAndRestart+ })+}))++// Mock barrel exports to avoid native module imports+jest.mock("../../components", () => {+ const R = require("react")+ const { View, Text } = require("react-native")+ return {+ SectionTitle: ({ children }: any) => R.createElement(Text, null, children),+ FloatingSaveIndicator: () => null,+ Container: ({ children }: any) => R.createElement(View, null, children),+ Divider: () => R.createElement(View, null)+ }+})++import { ApiSettingsScreen } from "../ApiSettingsScreen"++describe("ApiSettingsScreen", () => {+ beforeEach(() => {+ jest.clearAllMocks()+ mockSettings = { ...DEFAULT_SETTINGS }+ })++ function renderScreen(settingsOverride?: Partial<Settings>) {+ if (settingsOverride) {+ mockSettings = { ...DEFAULT_SETTINGS, ...settingsOverride }+ }+ return render(<ApiSettingsScreen navigation={{} as any} route={{} as any} />)+ }++ describe("template switching", () => {+ it("renders all template options", () => {+ const { getByText } = renderScreen()++ expect(getByText("Custom")).toBeTruthy()+ expect(getByText("Dawarich")).toBeTruthy()+ expect(getByText("OwnTracks")).toBeTruthy()+ expect(getByText("PhoneTrack")).toBeTruthy()+ expect(getByText("Reitti")).toBeTruthy()+ expect(getByText("Traccar")).toBeTruthy()+ })++ it("selecting Dawarich template applies its field map", () => {+ const { getByText, getByDisplayValue } = renderScreen()++ fireEvent.press(getByText("Dawarich"))++ // Dawarich uses "cog" for bearing+ expect(getByDisplayValue("cog")).toBeTruthy()+ // Standard fields remain the same+ expect(getByDisplayValue("lat")).toBeTruthy()+ expect(getByDisplayValue("lon")).toBeTruthy()+ })++ it("selecting OwnTracks template applies its custom fields", () => {+ const { getByText, getByDisplayValue } = renderScreen()++ fireEvent.press(getByText("OwnTracks"))++ // OwnTracks has _type and tid custom fields+ expect(getByDisplayValue("_type")).toBeTruthy()+ expect(getByDisplayValue("location")).toBeTruthy()+ expect(getByDisplayValue("tid")).toBeTruthy()+ expect(getByDisplayValue("AA")).toBeTruthy()+ })++ it("selecting PhoneTrack template applies its unique field names", () => {+ const { getByText, getByDisplayValue } = renderScreen()++ fireEvent.press(getByText("PhoneTrack"))++ // PhoneTrack uses different field names+ expect(getByDisplayValue("speed")).toBeTruthy() // vel -> speed+ expect(getByDisplayValue("bat")).toBeTruthy() // batt -> bat+ expect(getByDisplayValue("timestamp")).toBeTruthy() // tst -> timestamp+ expect(getByDisplayValue("bearing")).toBeTruthy() // bear -> bearing+ })++ it("switching template triggers immediate save", () => {+ const { getByText } = renderScreen()++ fireEvent.press(getByText("Traccar"))++ expect(mockImmediateSaveAndRestart).toHaveBeenCalled()+ })++ it("switching back to Custom preserves current field map", () => {+ const { getByText, getByDisplayValue } = renderScreen()++ // First switch to PhoneTrack+ fireEvent.press(getByText("PhoneTrack"))+ expect(getByDisplayValue("speed")).toBeTruthy()++ // Switch to Custom — field map stays as PhoneTrack's+ fireEvent.press(getByText("Custom"))+ expect(getByDisplayValue("speed")).toBeTruthy()+ })++ it("shows template description for non-custom templates", () => {+ const { getByText } = renderScreen()++ fireEvent.press(getByText("Dawarich"))++ expect(getByText(API_TEMPLATES.dawarich.description)).toBeTruthy()+ })++ it("editing a field auto-switches template to Custom", () => {+ const { getByText, getByDisplayValue, queryByText } = renderScreen({+ apiTemplate: "dawarich",+ fieldMap: API_TEMPLATES.dawarich.fieldMap,+ customFields: API_TEMPLATES.dawarich.customFields+ })++ // Verify we start on Dawarich (description visible)+ expect(getByText(API_TEMPLATES.dawarich.description)).toBeTruthy()++ // Edit the "cog" field (bear) to something else+ const cogInput = getByDisplayValue("cog")+ fireEvent.changeText(cogInput, "heading")++ // Template description should disappear (switched to Custom)+ expect(queryByText(API_TEMPLATES.dawarich.description)).toBeNull()+ })+ })++ describe("HTTP method switching", () => {+ it("renders POST and GET options", () => {+ const { getByText } = renderScreen()++ expect(getByText("POST")).toBeTruthy()+ expect(getByText("GET")).toBeTruthy()+ })++ it("switching to GET shows query parameter hint", () => {+ const { getByText } = renderScreen()++ fireEvent.press(getByText("GET"))++ expect(getByText("Fields sent as URL query parameters instead of JSON body")).toBeTruthy()+ })++ it("switching method triggers immediate save", () => {+ const { getByText } = renderScreen()++ fireEvent.press(getByText("GET"))++ expect(mockImmediateSaveAndRestart).toHaveBeenCalled()+ })++ it("example payload changes format for GET method", () => {+ const { getByText } = renderScreen()++ fireEvent.press(getByText("GET"))++ expect(getByText("EXAMPLE REQUEST")).toBeTruthy()+ })+ })++ describe("field reset", () => {+ it("shows Modified badge when a field differs from template default", () => {+ const { getByText, getByDisplayValue } = renderScreen()++ // Change the lat field+ const latInput = getByDisplayValue("lat")+ fireEvent.changeText(latInput, "latitude")++ expect(getByText("Modified")).toBeTruthy()+ })++ it("shows RESET ALL button when any field is modified", () => {+ const { getByText, getByDisplayValue } = renderScreen()++ const latInput = getByDisplayValue("lat")+ fireEvent.changeText(latInput, "latitude")++ expect(getByText("RESET ALL")).toBeTruthy()+ })+ })+})diff --git a/apps/mobile/src/screens/__tests__/AuthSettingsScreen.test.tsx b/apps/mobile/src/screens/__tests__/AuthSettingsScreen.test.tsxnew file mode 100644index 00000000..7bbd1e22--- /dev/null+++ b/apps/mobile/src/screens/__tests__/AuthSettingsScreen.test.tsx@@ -0,0 +1,301 @@+import React from "react"+import { render, fireEvent, waitFor } from "@testing-library/react-native"+import { DEFAULT_AUTH_CONFIG, AuthConfig } from "../../types/global"++// --- Mocks ---++let mockAuthConfig: AuthConfig = { ...DEFAULT_AUTH_CONFIG }+const mockSaveAuthConfig = jest.fn().mockResolvedValue(undefined)+const mockGetAuthConfig = jest.fn(() => Promise.resolve(mockAuthConfig))++jest.mock("../../services/NativeLocationService", () => ({+ __esModule: true,+ default: {+ getAuthConfig: (...args: any[]) => mockGetAuthConfig(...args),+ saveAuthConfig: (...args: any[]) => mockSaveAuthConfig(...args)+ }+}))++const mockRestartTracking = jest.fn().mockResolvedValue(undefined)++jest.mock("../../contexts/TrackingProvider", () => ({+ useTracking: () => ({+ settings: require("../../types/global").DEFAULT_SETTINGS,+ restartTracking: mockRestartTracking+ })+}))++jest.mock("../../hooks/useTheme", () => ({+ useTheme: () => ({+ colors: {+ primary: "#0d9488",+ primaryDark: "#115E59",+ border: "#e5e7eb",+ text: "#000",+ textSecondary: "#6b7280",+ textLight: "#9ca3af",+ background: "#fff",+ info: "#3b82f6",+ success: "#22c55e",+ error: "#ef4444",+ card: "#fff",+ placeholder: "#9ca3af",+ textOnPrimary: "#fff"+ }+ })+}))++const mockDebouncedSaveAndRestart = jest.fn()+const mockImmediateSaveAndRestart = jest.fn()++jest.mock("../../hooks/useAutoSave", () => ({+ useAutoSave: () => ({+ saving: false,+ saveSuccess: false,+ debouncedSaveAndRestart: mockDebouncedSaveAndRestart,+ immediateSaveAndRestart: mockImmediateSaveAndRestart+ })+}))++jest.mock("../../components", () => {+ const R = require("react")+ const { View, Text } = require("react-native")+ return {+ SectionTitle: ({ children }: any) => R.createElement(Text, null, children),+ FloatingSaveIndicator: () => null,+ Container: ({ children }: any) => R.createElement(View, null, children),+ Card: ({ children }: any) => R.createElement(View, null, children),+ Divider: () => R.createElement(View, null)+ }+})++jest.mock("../../utils/logger", () => ({+ logger: { error: jest.fn(), info: jest.fn(), debug: jest.fn() }+}))++import { AuthSettingsScreen } from "../AuthSettingsScreen"++describe("AuthSettingsScreen", () => {+ beforeEach(() => {+ jest.clearAllMocks()+ mockAuthConfig = { ...DEFAULT_AUTH_CONFIG }+ })++ function renderScreen() {+ return render(<AuthSettingsScreen navigation={{} as any} route={{} as any} />)+ }++ describe("loading state", () => {+ it("shows loading text while fetching config", () => {+ // Keep the promise pending+ mockGetAuthConfig.mockReturnValueOnce(new Promise(() => {}))+ const { getByText } = renderScreen()++ expect(getByText("Loading...")).toBeTruthy()+ })++ it("shows content after config is loaded", async () => {+ const { getByText } = renderScreen()++ await waitFor(() => {+ expect(getByText("Authentication & Headers")).toBeTruthy()+ })+ })+ })++ describe("auth type changes", () => {+ it("renders all three auth type options", async () => {+ const { getByText } = renderScreen()++ await waitFor(() => {+ expect(getByText("None")).toBeTruthy()+ })+ expect(getByText("Basic Auth")).toBeTruthy()+ expect(getByText("Bearer Token")).toBeTruthy()+ })++ it("defaults to None with no credential fields visible", async () => {+ const { queryByText, getByText } = renderScreen()++ await waitFor(() => {+ expect(getByText("None")).toBeTruthy()+ })++ expect(queryByText("Username")).toBeNull()+ expect(queryByText("Password")).toBeNull()+ expect(queryByText("Token")).toBeNull()+ })++ it("switching to Basic Auth shows username and password fields", async () => {+ const { getByText } = renderScreen()++ await waitFor(() => {+ expect(getByText("None")).toBeTruthy()+ })++ fireEvent.press(getByText("Basic Auth"))++ expect(getByText("Username")).toBeTruthy()+ expect(getByText("Password")).toBeTruthy()+ })++ it("switching to Bearer Token shows token field", async () => {+ const { getByText } = renderScreen()++ await waitFor(() => {+ expect(getByText("None")).toBeTruthy()+ })++ fireEvent.press(getByText("Bearer Token"))++ expect(getByText("Token")).toBeTruthy()+ })++ it("switching from Basic Auth to Bearer hides username/password, shows token", async () => {+ const { getByText, queryByText } = renderScreen()++ await waitFor(() => {+ expect(getByText("None")).toBeTruthy()+ })++ fireEvent.press(getByText("Basic Auth"))+ expect(getByText("Username")).toBeTruthy()++ fireEvent.press(getByText("Bearer Token"))+ expect(queryByText("Username")).toBeNull()+ expect(queryByText("Password")).toBeNull()+ expect(getByText("Token")).toBeTruthy()+ })++ it("switching from Bearer to None hides token field", async () => {+ const { getByText, queryByText } = renderScreen()++ await waitFor(() => {+ expect(getByText("None")).toBeTruthy()+ })++ fireEvent.press(getByText("Bearer Token"))+ expect(getByText("Token")).toBeTruthy()++ fireEvent.press(getByText("None"))+ expect(queryByText("Token")).toBeNull()+ })++ it("auth type change triggers immediate save", async () => {+ const { getByText } = renderScreen()++ await waitFor(() => {+ expect(getByText("None")).toBeTruthy()+ })++ fireEvent.press(getByText("Basic Auth"))++ expect(mockImmediateSaveAndRestart).toHaveBeenCalled()+ })++ it("loads saved Basic Auth config and shows fields", async () => {+ mockAuthConfig = {+ ...DEFAULT_AUTH_CONFIG,+ authType: "basic",+ username: "testuser",+ password: "testpass"+ }++ const { getByText, getByDisplayValue } = renderScreen()++ await waitFor(() => {+ expect(getByText("Username")).toBeTruthy()+ })++ expect(getByDisplayValue("testuser")).toBeTruthy()+ expect(getByDisplayValue("testpass")).toBeTruthy()+ })++ it("loads saved Bearer config and shows field", async () => {+ mockAuthConfig = {+ ...DEFAULT_AUTH_CONFIG,+ authType: "bearer",+ bearerToken: "my-secret-token"+ }++ const { getByText, getByDisplayValue } = renderScreen()++ await waitFor(() => {+ expect(getByText("Token")).toBeTruthy()+ })++ expect(getByDisplayValue("my-secret-token")).toBeTruthy()+ })++ it("typing in username triggers debounced save", async () => {+ const { getByText, getByPlaceholderText } = renderScreen()++ await waitFor(() => {+ expect(getByText("None")).toBeTruthy()+ })++ fireEvent.press(getByText("Basic Auth"))++ const usernameInput = getByPlaceholderText("Username")+ fireEvent.changeText(usernameInput, "newuser")++ expect(mockDebouncedSaveAndRestart).toHaveBeenCalled()+ })+ })++ describe("custom headers", () => {+ it("shows empty state when no headers configured", async () => {+ const { getByText } = renderScreen()++ await waitFor(() => {+ expect(getByText("No custom headers configured")).toBeTruthy()+ })+ })++ it("adds a header row when + Add Header is pressed", async () => {+ const { getByText, getAllByPlaceholderText } = renderScreen()++ await waitFor(() => {+ expect(getByText("+ Add Header")).toBeTruthy()+ })++ fireEvent.press(getByText("+ Add Header"))++ expect(getAllByPlaceholderText("Header name")).toHaveLength(1)+ expect(getAllByPlaceholderText("Value")).toHaveLength(1)+ })++ it("loads saved custom headers", async () => {+ mockAuthConfig = {+ ...DEFAULT_AUTH_CONFIG,+ customHeaders: { "CF-Access-Client-Id": "abc123" }+ }++ const { getByDisplayValue } = renderScreen()++ await waitFor(() => {+ expect(getByDisplayValue("CF-Access-Client-Id")).toBeTruthy()+ })++ expect(getByDisplayValue("abc123")).toBeTruthy()+ })++ it("removes a header when X is pressed", async () => {+ mockAuthConfig = {+ ...DEFAULT_AUTH_CONFIG,+ customHeaders: { "X-Custom": "val" }+ }++ const { getByDisplayValue, getByText, queryByDisplayValue } = renderScreen()++ await waitFor(() => {+ expect(getByDisplayValue("X-Custom")).toBeTruthy()+ })++ fireEvent.press(getByText("X"))++ expect(queryByDisplayValue("X-Custom")).toBeNull()+ expect(mockImmediateSaveAndRestart).toHaveBeenCalled()+ })+ })+})