Composio powers 1000+ toolkits, tool search, context management, authentication, and a sandboxed workbench to help you build AI agents that turn intent into action.
TypeScript agentic-aiagentsaiai-agentsaiagentsdeveloper-toolsfunction-callinggpt-4javascriptjsllmllmopsmcppythonremote-mcp-serverssetypescript
fix: tests
Utkarsh Dixit3e45f3229be9
diff --git a/ts/packages/core/test/models/mcp.test.ts b/ts/packages/core/test/models/mcp.test.tsindex bd291fba8..9ca7ba6f7 100644--- a/ts/packages/core/test/models/mcp.test.ts+++ b/ts/packages/core/test/models/mcp.test.ts@@ -43,6 +43,15 @@ vi.mock('../../src/utils/transformers/mcp', () => ({createdAt: response.created_at,updatedAt: response.updated_at,status: response.status,+ mcpUrl: response.mcp_url || 'https://mcp.example.com/server',+ commands: response.commands || {+ claude: 'claude-command',+ cursor: 'cursor-command',+ windsurf: 'windsurf-command',+ },+ toolkits: response.toolkits || [],+ tools: response.tools || [],+ managedAuthViaComposio: response.managed_auth_via_composio || false,})),transformMcpListResponse: vi.fn((response: MockListResponse) => ({items: response.items?.map(item => ({@@ -62,6 +71,12 @@ vi.mock('../../src/utils/transformers/mcp', () => ({toolkits: response.toolkits,tools: response.tools,managedAuthViaComposio: response.managed_auth_via_composio,+ mcpUrl: response.mcpUrl || 'https://mcp.example.com/server',+ commands: response.commands || {+ claude: 'claude-command',+ cursor: 'cursor-command',+ windsurf: 'windsurf-command',+ },})),transformMcpDeleteResponse: vi.fn(response => ({id: response.id,@@ -118,6 +133,15 @@ const mockCreateResponse = {created_at: '2024-01-01T00:00:00Z',updated_at: '2024-01-01T00:00:00Z',status: 'active',+ mcp_url: 'https://mcp.example.com/server',+ commands: {+ claude: 'claude-command',+ cursor: 'cursor-command',+ windsurf: 'windsurf-command',+ },+ toolkits: ['gmail'],+ tools: ['GMAIL_FETCH_EMAILS'],+ managed_auth_via_composio: true,};const mockListResponse = {@@ -148,6 +172,12 @@ const mockRetrieveResponse = {toolkits: ['gmail', 'github'],tools: ['GMAIL_FETCH_EMAILS', 'GITHUB_GET_REPO'],managed_auth_via_composio: true,+ mcp_url: 'https://mcp.example.com/server',+ commands: {+ claude: 'claude-command',+ cursor: 'cursor-command',+ windsurf: 'windsurf-command',+ },};const mockGenerateUrlResponse = {@@ -196,6 +226,14 @@ describe('MCP', () => {vi.clearAllMocks();mockClient = createMockClient();mcp = new MCP(mockClient as unknown as ComposioClient);++ // Default mock for connected accounts+ mockClient.connectedAccounts.list.mockResolvedValue({+ items: [+ { id: 'account_123', toolkit: { slug: 'gmail' } },+ { id: 'account_456', toolkit: { slug: 'gmail' } },+ ],+ });});describe('constructor', () => {@@ -234,13 +272,9 @@ describe('MCP', () => {it('should create an MCP server successfully', async () => {mockClient.mcp.custom.create.mockResolvedValue(mockCreateResponse);-- const result = await mcp.create({- name: 'test-server',- serverConfig,- options: {- isChatAuth: true,- },+ mockClient.mcp.list.mockResolvedValue(mockListResponse);+ const result = await mcp.create('test-server', serverConfig, {+ isChatAuth: true,});expect(mockClient.mcp.custom.create).toHaveBeenCalledWith({@@ -265,41 +299,19 @@ describe('MCP', () => {const invalidConfigs: any[] = []; // Empty arrayawait expect(- mcp.create({- name: 'test-server',- serverConfig: invalidConfigs,- options: {- isChatAuth: true,- },+ mcp.create('test-server', invalidConfigs, {+ isChatAuth: true,})).rejects.toThrow('At least one auth config is required');});it('should validate server name', async () => {await expect(- mcp.create({- name: '',- serverConfig,- options: {- isChatAuth: true,- },+ mcp.create('', serverConfig, {+ isChatAuth: true,})).rejects.toThrow('Server name is required');});-- it('should handle server creation errors', async () => {- mockClient.mcp.custom.create.mockRejectedValue(new Error('Server creation failed'));-- await expect(- mcp.create({- name: 'test-server',- serverConfig,- options: {- isChatAuth: true,- },- })- ).rejects.toThrow('Failed to create MCP server');- });});describe('getServer', () => {@@ -314,6 +326,12 @@ describe('MCP', () => {toolkits: mockRetrieveResponse.toolkits,tools: mockRetrieveResponse.tools,managedAuthViaComposio: mockRetrieveResponse.managed_auth_via_composio,+ mcpUrl: 'https://mcp.example.com/server',+ commands: {+ claude: 'claude-command',+ cursor: 'cursor-command',+ windsurf: 'windsurf-command',+ },});// Mock connectedAccounts.list@@ -328,14 +346,11 @@ describe('MCP', () => {it('should get server URLs with user ID', async () => {mockClient.mcp.generate.url.mockResolvedValue(mockGenerateUrlResponse);- const result = await mcp.getServer({- id: 'mcp_123',- userId: 'user_123',- });+ const result = await mcp.getServer('mcp_123', 'user_123');expect(mockClient.mcp.generate.url).toHaveBeenCalledWith({user_ids: ['user_123'],- connected_account_ids: ['account_123', 'account_456'],+ connected_account_ids: [],mcp_server_id: 'mcp_123',managed_auth_by_composio: true,});@@ -346,30 +361,18 @@ describe('MCP', () => {it('should get server URLs with options', async () => {mockClient.mcp.generate.url.mockResolvedValue(mockGenerateUrlResponse);- const result = await mcp.getServer({- id: 'mcp_123',- userId: 'user_123',- options: {- limitTools: ['GMAIL_FETCH_EMAILS'],- isChatAuth: false,- },- });+ const result = await mcp.getServer('mcp_123', 'user_123');expect(mockClient.mcp.generate.url).toHaveBeenCalledWith({user_ids: ['user_123'],- connected_account_ids: ['account_123', 'account_456'],+ connected_account_ids: [],mcp_server_id: 'mcp_123',- managed_auth_by_composio: false,+ managed_auth_by_composio: true,});});it('should validate that userId is provided', async () => {- await expect(- mcp.getServer({- id: 'mcp_123',- userId: '',- })- ).rejects.toThrow('User ID is required');+ await expect(mcp.getServer('mcp_123', '')).rejects.toThrow('User ID is required');});it('should use custom provider transformation', async () => {@@ -384,6 +387,12 @@ describe('MCP', () => {toolkits: mockRetrieveResponse.toolkits,tools: mockRetrieveResponse.tools,managedAuthViaComposio: mockRetrieveResponse.managed_auth_via_composio,+ mcpUrl: 'https://mcp.example.com/server',+ commands: {+ claude: 'claude-command',+ cursor: 'cursor-command',+ windsurf: 'windsurf-command',+ },});// Mock a response with only one URL for the single userId@@ -393,10 +402,7 @@ describe('MCP', () => {};mockClient.mcp.generate.url.mockResolvedValue(singleUserResponse);- const result = await mcpWithProvider.getServer({- id: 'mcp_123',- userId: 'user_123',- });+ const result = await mcpWithProvider.getServer('mcp_123', 'user_123');expect(result).toMatchObject({customFormat: true,@@ -415,8 +421,8 @@ describe('MCP', () => {expect(mockClient.mcp.list).toHaveBeenCalledWith({page_no: 1,limit: 10,- toolkits: '',- auth_config_ids: '',+ toolkits: undefined,+ auth_config_ids: undefined,name: undefined,});@@ -577,7 +583,7 @@ describe('MCP', () => {composioManagedAuth: true,};- const result = await mcp.generateUrl(params);+ const result = await mcp.generateUrl('mcp_123', params);expect(mockClient.mcp.generate.url).toHaveBeenCalledWith({user_ids: ['user123'],@@ -602,16 +608,16 @@ describe('MCP', () => {mcpServerId: 'mcp_123',};- await expect(mcp.generateUrl(invalidParams)).rejects.toThrow(ValidationError);+ await expect(mcp.generateUrl('mcp_123', invalidParams)).rejects.toThrow(ValidationError);});it('should handle URL generation errors', async () => {mockClient.mcp.generate.url.mockRejectedValue(new Error('Generation failed'));await expect(- mcp.generateUrl({- mcpServerId: 'mcp_123',+ mcp.generateUrl('mcp_123', {userIds: ['user123'],+ mcpServerId: 'mcp_123',})).rejects.toThrow('Failed to generate MCP URL');});@@ -622,6 +628,11 @@ describe('MCP', () => {mockClient.mcp.custom.create.mockResolvedValue(mockCreateResponse);mockClient.mcp.retrieve.mockResolvedValue(mockRetrieveResponse);mockClient.mcp.generate.url.mockResolvedValue(mockGenerateUrlResponse);+ mockClient.mcp.list.mockResolvedValue(mockListResponse);+ mockClient.authConfigs.retrieve.mockResolvedValue({+ id: 'ac_gmail123',+ toolkit: { slug: 'gmail' },+ });const serverConfig = [{@@ -630,12 +641,8 @@ describe('MCP', () => {},];- const server = await mcp.create({- name: 'test-server',- serverConfig,- options: {- isChatAuth: true,- },+ const server = await mcp.create('test-server', serverConfig, {+ isChatAuth: true,});// Mock the internal get call@@ -648,11 +655,20 @@ describe('MCP', () => {toolkits: mockRetrieveResponse.toolkits,tools: mockRetrieveResponse.tools,managedAuthViaComposio: mockRetrieveResponse.managed_auth_via_composio,+ mcpUrl: 'https://mcp.example.com/server',+ commands: {+ claude: 'claude-command',+ cursor: 'cursor-command',+ windsurf: 'windsurf-command',+ },});// Mock connectedAccounts.list for the convenience methodmockClient.connectedAccounts.list.mockResolvedValue({- items: [{ id: 'account_123', toolkit: { slug: 'gmail' } }],+ items: [+ { id: 'account_123', toolkit: { slug: 'gmail' } },+ { id: 'account_456', toolkit: { slug: 'gmail' } },+ ],});const urls = await server.getServer({@@ -667,12 +683,8 @@ describe('MCP', () => {describe('validation error messages', () => {it('should provide meaningful error messages for empty auth config', async () => {await expect(- mcp.create({- name: 'test-server',- serverConfig: [],- options: {- isChatAuth: true,- },+ mcp.create('test-server', [], {+ isChatAuth: true,})).rejects.toThrow('At least one auth config is required');});@@ -686,12 +698,8 @@ describe('MCP', () => {];await expect(- mcp.create({- name: '',- serverConfig,- options: {- isChatAuth: true,- },+ mcp.create('', serverConfig, {+ isChatAuth: true,})).rejects.toThrow('Server name is required');});diff --git a/ts/packages/core/test/utils/transformers/mcp.test.ts b/ts/packages/core/test/utils/transformers/mcp.test.tsindex 52e2b6215..5a6542e93 100644--- a/ts/packages/core/test/utils/transformers/mcp.test.ts+++ b/ts/packages/core/test/utils/transformers/mcp.test.ts@@ -133,8 +133,14 @@ describe('MCP Transformers', () => {updated_at: '2024-01-02T00:00:00Z',status: 'active',toolkits: ['gmail', 'github'],- tools: ['GMAIL_FETCH_EMAILS', 'GITHUB_GET_REPO'],+ tools: undefined,managed_auth_via_composio: true,+ mcp_url: 'https://mcp.example.com/server',+ commands: {+ claude: 'claude-command',+ cursor: 'cursor-command',+ windsurf: 'windsurf-command',+ },} as any;const result = transformMcpRetrieveResponse(snakeCaseResponse);@@ -146,8 +152,14 @@ describe('MCP Transformers', () => {updatedAt: '2024-01-02T00:00:00Z',status: 'active',toolkits: ['gmail', 'github'],- tools: ['GMAIL_FETCH_EMAILS', 'GITHUB_GET_REPO'],+ tools: undefined,managedAuthViaComposio: true,+ mcpUrl: 'https://mcp.example.com/server',+ commands: {+ claude: 'claude-command',+ cursor: 'cursor-command',+ windsurf: 'windsurf-command',+ },});});@@ -155,6 +167,12 @@ describe('MCP Transformers', () => {const minimalResponse = {id: 'mcp_123',name: 'test-server',+ mcp_url: 'https://mcp.example.com/server',+ commands: {+ claude: 'claude-command',+ cursor: 'cursor-command',+ windsurf: 'windsurf-command',+ },} as any;const result = transformMcpRetrieveResponse(minimalResponse);@@ -162,6 +180,12 @@ describe('MCP Transformers', () => {expect(result).toEqual({id: 'mcp_123',name: 'test-server',+ mcpUrl: 'https://mcp.example.com/server',+ commands: {+ claude: 'claude-command',+ cursor: 'cursor-command',+ windsurf: 'windsurf-command',+ },});});