Skip to content

Composio powers 1000+ toolkits, tool search, context management, authentication, and a sandboxed workbench to help you build AI agents that turn intent into action.

fix(core): use Stainless-generated types for update() instead of hardcoded strings

Dhawal Upadhyay43c1b5025e36
diff --git a/ts/packages/core/src/models/ConnectedAccounts.ts b/ts/packages/core/src/models/ConnectedAccounts.ts
index ec7bcea8a..ac3abf623 100644
--- a/ts/packages/core/src/models/ConnectedAccounts.ts
+++ b/ts/packages/core/src/models/ConnectedAccounts.ts
@@ -28,7 +28,6 @@ import {
ConnectedAccountRefreshOptions,
ConnectedAccountRefreshOptionsSchema,
UpdateConnectedAccountParams,
- UpdateConnectedAccountParamsSchema,
} from '../types/connectedAccounts.types';
import { ConnectionRequest } from '../types/connectionRequest.types';
import { createConnectionRequest } from './ConnectionRequest';
@@ -491,18 +490,8 @@ export class ConnectedAccounts {
*/
async update(
nanoid: string,
- params: UpdateConnectedAccountParams
+ params: UpdateConnectedAccountParams,
): Promise<ConnectedAccountPatchResponse> {
- const parsedParams = UpdateConnectedAccountParamsSchema.safeParse(params);
- if (!parsedParams.success) {
- throw new ValidationError('Failed to parse connected account update params', {
- cause: parsedParams.error,
- });
- }
-
- return this.client.connectedAccounts.patch(nanoid, {
- alias: parsedParams.data.alias,
- connection: parsedParams.data.connection,
- });
+ return this.client.connectedAccounts.patch(nanoid, params);
}
}
diff --git a/ts/packages/core/src/types/connectedAccounts.types.ts b/ts/packages/core/src/types/connectedAccounts.types.ts
index f6b5f3bfe..b4a004d05 100644
--- a/ts/packages/core/src/types/connectedAccounts.types.ts
+++ b/ts/packages/core/src/types/connectedAccounts.types.ts
@@ -213,30 +213,8 @@ export const ConnectedAccountRefreshOptionsSchema = z.object({
});
export type ConnectedAccountRefreshOptions = z.infer<typeof ConnectedAccountRefreshOptionsSchema>;
-export const UpdateConnectedAccountParamsSchema = z.object({
- alias: z
- .string()
- .optional()
- .describe(
- 'Human-readable alias for the account. Must be unique per userId and toolkit within the project. Pass an empty string to clear the alias.'
- ),
- connection: z
- .object({
- state: z.object({
- authScheme: z.enum([
- 'BEARER_TOKEN',
- 'API_KEY',
- 'BASIC',
- 'BASIC_WITH_JWT',
- 'GOOGLE_SERVICE_ACCOUNT',
- 'SERVICE_ACCOUNT',
- ]),
- val: z.record(z.unknown()),
- }),
- })
- .optional()
- .describe('Credential fields to update. Only provided fields are changed — omitted fields are preserved. Set a field to null to remove it.'),
-});
-export type UpdateConnectedAccountParams = z.infer<typeof UpdateConnectedAccountParamsSchema>;
+// Re-export the Stainless-generated type directly so it stays in sync
+// with the API contract without hardcoding auth scheme strings.
+export type { ConnectedAccountPatchParams as UpdateConnectedAccountParams } from '@composio/client/resources/connected-accounts';
// UpdateConnectedAccountResponse is now ConnectedAccountPatchResponse from @composio/client
diff --git a/ts/packages/core/test/connectedAccounts/connectedAccounts.test.ts b/ts/packages/core/test/connectedAccounts/connectedAccounts.test.ts
index 357b5321b..98cf9981b 100644
--- a/ts/packages/core/test/connectedAccounts/connectedAccounts.test.ts
+++ b/ts/packages/core/test/connectedAccounts/connectedAccounts.test.ts
@@ -965,10 +965,24 @@ describe('ConnectedAccounts', () => {
expect(result).toEqual({ success: true });
});
- it('should throw ValidationError for invalid params', async () => {
- await expect(connectedAccounts.update('conn_abc123', { alias: 123 } as any)).rejects.toThrow(
- 'Failed to parse connected account update params'
- );
+ it('should update credentials via connection param', async () => {
+ const nanoid = 'conn_abc123';
+ const mockResponse = { success: true, id: nanoid, status: 'ACTIVE' };
+ const params = {
+ connection: {
+ state: {
+ authScheme: 'BEARER_TOKEN' as const,
+ val: { token: 'new-access-token' },
+ },
+ },
+ };
+
+ extendedMockClient.connectedAccounts.patch.mockResolvedValueOnce(mockResponse);
+
+ const result = await connectedAccounts.update(nanoid, params);
+
+ expect(extendedMockClient.connectedAccounts.patch).toHaveBeenCalledWith(nanoid, params);
+ expect(result).toEqual({ success: true, id: nanoid, status: 'ACTIVE' });
});
});