Skip to content

Composio powers 1000+ toolkits, tool search, context management, authentication, and a sandboxed workbench to help you build AI agents that turn intent into action.

fix: preserve original filename when appending extension from mimetype

jkomyno4b230ee46f15
diff --git a/python/composio/core/models/_files.py b/python/composio/core/models/_files.py
index 146a19e7e..6bb636777 100644
--- a/python/composio/core/models/_files.py
+++ b/python/composio/core/models/_files.py
@@ -163,7 +163,7 @@ def _fetch_file_from_url(url: str) -> t.Tuple[str, bytes, str]:
# If filename has no extension, try to add one from mimetype
if "." not in filename:
extension = _get_extension_from_mimetype(mimetype)
- filename = _generate_timestamped_filename(extension)
+ filename = f"{filename}{extension}"
return filename, content, mimetype
diff --git a/python/tests/test_files.py b/python/tests/test_files.py
index 9cf5eda24..65676787e 100644
--- a/python/tests/test_files.py
+++ b/python/tests/test_files.py
@@ -1075,8 +1075,8 @@ class TestFetchFileFromUrl:
assert filename.endswith(".png")
@patch("composio.core.models._files.requests.get")
- def test_fetch_file_from_url_generates_filename_when_no_extension(self, mock_get):
- """Test filename generation when URL filename has no extension."""
+ def test_fetch_file_from_url_appends_extension_when_missing(self, mock_get):
+ """Test extension is appended to original filename when missing."""
mock_response = MagicMock()
mock_response.ok = True
mock_response.content = b"pdf data"
@@ -1087,8 +1087,8 @@ class TestFetchFileFromUrl:
"https://example.com/document"
)
- assert filename.startswith("file_")
- assert filename.endswith(".pdf")
+ # Should preserve original filename and append extension
+ assert filename == "document.pdf"
@patch("composio.core.models._files.requests.get")
def test_fetch_file_from_url_failure(self, mock_get):