Composio powers 1000+ toolkits, tool search, context management, authentication, and a sandboxed workbench to help you build AI agents that turn intent into action.
TypeScript agentic-aiagentsaiai-agentsaiagentsdeveloper-toolsfunction-callinggpt-4javascriptjsllmllmopsmcppythonremote-mcp-serverssetypescript
fix(python-sdk): isolate default provider per Composio instance (#4370)
Adesh Deshmukh7d36de8c0ae9
diff --git a/python/composio/sdk.py b/python/composio/sdk.pyindex 18b4de47d..09286a344 100644--- a/python/composio/sdk.py+++ b/python/composio/sdk.py@@ -28,8 +28,6 @@ from composio.core.types import ToolkitVersionParamfrom composio.utils.logging import WithLoggerfrom composio.utils.toolkit_version import get_toolkit_versions-_DEFAULT_PROVIDER = OpenAIProvider()-class SDKConfig(te.TypedDict):environment: te.NotRequired[APIEnvironment]@@ -130,11 +128,11 @@ class Composio(t.Generic[TTool, TToolCollection], WithLogger):if not api_key:raise exceptions.ApiKeyNotProvidedError()- # Use default provider if none provided- # Cast to BaseProvider[TTool, TToolCollection] for type consistency+ # Each instance gets its own provider so that the execute_tool_fn binding+ # performed by Tools.__init__ cannot leak across SDK instances (issue #4369).actual_provider: BaseProvider[TTool, TToolCollection] = t.cast(BaseProvider[TTool, TToolCollection],- provider if provider is not None else _DEFAULT_PROVIDER,+ provider if provider is not None else OpenAIProvider(),)# Process toolkit versions with environment variable supportdiff --git a/python/tests/test_sdk.py b/python/tests/test_sdk.pyindex a83d4f65f..0b8bd1d38 100644--- a/python/tests/test_sdk.py+++ b/python/tests/test_sdk.py@@ -6,6 +6,7 @@ from unittest.mock import patchimport pytestfrom composio import Composio, exceptions+from composio.core.provider._openai import OpenAIProviderfrom composio.core.types import ToolkitVersionParam@@ -110,6 +111,32 @@ class TestComposioSDK:assert sdk.provider is not Noneassert hasattr(sdk.provider, "name")+ def test_default_provider_is_isolated_per_instance(self):+ """Regression test for #4369.++ The default provider used to be a module-level singleton. Because every+ ``Tools`` instance rebinds ``provider.execute_tool`` to itself, the last+ constructed ``Composio()`` silently took over tool execution for every+ other instance, routing calls through the wrong API key.+ """+ sdk_a = Composio(api_key="key-a")+ sdk_b = Composio(api_key="key-b")++ assert isinstance(sdk_a.provider, OpenAIProvider)+ assert isinstance(sdk_b.provider, OpenAIProvider)+ assert sdk_a.provider is not sdk_b.provider++ # execute_tool is a functools.partial over Tools.execute; each provider+ # must stay bound to the Tools of the instance that created it.+ assert sdk_a.provider.execute_tool.func.__self__ is sdk_a.tools+ assert sdk_b.provider.execute_tool.func.__self__ is sdk_b.tools++ def test_explicit_provider_is_used_unchanged(self):+ """An explicitly passed provider instance is used as-is."""+ provider = OpenAIProvider()+ sdk = Composio(provider=provider, api_key="key-a")+ assert sdk.provider is provider+def test_toolkit_versions_processing(self):"""Test toolkit versions parameter processing."""with patch.dict(os.environ, {"COMPOSIO_API_KEY": "test-key"}):