Composio powers 1000+ toolkits, tool search, context management, authentication, and a sandboxed workbench to help you build AI agents that turn intent into action.
TypeScript agentic-aiagentsaiai-agentsaiagentsdeveloper-toolsfunction-callinggpt-4javascriptjsllmllmopsmcppythonremote-mcp-serverssetypescript
fix(openai_agents): deep-copy tool schema before stripping examples/default (#3632)
ly-wang1995b7b7f649ce
diff --git a/python/providers/openai_agents/composio_openai_agents/provider.py b/python/providers/openai_agents/composio_openai_agents/provider.pyindex 6ba95953c..3642c678b 100644--- a/python/providers/openai_agents/composio_openai_agents/provider.py+++ b/python/providers/openai_agents/composio_openai_agents/provider.py@@ -1,4 +1,5 @@import asyncio+import copyimport jsonimport typing as t@@ -110,8 +111,12 @@ class OpenAIAgentsProvider()# Ensure the schema has additionalProperties set to false- # this is required by OpenAI's function validation- modified_schema = tool.input_parameters.copy()+ # this is required by OpenAI's function validation.+ # Deep-copy so the in-place edits below (additionalProperties + the+ # examples/pattern/default removal) never mutate the caller's+ # Tool.input_parameters, matching the deepcopy contract in+ # composio.utils.shared.+ modified_schema = copy.deepcopy(tool.input_parameters)modified_schema["additionalProperties"] = False# Apply the example removal function. This is done to optimize thediff --git a/python/providers/openai_agents/tests/test_provider.py b/python/providers/openai_agents/tests/test_provider.pynew file mode 100644index 000000000..768e735fd--- /dev/null+++ b/python/providers/openai_agents/tests/test_provider.py@@ -0,0 +1,51 @@+"""Tests for the OpenAI Agents provider."""++import copy+from unittest.mock import MagicMock++from composio_openai_agents.provider import OpenAIAgentsProvider+++def test_wrap_tool_does_not_mutate_input_parameters():+ """wrap_tool must not strip default/examples/pattern from the caller's schema.++ ``wrap_tool`` removes ``examples``/``pattern``/``default`` from the schema it+ hands to the OpenAI Agents SDK. It must do so on a *copy*: a shallow+ ``dict.copy()`` left the nested ``properties`` dicts shared with the original,+ so those in-place deletions leaked back into the caller's+ ``Tool.input_parameters``.+ """+ tool = MagicMock(+ slug="GITHUB_GET_REPO",+ name="Github Get Repo",+ description="Get a repository",+ input_parameters={+ "type": "object",+ "properties": {+ "owner": {"type": "string", "default": "me", "examples": ["octocat"]},+ "repo": {"type": "string", "pattern": "^[a-z]+$"},+ },+ "required": ["owner"],+ },+ )+ snapshot = copy.deepcopy(tool.input_parameters)++ wrapped_tool = OpenAIAgentsProvider().wrap_tool(tool, lambda **kwargs: {})++ # The caller's schema must be untouched.+ assert tool.input_parameters == snapshot+ owner = tool.input_parameters["properties"]["owner"]+ assert owner["default"] == "me"+ assert owner["examples"] == ["octocat"]+ assert tool.input_parameters["properties"]["repo"]["pattern"] == "^[a-z]+$"++ # The provider-local schema should still be normalized for OpenAI Agents.+ assert wrapped_tool.params_json_schema == {+ "type": "object",+ "properties": {+ "owner": {"type": "string"},+ "repo": {"type": "string"},+ },+ "required": ["owner"],+ "additionalProperties": False,+ }