Skip to content

Composio powers 1000+ toolkits, tool search, context management, authentication, and a sandboxed workbench to help you build AI agents that turn intent into action.

fix(cli): make filter case-insensitive and drop deprecated API params

jkomynoa1408e8870ed
diff --git a/ts/packages/cli/src/commands/triggers/commands/triggers.listen.cmd.ts b/ts/packages/cli/src/commands/triggers/commands/triggers.listen.cmd.ts
index 7ec20902c..476ae8045 100644
--- a/ts/packages/cli/src/commands/triggers/commands/triggers.listen.cmd.ts
+++ b/ts/packages/cli/src/commands/triggers/commands/triggers.listen.cmd.ts
@@ -189,14 +189,10 @@ export const triggersCmd$Listen = Command.make(
}
const filters: TriggerListenFilters = {
- toolkits: Option.isSome(toolkits)
- ? parseCsv(toolkits.value).map(x => x.toLowerCase())
- : undefined,
+ toolkits: Option.isSome(toolkits) ? [...parseCsv(toolkits.value)] : undefined,
triggerId: Option.getOrUndefined(triggerId),
connectedAccountId: Option.getOrUndefined(connectedAccountId),
- triggerSlug: Option.isSome(triggerSlug)
- ? parseCsv(triggerSlug.value).map(x => x.toLowerCase())
- : undefined,
+ triggerSlug: Option.isSome(triggerSlug) ? [...parseCsv(triggerSlug.value)] : undefined,
userId: Option.getOrUndefined(userId),
};
diff --git a/ts/packages/cli/src/commands/triggers/filter.ts b/ts/packages/cli/src/commands/triggers/filter.ts
index cf296703b..720d3f895 100644
--- a/ts/packages/cli/src/commands/triggers/filter.ts
+++ b/ts/packages/cli/src/commands/triggers/filter.ts
@@ -2,16 +2,16 @@ import type { TriggerListenEvent, TriggerListenFilters } from './types';
/**
* Check if a trigger event matches the provided filters.
- *
- * IMPORTANT: `filters.toolkits` and `filters.triggerSlug` must be pre-normalized
- * to lowercase at construction time. This avoids per-event allocation from
- * repeated `.map(x => x.toLowerCase())` calls in long-running listen sessions.
+ * All string comparisons on `toolkits` and `triggerSlug` are case-insensitive.
*/
export const matchesTriggerListenFilters = (
filters: TriggerListenFilters,
data: TriggerListenEvent
): boolean => {
- if (filters.toolkits?.length && !filters.toolkits.includes(data.toolkitSlug.toLowerCase())) {
+ if (
+ filters.toolkits?.length &&
+ !filters.toolkits.some(t => t.toLowerCase() === data.toolkitSlug.toLowerCase())
+ ) {
return false;
}
@@ -28,7 +28,7 @@ export const matchesTriggerListenFilters = (
if (
filters.triggerSlug?.length &&
- !filters.triggerSlug.includes(data.triggerSlug.toLowerCase())
+ !filters.triggerSlug.some(s => s.toLowerCase() === data.triggerSlug.toLowerCase())
) {
return false;
}
diff --git a/ts/packages/cli/src/services/composio-clients.ts b/ts/packages/cli/src/services/composio-clients.ts
index 0eb81cb7f..8ad398c61 100644
--- a/ts/packages/cli/src/services/composio-clients.ts
+++ b/ts/packages/cli/src/services/composio-clients.ts
@@ -342,14 +342,7 @@ export interface TriggerInstancesListActiveParams {
auth_config_ids?: string[];
trigger_ids?: string[];
trigger_names?: string[];
- connectedAccountIds?: string[];
- authConfigIds?: string[];
- triggerIds?: string[];
- triggerNames?: string[];
show_disabled?: boolean;
- showDisabled?: boolean;
- deprecatedConnectedAccountUuids?: string[];
- deprecatedAuthConfigUuids?: string[];
limit?: number;
}
@@ -380,14 +373,7 @@ function buildTriggerInstancesNamespace(
auth_config_ids: params.auth_config_ids,
trigger_ids: params.trigger_ids,
trigger_names: params.trigger_names,
- connectedAccountIds: params.connectedAccountIds,
- authConfigIds: params.authConfigIds,
- triggerIds: params.triggerIds,
show_disabled: params.show_disabled,
- triggerNames: params.triggerNames,
- showDisabled: params.showDisabled,
- deprecatedConnectedAccountUuids: params.deprecatedConnectedAccountUuids,
- deprecatedAuthConfigUuids: params.deprecatedAuthConfigUuids,
limit: params.limit,
}),
TriggerInstancesListActiveResponse
diff --git a/ts/packages/cli/test/__utils__/services/test-layer.ts b/ts/packages/cli/test/__utils__/services/test-layer.ts
index f8122a5a8..2ea361b48 100644
--- a/ts/packages/cli/test/__utils__/services/test-layer.ts
+++ b/ts/packages/cli/test/__utils__/services/test-layer.ts
@@ -569,14 +569,7 @@ export const TestLayer = (input?: TestLiveInput) =>
auth_config_ids?: string[];
trigger_ids?: string[];
trigger_names?: string[];
- connectedAccountIds?: string[];
- authConfigIds?: string[];
- triggerIds?: string[];
- triggerNames?: string[];
show_disabled?: boolean;
- showDisabled?: boolean;
- deprecatedConnectedAccountUuids?: string[];
- deprecatedAuthConfigUuids?: string[];
limit?: number;
}) => {
let results = [...triggersData.items];