Skip to content

Composio powers 1000+ toolkits, tool search, context management, authentication, and a sandboxed workbench to help you build AI agents that turn intent into action.

fix(cli): require checksum verification for official release downloads

jkomynobd071f528c75
diff --git a/install.sh b/install.sh
index b976db2c4..06e082a24 100755
--- a/install.sh
+++ b/install.sh
@@ -223,6 +223,9 @@ verify_checksum() {
checksum_expected=$(awk -v name="$checksum_name" '$2 == name || $2 == "*" name { print $1; exit }' "$checksum_manifest")
if [ -z "$checksum_expected" ]; then
+ if [ "$official_release_source" = 1 ]; then
+ error "checksums.txt has no entry for $checksum_name. Official releases always publish complete checksums, so this release cannot be verified. Refusing to install."
+ fi
warn "No checksum entry found for $checksum_name; continuing without verification"
return 0
fi
@@ -234,7 +237,7 @@ verify_checksum() {
elif command -v shasum >/dev/null 2>&1; then
checksum_actual=$(shasum -a 256 "$checksum_archive" | awk '{ print $1 }')
else
- warn 'No SHA-256 utility found; continuing without verification'
+ warn 'Checksum verification skipped: no SHA-256 utility (sha256sum or shasum) is available on this system'
return 0
fi
@@ -835,6 +838,18 @@ main() {
github_api_repo=$github_api_base/repos/$COMPOSIO_GITHUB_OWNER/$COMPOSIO_GITHUB_REPO
archive_name=composio-$target.zip
+ # Official ComposioHQ releases always publish a complete checksums.txt, so
+ # a missing manifest or entry is a hard error there. Any overridden source
+ # (mirror, test host, custom API base) keeps the lenient warn-and-continue
+ # behavior, since its manifests are outside our control.
+ official_release_source=0
+ if [ "$COMPOSIO_GITHUB_URL" = https://github.com ] &&
+ [ "$COMPOSIO_GITHUB_OWNER" = ComposioHQ ] &&
+ [ "$COMPOSIO_GITHUB_REPO" = composio ] &&
+ [ -z "$COMPOSIO_GITHUB_API_BASE_URL" ]; then
+ official_release_source=1
+ fi
+
requested_version=$version_arg
if [ -z "$requested_version" ]; then
requested_version=${COMPOSIO_INSTALL_VERSION:-}
@@ -871,6 +886,8 @@ main() {
if curl_download "$checksums_url" "$tmpdir/checksums.txt" 1; then
verify_checksum "$tmpdir/$archive_name" "$tmpdir/checksums.txt" "$archive_name"
+ elif [ "$official_release_source" = 1 ]; then
+ error "Failed to download checksums.txt from \"$checksums_url\". Official releases always publish checksums, so this release cannot be verified. Refusing to install."
else
warn 'No checksums.txt in this release; continuing without verification'
fi
diff --git a/test/install-sh-release-resolution.test.sh b/test/install-sh-release-resolution.test.sh
index c9c5e30ed..e20c41533 100755
--- a/test/install-sh-release-resolution.test.sh
+++ b/test/install-sh-release-resolution.test.sh
@@ -324,6 +324,7 @@ JSON
valid) printf '%064d %s\n' 0 "$TEST_ARCHIVE_NAME" | tr '0' 'a' >"$output" ;;
mismatch) printf '%064d %s\n' 0 "$TEST_ARCHIVE_NAME" | tr '0' 'b' >"$output" ;;
malformed) printf 'not-a-hash %s\n' "$TEST_ARCHIVE_NAME" >"$output" ;;
+ absent-entry) printf '%064d %s\n' 0 'some-other-asset.zip' | tr '0' 'a' >"$output" ;;
esac
;;
*)
@@ -444,7 +445,7 @@ EOF
export TEST_COMPOSIO_LOG="$composio_log"
reset_case() {
- unset CASE_GITHUB_URL CASE_API_BASE CASE_INSTALL_VERSION CASE_INSTALL_SHELL CASE_PLUGINS CASE_QUIET CASE_DEBUG CASE_HELP
+ unset CASE_GITHUB_URL CASE_GITHUB_OWNER CASE_GITHUB_REPO CASE_API_BASE CASE_INSTALL_VERSION CASE_INSTALL_SHELL CASE_PLUGINS CASE_QUIET CASE_DEBUG CASE_HELP
unset CASE_ALLOW_HTTP_HOST CASE_CHECKSUM_MODE CASE_API_ASSET_URL CASE_BASE_MODE CASE_REDIRECT_DOWNGRADE
unset CASE_SHELL_CAPABILITY CASE_INSTALL_EXIT CASE_SETUP_EXIT CASE_VERSION_EXIT CASE_PATH_PREFIX CASE_UNSET_SHELL
unset CASE_CURL_DELAY_URL CASE_CURL_DELAY_SECONDS CASE_SHELL_VALUE CASE_INSTALL_HINT CASE_INSTALL_RECONCILE
@@ -465,9 +466,11 @@ EOF
COMPOSIO_BIN_DIR="$bin_dir"
COMPOSIO_INSTALL_PLUGINS="${CASE_PLUGINS:-0}"
COMPOSIO_GITHUB_URL="${CASE_GITHUB_URL:-$github_url}"
- COMPOSIO_GITHUB_API_BASE_URL="${CASE_API_BASE:-$api_base}"
- COMPOSIO_GITHUB_OWNER=FakeOwner
- COMPOSIO_GITHUB_REPO=fake-repo
+ # CASE_API_BASE set-but-empty passes an empty API base through, which the
+ # installer treats as "no override" (official-source cases need this).
+ COMPOSIO_GITHUB_API_BASE_URL="${CASE_API_BASE-$api_base}"
+ COMPOSIO_GITHUB_OWNER="${CASE_GITHUB_OWNER:-FakeOwner}"
+ COMPOSIO_GITHUB_REPO="${CASE_GITHUB_REPO:-fake-repo}"
TEST_CHECKSUM_MODE="${CASE_CHECKSUM_MODE:-missing}"
TEST_SHELL_CAPABILITY="${CASE_SHELL_CAPABILITY:-supported}"
TEST_INSTALL_EXIT="${CASE_INSTALL_EXIT:-0}"
@@ -630,6 +633,59 @@ EOF
grep -qi 'checksum' <<<"$checksum_output" || fail "$interpreter_name $checksum_mode checksum error"
done
+ # Overridden sources (mirrors, test hosts) keep the lenient behavior: a
+ # missing checksums.txt or a manifest without an entry for the archive warns
+ # and the install proceeds.
+ reset_case
+ CASE_CHECKSUM_MODE=missing
+ lenient_output=$(run_installer "$case_root/lenient-home" "$case_root/lenient-install" "$case_root/lenient-bin" "$stable_tag" 2>&1) ||
+ fail "$interpreter_name overridden source with missing checksums.txt must proceed"
+ assert_contains "$lenient_output" 'No checksums.txt in this release; continuing without verification' \
+ "$interpreter_name overridden-source missing manifest warning"
+ [[ -x "$case_root/lenient-install/composio" ]] || fail "$interpreter_name overridden-source missing manifest must still install"
+
+ reset_case
+ CASE_CHECKSUM_MODE=absent-entry
+ entry_lenient_output=$(run_installer "$case_root/entry-lenient-home" "$case_root/entry-lenient-install" "$case_root/entry-lenient-bin" "$stable_tag" 2>&1) ||
+ fail "$interpreter_name overridden source with no checksum entry must proceed"
+ assert_contains "$entry_lenient_output" 'No checksum entry found' "$interpreter_name overridden-source absent entry warning"
+
+ # The official ComposioHQ source always publishes complete checksums, so the
+ # installer must hard-fail there when the manifest or the entry is missing.
+ # The env triple below matches the installer defaults exactly; the pinned
+ # version tag keeps the release API (and its overridden base) out of play.
+ official_env() {
+ CASE_GITHUB_URL=https://github.com
+ CASE_GITHUB_OWNER=ComposioHQ
+ CASE_GITHUB_REPO=composio
+ CASE_API_BASE=
+ }
+
+ reset_case
+ official_env
+ CASE_CHECKSUM_MODE=valid
+ run_installer "$case_root/official-valid-home" "$case_root/official-valid-install" "$case_root/official-valid-bin" "$stable_tag" >/dev/null 2>&1 ||
+ fail "$interpreter_name official source with a valid checksum must install"
+ [[ -x "$case_root/official-valid-install/composio" ]] || fail "$interpreter_name official-source valid checksum install"
+
+ reset_case
+ official_env
+ CASE_CHECKSUM_MODE=missing
+ if official_missing_output=$(run_installer "$case_root/official-missing-home" "$case_root/official-missing-install" "$case_root/official-missing-bin" "$stable_tag" 2>&1); then
+ fail "$interpreter_name official source with a missing checksums.txt must fail"
+ fi
+ assert_contains "$official_missing_output" 'Failed to download checksums.txt' "$interpreter_name official missing manifest error"
+ [[ ! -e "$case_root/official-missing-install/composio" ]] || fail "$interpreter_name official missing manifest must not install"
+
+ reset_case
+ official_env
+ CASE_CHECKSUM_MODE=absent-entry
+ if official_entry_output=$(run_installer "$case_root/official-entry-home" "$case_root/official-entry-install" "$case_root/official-entry-bin" "$stable_tag" 2>&1); then
+ fail "$interpreter_name official source with no checksum entry must fail"
+ fi
+ assert_contains "$official_entry_output" 'checksums.txt has no entry for' "$interpreter_name official absent entry error"
+ [[ ! -e "$case_root/official-entry-install/composio" ]] || fail "$interpreter_name official absent entry must not install"
+
reset_case
CASE_PLUGINS=1
run_installer "$case_root/plugins-home" "$case_root/plugins-install" "$case_root/plugins-bin" "$stable_tag" >/dev/null 2>&1