Skip to content

Composio powers 1000+ toolkits, tool search, context management, authentication, and a sandboxed workbench to help you build AI agents that turn intent into action.

fix(cli): always persist lastChecked timestamp to prevent retry loops

jkomynobe8a4ac76b7a
diff --git a/ts/packages/cli/src/services/update-check.ts b/ts/packages/cli/src/services/update-check.ts
index c882cc824..21ea17684 100644
--- a/ts/packages/cli/src/services/update-check.ts
+++ b/ts/packages/cli/src/services/update-check.ts
@@ -114,11 +114,13 @@ export function createUpdateChecker(config: UpdateCheckConfig) {
function checkForUpdate(): Promise<void> | undefined {
try {
// Throttle: skip if checked recently.
+ let previousLatestVersion: string | undefined;
try {
const state: UpdateCheckState = JSON.parse(readFileSync(config.stateFile, 'utf-8'));
if (Date.now() - new Date(state.lastChecked).getTime() < config.checkIntervalMs) {
return undefined;
}
+ previousLatestVersion = state.latestVersion;
} catch {
// ENOENT or corrupt file — re-check.
}
@@ -132,33 +134,35 @@ export function createUpdateChecker(config: UpdateCheckConfig) {
headers.Authorization = `Bearer ${config.accessToken}`;
}
- return (
- config
- .fetchFn(config.refsUrl, { headers, signal: AbortSignal.timeout(10_000) })
- .then(res => {
- if (!res.ok) throw new Error(`HTTP ${res.status}`);
- return res.json();
- })
- .then((refs: unknown) => {
- const latestVersion = parseLatestVersionFromRefs(refs);
- if (!latestVersion) return;
-
- const stateDir = dirname(config.stateFile);
- mkdirSync(stateDir, { recursive: true });
-
- const state: UpdateCheckState = {
- lastChecked: new Date().toISOString(),
- latestVersion,
- };
-
- return writeFile(config.stateFile, JSON.stringify(state, null, 2));
- })
- // Normalize return type to Promise<void> (writeFile returns void, early-return yields undefined).
- .then(() => {})
- .catch(() => {
- // Silently ignore — never block the CLI.
- })
- );
+ // Always persist lastChecked to prevent retry loops when the fetch
+ // fails or returns no matching tags.
+ const writeState = (latestVersion?: string): Promise<void> => {
+ const stateDir = dirname(config.stateFile);
+ mkdirSync(stateDir, { recursive: true });
+
+ const state: UpdateCheckState = {
+ lastChecked: new Date().toISOString(),
+ latestVersion: latestVersion ?? previousLatestVersion ?? config.currentVersion,
+ };
+
+ return writeFile(config.stateFile, JSON.stringify(state, null, 2)).then(() => {});
+ };
+
+ return config
+ .fetchFn(config.refsUrl, { headers, signal: AbortSignal.timeout(10_000) })
+ .then(res => {
+ if (!res.ok) throw new Error(`HTTP ${res.status}`);
+ return res.json();
+ })
+ .then((refs: unknown) => {
+ const latestVersion = parseLatestVersionFromRefs(refs);
+ return writeState(latestVersion);
+ })
+ .catch(() => {
+ // Silently ignore fetch/parse errors — never block the CLI.
+ // Still update the timestamp to prevent unbounded retry loops.
+ return writeState().catch(() => {});
+ });
} catch {
// Silently ignore.
return undefined;
diff --git a/ts/packages/cli/test/src/services/update-check.test.ts b/ts/packages/cli/test/src/services/update-check.test.ts
index 0dcc55d19..b26d9f779 100644
--- a/ts/packages/cli/test/src/services/update-check.test.ts
+++ b/ts/packages/cli/test/src/services/update-check.test.ts
@@ -247,7 +247,7 @@ describe('checkForUpdate', () => {
expect(state.latestVersion).toBe('0.5.0');
});
- it('does not write state when no CLI tags are found', async () => {
+ it('still writes lastChecked when no CLI tags are found', async () => {
const config = makeConfig({
fetchFn: vi.fn().mockResolvedValue({
ok: true,
@@ -258,10 +258,32 @@ describe('checkForUpdate', () => {
await checkForUpdate();
- expect(existsSync(config.stateFile)).toBe(false);
+ expect(existsSync(config.stateFile)).toBe(true);
+ const state: UpdateCheckState = JSON.parse(readFileSync(config.stateFile, 'utf-8'));
+ expect(state.lastChecked).toBeDefined();
+ // Falls back to currentVersion since no previous state and no tags found
+ expect(state.latestVersion).toBe(config.currentVersion);
+ });
+
+ it('preserves previous latestVersion when no CLI tags are found', async () => {
+ const config = makeConfig({
+ fetchFn: vi.fn().mockResolvedValue({
+ ok: true,
+ json: () => Promise.resolve([{ ref: 'refs/tags/@composio/[email protected]' }]),
+ }) as unknown as typeof fetch,
+ });
+ const stale = new Date(Date.now() - 25 * 60 * 60 * 1000).toISOString();
+ writeState(config, { lastChecked: stale, latestVersion: '0.3.0' });
+ const { checkForUpdate } = createUpdateChecker(config);
+
+ await checkForUpdate();
+
+ const state: UpdateCheckState = JSON.parse(readFileSync(config.stateFile, 'utf-8'));
+ expect(state.latestVersion).toBe('0.3.0');
+ expect(new Date(state.lastChecked).getTime()).toBeGreaterThan(new Date(stale).getTime());
});
- it('silently ignores HTTP errors', async () => {
+ it('writes lastChecked on HTTP errors to prevent retry loops', async () => {
const config = makeConfig({
fetchFn: vi.fn().mockResolvedValue({
ok: false,
@@ -273,10 +295,13 @@ describe('checkForUpdate', () => {
// Should not throw
await checkForUpdate();
- expect(existsSync(config.stateFile)).toBe(false);
+ expect(existsSync(config.stateFile)).toBe(true);
+ const state: UpdateCheckState = JSON.parse(readFileSync(config.stateFile, 'utf-8'));
+ expect(state.lastChecked).toBeDefined();
+ expect(state.latestVersion).toBe(config.currentVersion);
});
- it('silently ignores network errors', async () => {
+ it('writes lastChecked on network errors to prevent retry loops', async () => {
const config = makeConfig({
fetchFn: vi.fn().mockRejectedValue(new Error('DNS failed')) as unknown as typeof fetch,
});
@@ -284,7 +309,10 @@ describe('checkForUpdate', () => {
await checkForUpdate();
- expect(existsSync(config.stateFile)).toBe(false);
+ expect(existsSync(config.stateFile)).toBe(true);
+ const state: UpdateCheckState = JSON.parse(readFileSync(config.stateFile, 'utf-8'));
+ expect(state.lastChecked).toBeDefined();
+ expect(state.latestVersion).toBe(config.currentVersion);
});
it('sends Authorization header when accessToken is set', async () => {