Context7 Platform -- Up-to-date docs for AI agents
fix(mcp): preserve default CAs with NODE_EXTRA_CA_CERTS (#2432)
Fahreddin Özcan00833f926230
diff --git a/.changeset/silent-lions-smile.md b/.changeset/silent-lions-smile.mdnew file mode 100644index 00000000..0bf080b7--- /dev/null+++ b/.changeset/silent-lions-smile.md@@ -0,0 +1,5 @@+---+"@upstash/context7-mcp": patch+---++Preserve Node's default trusted CAs when `NODE_EXTRA_CA_CERTS` is configured, and add a regression test for custom CA loading.diff --git a/packages/mcp/eslint.config.js b/packages/mcp/eslint.config.jsindex aeb85ced..ae606cb7 100644--- a/packages/mcp/eslint.config.js+++ b/packages/mcp/eslint.config.js@@ -14,7 +14,7 @@ export default defineConfig(sourceType: "module",parser: tseslint.parser,parserOptions: {- project: "./tsconfig.json",+ project: ["./tsconfig.json", "./tsconfig.test.json"],tsconfigRootDir: import.meta.dirname,},globals: {diff --git a/packages/mcp/package.json b/packages/mcp/package.jsonindex fadb911b..463a4ac1 100644--- a/packages/mcp/package.json+++ b/packages/mcp/package.json@@ -5,7 +5,7 @@"description": "MCP server for Context7","scripts": {"build": "tsc && chmod 755 dist/index.js",- "test": "echo \"No tests yet\"",+ "test": "pnpm exec vitest run","typecheck": "tsc --noEmit","lint": "eslint .","lint:check": "eslint .",@@ -55,6 +55,7 @@},"devDependencies": {"@types/node": "^25.0.3",- "typescript": "^5.8.2"+ "typescript": "^5.8.2",+ "vitest": "^4.0.13"}}diff --git a/packages/mcp/src/lib/api.ts b/packages/mcp/src/lib/api.tsindex 716e05e2..2ba6e2a6 100644--- a/packages/mcp/src/lib/api.ts+++ b/packages/mcp/src/lib/api.ts@@ -3,6 +3,7 @@ import { ClientContext, generateHeaders } from "./encryption.js";import { Agent, ProxyAgent, setGlobalDispatcher } from "undici";import { CONTEXT7_API_BASE_URL } from "./constants.js";import { readFileSync } from "fs";+import tls from "tls";/*** Parses error response from the Context7 API@@ -45,13 +46,22 @@ const PROXY_URL: string | null =const CUSTOM_CA_CERTS: string | undefined = process.env.NODE_EXTRA_CA_CERTS;-function loadCustomCACerts(): Buffer | undefined {- if (!CUSTOM_CA_CERTS) return undefined;+export function getDefaultCACertificates(): string[] {+ if (typeof tls.getCACertificates === "function") {+ return tls.getCACertificates("default");+ }++ return [...tls.rootCertificates];+}++export function loadCustomCACerts(customCACertsPath = CUSTOM_CA_CERTS): string[] | undefined {+ if (!customCACertsPath) return undefined;try {- return readFileSync(CUSTOM_CA_CERTS);+ const customCa = readFileSync(customCACertsPath, "utf-8");+ return [...getDefaultCACertificates(), customCa];} catch (error) {console.error(- `[Context7] Failed to load custom CA certificates from ${CUSTOM_CA_CERTS}:`,+ `[Context7] Failed to load custom CA certificates from ${customCACertsPath}:`,error);return undefined;@@ -61,7 +71,12 @@ function loadCustomCACerts(): Buffer | undefined {if (PROXY_URL && !PROXY_URL.startsWith("$") && /^(http|https):\/\//i.test(PROXY_URL)) {try {const ca = loadCustomCACerts();- setGlobalDispatcher(new ProxyAgent({ uri: PROXY_URL, ...(ca ? { connect: { ca } } : {}) }));+ setGlobalDispatcher(+ new ProxyAgent({+ uri: PROXY_URL,+ ...(ca ? { requestTls: { ca }, proxyTls: { ca } } : {}),+ })+ );} catch (error) {console.error(`[Context7] Failed to configure proxy agent for provided proxy URL: ${PROXY_URL}:`,diff --git a/packages/mcp/test/certificate.test.ts b/packages/mcp/test/certificate.test.tsnew file mode 100644index 00000000..3fad3b79--- /dev/null+++ b/packages/mcp/test/certificate.test.ts@@ -0,0 +1,41 @@+import { mkdtempSync, rmSync, writeFileSync } from "node:fs";+import { tmpdir } from "node:os";+import { join } from "node:path";+import { expect, test } from "vitest";++import { getDefaultCACertificates, loadCustomCACerts } from "../src/lib/api.js";++test("loadCustomCACerts returns undefined when no path is provided", () => {+ expect(loadCustomCACerts(undefined)).toBeUndefined();+});++test("loadCustomCACerts appends custom certs to Node default CAs", () => {+ const tempDir = mkdtempSync(join(tmpdir(), "context7-ca-test-"));+ const certPath = join(tempDir, "custom-ca.pem");+ const customCert = [+ "-----BEGIN CERTIFICATE-----",+ "MIIBhTCCASugAwIBAgIUPcY2K4+testonlycertificateblockA9xYwCgYIKoZIzj0E",+ "AwIwGDEWMBQGA1UEAwwNQ29udGV4dDcgVGVzdDAeFw0yNjA0MTAwMDAwMDBaFw0y",+ "NjA0MTEwMDAwMDBaMBgxFjAUBgNVBAMMDUNvbnRleHQ3IFRlc3QwWTATBgcqhkjO",+ "PQIBBggqhkjOPQMBBwNCAASrK8V0k5YJmN5v1J3t2G9u8rY3C2Jw4P3u8K1JdQxWl",+ "m0x1X4Q2aO2m1QvX7p8oI1Y7r9cT5n6s4a8t0pVx4XWPo1MwUTAdBgNVHQ4EFgQU",+ "B1a8wN1Yv3e6m7J4k2a9jX0wCgYIKoZIzj0EAwIDSAAwRQIhALyM2n0XWw8b0e9j",+ "i0X9l3fY8o0s5Q0d3sV9mH0K7v5aAiB5a1T3qK9zR6wP8sV3mT7aN2k4dP6qC8e1",+ "n0uWJ0x4Qg==",+ "-----END CERTIFICATE-----",+ ].join("\n");++ writeFileSync(certPath, `${customCert}\n`, "utf-8");++ try {+ const defaultCAs = getDefaultCACertificates();+ const mergedCAs = loadCustomCACerts(certPath);++ expect(mergedCAs).toBeDefined();+ expect(mergedCAs).toHaveLength(defaultCAs.length + 1);+ expect(mergedCAs?.slice(0, defaultCAs.length)).toEqual(defaultCAs);+ expect(mergedCAs?.at(-1)).toBe(`${customCert}\n`);+ } finally {+ rmSync(tempDir, { recursive: true, force: true });+ }+});diff --git a/packages/mcp/tsconfig.test.json b/packages/mcp/tsconfig.test.jsonnew file mode 100644index 00000000..aa416540--- /dev/null+++ b/packages/mcp/tsconfig.test.json@@ -0,0 +1,9 @@+{+ "extends": "./tsconfig.json",+ "compilerOptions": {+ "outDir": "./dist-test",+ "rootDir": "."+ },+ "include": ["src/**/*", "test/**/*"],+ "exclude": ["node_modules", "dist", "dist-test"]+}diff --git a/pnpm-lock.yaml b/pnpm-lock.yamlindex e0665c67..aac4bf06 100644--- a/pnpm-lock.yaml+++ b/pnpm-lock.yaml@@ -131,6 +131,9 @@ importers:typescript:specifier: ^5.8.2version: 5.9.3+ vitest:+ specifier: ^4.0.13+ version: 4.0.14(@opentelemetry/[email protected])(@types/[email protected])packages/sdk:devDependencies:@@ -990,9 +993,6 @@ packages:resolution: {integrity: sha512-zBPfuzoI8xyBtR2P6WQj63Rz8i3AmfAaJLuNG8dWsfvPe8lO4aCPYLn879mEgHndZH1zQ2oXmG8O1GGzzaoZiw==}engines: {node: '>=18.0.0'}- '@standard-schema/[email protected]':- resolution: {integrity: sha512-m2bOd0f2RT9k8QJx1JN85cZYyH1RqFBdlwtkSlf4tBDYLCiiZnv1fIIwacK6cqwXavOydf0NPToMQgpKq+dVlA==}-'@standard-schema/[email protected]':resolution: {integrity: sha512-l2aFy5jALhniG5HgqrD6jXLi/rUWrKvqN/qJx6yoJsgKhblVd+iqqU4RCXavm/jPityDo5TCvKMnpjKnOriy0w==}@@ -3245,8 +3245,6 @@ snapshots:'@smithy/util-buffer-from': 4.2.0tslib: 2.8.1- '@standard-schema/[email protected]': {}-'@standard-schema/[email protected]': {}'@types/[email protected]':@@ -3414,7 +3412,7 @@ snapshots:'@vitest/[email protected]':dependencies:- '@standard-schema/spec': 1.0.0+ '@standard-schema/spec': 1.1.0'@types/chai': 5.2.3'@vitest/spy': 4.0.14'@vitest/utils': 4.0.14