An open-source, self-hostable PaaS alternative to Vercel, Heroku & Netlify that lets you easily deploy static sites, databases, full-stack applications and 360+ one-click services on your own servers.
PHP coolifydatabasesdeploymentdockerdocker-composeinertiajslaravelmariadbmysqlnextjsnodejsphppostgresredisself-hostedself-hostingserverstatic-sitesveltesvelte5
fix(settings): require instance admin authorization for updates page
Andras Bacsai0fed55320738
diff --git a/app/Livewire/Settings/Updates.php b/app/Livewire/Settings/Updates.phpindex 01a67c38ca..a200ef6890 100644--- a/app/Livewire/Settings/Updates.php+++ b/app/Livewire/Settings/Updates.php@@ -25,6 +25,9 @@ class Updates extends Componentpublic function mount(){+ if (! isInstanceAdmin()) {+ return redirect()->route('dashboard');+ }if (! isCloud()) {$this->server = Server::findOrFail(0);}diff --git a/tests/Feature/SettingsUpdatesAuthorizationTest.php b/tests/Feature/SettingsUpdatesAuthorizationTest.phpnew file mode 100644index 0000000000..5a062101a8--- /dev/null+++ b/tests/Feature/SettingsUpdatesAuthorizationTest.php@@ -0,0 +1,41 @@+<?php++use App\Livewire\Settings\Updates;+use App\Models\InstanceSettings;+use App\Models\Server;+use App\Models\Team;+use App\Models\User;+use Illuminate\Foundation\Testing\RefreshDatabase;+use Illuminate\Support\Once;+use Livewire\Livewire;++uses(RefreshDatabase::class);++test('non-admin user is redirected from settings updates page', function () {+ $team = Team::factory()->create();+ $user = User::factory()->create();+ $team->members()->attach($user->id, ['role' => 'member']);++ $this->actingAs($user);+ session(['currentTeam' => ['id' => $team->id]]);++ Livewire::test(Updates::class)+ ->assertRedirect(route('dashboard'));+});++test('instance admin can access settings updates page', function () {+ $rootTeam = Team::find(0) ?? Team::factory()->create(['id' => 0]);+ Server::factory()->create(['id' => 0, 'team_id' => $rootTeam->id]);+ InstanceSettings::create(['id' => 0]);+ Once::flush();++ $user = User::factory()->create();+ $rootTeam->members()->attach($user->id, ['role' => 'admin']);++ $this->actingAs($user);+ session(['currentTeam' => ['id' => $rootTeam->id]]);++ Livewire::test(Updates::class)+ ->assertOk()+ ->assertNoRedirect();+});