An open-source, self-hostable PaaS alternative to Vercel, Heroku & Netlify that lets you easily deploy static sites, databases, full-stack applications and 360+ one-click services on your own servers.
PHP coolifydatabasesdeploymentdockerdocker-composeinertiajslaravelmariadbmysqlnextjsnodejsphppostgresredisself-hostedself-hostingserverstatic-sitesveltesvelte5
fix(cleanup): disable unreachable self-hosted servers
Andras Bacsai1b68f11ec086
diff --git a/app/Console/Commands/CleanupUnreachableServers.php b/app/Console/Commands/CleanupUnreachableServers.phpindex 09563a2c39..666e98a182 100644--- a/app/Console/Commands/CleanupUnreachableServers.php+++ b/app/Console/Commands/CleanupUnreachableServers.php@@ -18,9 +18,13 @@ class CleanupUnreachableServers extends Commandif ($servers->count() > 0) {foreach ($servers as $server) {echo "Cleanup unreachable server ($server->id) with name $server->name";- $server->update([- 'ip' => '1.2.3.4',- ]);+ if (isCloud()) {+ $server->update([+ 'ip' => '1.2.3.4',+ ]);+ } else {+ $server->forceDisableServer();+ }}}}diff --git a/tests/Feature/CleanupUnreachableServersTest.php b/tests/Feature/CleanupUnreachableServersTest.phpindex c069449692..8849b1ca01 100644--- a/tests/Feature/CleanupUnreachableServersTest.php+++ b/tests/Feature/CleanupUnreachableServersTest.php@@ -6,7 +6,30 @@ use Illuminate\Foundation\Testing\RefreshDatabase;uses(RefreshDatabase::class);-it('cleans up servers with unreachable_count >= 3 after 7 days', function () {+it('disables (non-destructively) self-hosted servers with unreachable_count >= 3 after 7 days', function () {+ config(['constants.coolify.self_hosted' => true]);++ $team = Team::factory()->create();+ $server = Server::factory()->create([+ 'team_id' => $team->id,+ 'unreachable_count' => 50,+ 'unreachable_notification_sent' => true,+ 'updated_at' => now()->subDays(8),+ ]);++ $originalIp = (string) $server->ip;++ $this->artisan('cleanup:unreachable-servers')->assertSuccessful();++ $server->refresh();+ // IP must be preserved — never overwritten on self-hosted.+ expect($server->ip)->toBe($originalIp);+ expect($server->settings->force_disabled)->toBeTrue();+});++it('overwrites the IP with 1.2.3.4 on cloud for servers with unreachable_count >= 3 after 7 days', function () {+ config(['constants.coolify.self_hosted' => false]);+$team = Team::factory()->create();$server = Server::factory()->create(['team_id' => $team->id,@@ -36,6 +59,7 @@ it('does not clean up servers with unreachable_count less than 3', function () {$server->refresh();expect($server->ip)->toBe($originalIp);+ expect($server->settings->force_disabled)->toBeFalse();});it('does not clean up servers updated within 7 days', function () {@@ -53,6 +77,7 @@ it('does not clean up servers updated within 7 days', function () {$server->refresh();expect($server->ip)->toBe($originalIp);+ expect($server->settings->force_disabled)->toBeFalse();});it('does not clean up servers without notification sent', function () {@@ -70,4 +95,5 @@ it('does not clean up servers without notification sent', function () {$server->refresh();expect($server->ip)->toBe($originalIp);+ expect($server->settings->force_disabled)->toBeFalse();});