Skip to content

An open-source, self-hostable PaaS alternative to Vercel, Heroku & Netlify that lets you easily deploy static sites, databases, full-stack applications and 360+ one-click services on your own servers.

fix(auth): queue verification emails for cloud registrations

Andras Bacsai1f412c7145c8
diff --git a/app/Actions/Fortify/CreateNewUser.php b/app/Actions/Fortify/CreateNewUser.php
index 0fcb11df22..44602f0619 100644
--- a/app/Actions/Fortify/CreateNewUser.php
+++ b/app/Actions/Fortify/CreateNewUser.php
@@ -2,6 +2,7 @@
namespace App\Actions\Fortify;
+use App\Jobs\SendVerificationEmailJob;
use App\Models\Team;
use App\Models\User;
use Illuminate\Support\Facades\Hash;
@@ -74,7 +75,7 @@ class CreateNewUser implements CreatesNewUsers
]);
$team = $user->teams()->first();
if (isCloud()) {
- $user->sendVerificationEmail();
+ SendVerificationEmailJob::dispatch($user);
} else {
$user->markEmailAsVerified();
}
diff --git a/app/Jobs/SendVerificationEmailJob.php b/app/Jobs/SendVerificationEmailJob.php
new file mode 100644
index 0000000000..b9d2c8e11e
--- /dev/null
+++ b/app/Jobs/SendVerificationEmailJob.php
@@ -0,0 +1,29 @@
+<?php
+
+namespace App\Jobs;
+
+use App\Models\User;
+use Illuminate\Contracts\Queue\ShouldQueue;
+use Illuminate\Foundation\Queue\Queueable;
+
+class SendVerificationEmailJob implements ShouldQueue
+{
+ use Queueable;
+
+ public $tries = 3;
+
+ public $backoff = 10;
+
+ public function __construct(public User $user)
+ {
+ $this->onQueue('high');
+ }
+
+ /**
+ * Execute the job.
+ */
+ public function handle(): void
+ {
+ $this->user->sendVerificationEmail();
+ }
+}
diff --git a/tests/Feature/RegistrationRateLimitTest.php b/tests/Feature/RegistrationRateLimitTest.php
index 4107e4a81d..3f7c4920db 100644
--- a/tests/Feature/RegistrationRateLimitTest.php
+++ b/tests/Feature/RegistrationRateLimitTest.php
@@ -1,8 +1,10 @@
<?php
+use App\Jobs\SendVerificationEmailJob;
use App\Models\InstanceSettings;
use App\Models\User;
use Illuminate\Foundation\Testing\RefreshDatabase;
+use Illuminate\Support\Facades\Queue;
use Illuminate\Support\Facades\RateLimiter;
uses(RefreshDatabase::class);
@@ -134,3 +136,24 @@ it('keeps distinct dotted and plus-addressed mailboxes in separate rate limit bu
RateLimiter::clear($registrationIpKey);
}
});
+
+it('queues the verification email for cloud registrations', function () {
+ config()->set('constants.coolify.self_hosted', false);
+ Queue::fake();
+
+ $this->withHeader('CF-Connecting-IP', '2001:db8::30')
+ ->post('/register', [
+ 'name' => 'Cloud User',
+ 'email' => '[email protected]',
+ 'password' => 'Password1!@',
+ 'password_confirmation' => 'Password1!@',
+ ])
+ ->assertRedirect();
+
+ $user = User::query()->where('email', '[email protected]')->firstOrFail();
+
+ Queue::assertPushed(
+ SendVerificationEmailJob::class,
+ fn (SendVerificationEmailJob $job) => $job->user->is($user)
+ );
+});