Skip to content

An open-source, self-hostable PaaS alternative to Vercel, Heroku & Netlify that lets you easily deploy static sites, databases, full-stack applications and 360+ one-click services on your own servers.

fix(api): allow disabling build server mode

Andras Bacsai217541a98776
diff --git a/app/Http/Controllers/Api/ServersController.php b/app/Http/Controllers/Api/ServersController.php
index 5082bd856c..e43026a728 100644
--- a/app/Http/Controllers/Api/ServersController.php
+++ b/app/Http/Controllers/Api/ServersController.php
@@ -726,9 +726,9 @@ class ServersController extends Controller
}
$server->update($updateFields);
- if ($request->is_build_server) {
+ if ($request->has('is_build_server')) {
$server->settings()->update([
- 'is_build_server' => $request->is_build_server,
+ 'is_build_server' => $request->boolean('is_build_server'),
]);
}
diff --git a/tests/Feature/ServerUpdatePrivateKeyApiTest.php b/tests/Feature/ServerUpdatePrivateKeyApiTest.php
index a6e4071687..8bc5f1d0e5 100644
--- a/tests/Feature/ServerUpdatePrivateKeyApiTest.php
+++ b/tests/Feature/ServerUpdatePrivateKeyApiTest.php
@@ -93,6 +93,17 @@ it('keeps the existing private key when private_key_uuid is omitted', function (
->and($server->private_key_id)->toBe($this->oldPrivateKey->id);
});
+it('can disable build server mode via API', function () {
+ $this->server->settings()->update(['is_build_server' => true]);
+
+ patchServerUpdatePrivateKeyApi($this, $this->server, $this->bearerToken, [
+ 'is_build_server' => false,
+ ])->assertCreated()
+ ->assertJson(['uuid' => $this->server->uuid]);
+
+ expect($this->server->settings->fresh()->is_build_server)->toBeFalse();
+});
+
it('rejects an invalid disk usage check frequency without partially updating the server', function () {
$this->server->proxy->set('type', 'TRAEFIK');
$this->server->save();