Skip to content

An open-source, self-hostable PaaS alternative to Vercel, Heroku & Netlify that lets you easily deploy static sites, databases, full-stack applications and 360+ one-click services on your own servers.

fix(terminal): exit fullscreen when PTY exits

Andras Bacsai24fc8db8dbfe
diff --git a/resources/js/terminal.js b/resources/js/terminal.js
index eedc1faa94..9dc571e265 100644
--- a/resources/js/terminal.js
+++ b/resources/js/terminal.js
@@ -527,6 +527,8 @@ export function initializeTerminalComponent() {
// Notify parent component that terminal connection failed
this.$wire.dispatch('terminalDisconnected');
} else if (event.data === 'pty-exited') {
+ this.fullscreen = false;
+ this.mobileToolbarCollapsed = false;
this.terminalActive = false;
this.resetTerminalSessionCountdown();
this.term.reset();
diff --git a/tests/Feature/RealtimeTerminalPackagingTest.php b/tests/Feature/RealtimeTerminalPackagingTest.php
index eed95e342c..48072065d9 100644
--- a/tests/Feature/RealtimeTerminalPackagingTest.php
+++ b/tests/Feature/RealtimeTerminalPackagingTest.php
@@ -28,8 +28,8 @@ it('keeps realtime terminal server logging behind the explicit debug flag', func
$terminalServer = file_get_contents(base_path('docker/coolify-realtime/terminal-server.js'));
expect($terminalServer)
- ->toContain("const terminalDebugEnabled = ['1', 'true', 'yes'].includes(")
- ->toContain('process.env.TERMINAL_DEBUG')
+ ->toContain('const debugOverride = String(process.env.TERMINAL_DEBUG')
+ ->toContain("['1', 'true', 'yes', 'on'].includes(debugOverride)")
->toContain('if (!terminalDebugEnabled) {')
->not->toContain("console.log('Coolify realtime terminal server listening on port 6002. Let the hacking begin!');");
});
@@ -90,6 +90,16 @@ it('keeps Livewire alive in background tabs while a terminal is connected', func
->toContain('wire:poll.keep-alive.30s="keepTerminalPageAlive"');
});
+it('exits fullscreen when the terminal process exits', function () {
+ $terminalClient = file_get_contents(resource_path('js/terminal.js'));
+
+ expect($terminalClient)
+ ->toContain("event.data === 'pty-exited'")
+ ->toContain('this.fullscreen = false;
+ this.mobileToolbarCollapsed = false;
+ this.terminalActive = false;');
+});
+
it('replays the last command on reconnect so the PTY respawns automatically', function () {
$terminalClient = file_get_contents(base_path('resources/js/terminal.js'));
@@ -178,7 +188,7 @@ it('uses simple fullscreen bottom margin based on mobile toolbar visibility', fu
->not->toContain('terminalFullscreenHeight')
->not->toContain('window.visualViewport?.height')
->and($terminalView)
- ->toContain("mobileToolbarCollapsed ? 'h-[calc(100dvh-3.5rem)] mb-14 px-2 py-1 bg-black' : 'h-[calc(100dvh-11rem)] mb-[11rem] px-2 py-1 bg-black'")
+ ->toContain("mobileToolbarCollapsed ? 'h-[calc(100dvh-3.5rem)] mb-14 px-2 py-1 bg-black' : 'h-[calc(100dvh-6rem)] mb-[6rem] px-2 py-1 bg-black'")
->toContain("fullscreen ? 'absolute inset-x-0 bottom-0 z-[9999] px-2 pb-2'");
});