Skip to content

An open-source, self-hostable PaaS alternative to Vercel, Heroku & Netlify that lets you easily deploy static sites, databases, full-stack applications and 360+ one-click services on your own servers.

fix(ssl): issue P-256 server certificates so Electron clients connect

Andras Bacsai284adede6cc0
diff --git a/app/Helpers/SslHelper.php b/app/Helpers/SslHelper.php
index 13ad941f5f..dc3f1dd5fe 100644
--- a/app/Helpers/SslHelper.php
+++ b/app/Helpers/SslHelper.php
@@ -35,7 +35,8 @@ class SslHelper
try {
$privateKey = openssl_pkey_new([
'private_key_type' => OPENSSL_KEYTYPE_EC,
- 'curve_name' => 'secp521r1',
+ // Electron clients such as MongoDB Compass (BoringSSL) cannot use a P-521 server key.
+ 'curve_name' => $isCaCertificate ? 'secp521r1' : 'prime256v1',
]);
if ($privateKey === false) {
diff --git a/tests/Feature/SslCertificateKeyCurveTest.php b/tests/Feature/SslCertificateKeyCurveTest.php
new file mode 100644
index 0000000000..be7686fae7
--- /dev/null
+++ b/tests/Feature/SslCertificateKeyCurveTest.php
@@ -0,0 +1,36 @@
+<?php
+
+use App\Helpers\SslHelper;
+use App\Models\Server;
+use App\Models\Team;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+
+uses(RefreshDatabase::class);
+
+function certificateCurve(string $certificate): ?string
+{
+ return openssl_pkey_get_details(openssl_pkey_get_public($certificate))['ec']['curve_name'] ?? null;
+}
+
+it('keeps the CA on P-521 and gives server certificates a P-256 key that Electron clients such as MongoDB Compass accept', function () {
+ $server = Server::factory()->create(['team_id' => Team::factory()->create()->id]);
+
+ $caCertificate = SslHelper::generateSslCertificate(
+ commonName: 'Coolify CA Certificate',
+ serverId: $server->id,
+ isCaCertificate: true,
+ validityDays: 10 * 365,
+ );
+
+ $serverCertificate = SslHelper::generateSslCertificate(
+ commonName: 'database',
+ serverId: $server->id,
+ caCert: $caCertificate->ssl_certificate,
+ caKey: $caCertificate->ssl_private_key,
+ );
+
+ expect(certificateCurve($caCertificate->ssl_certificate))->toBe('secp521r1')
+ ->and(certificateCurve($serverCertificate->ssl_certificate))->toBe('prime256v1')
+ ->and(openssl_x509_check_private_key($serverCertificate->ssl_certificate, $serverCertificate->ssl_private_key))->toBeTrue()
+ ->and(openssl_x509_verify($serverCertificate->ssl_certificate, openssl_pkey_get_public($caCertificate->ssl_certificate)))->toBe(1);
+});